From 086d1cc127f12e31ed315b41ca59ec0c3e88c7f4 Mon Sep 17 00:00:00 2001
From: kisbg <kisbg@inf.u-szeged.hu>
Date: Mon, 17 Aug 2020 11:06:44 +0200
Subject: [PATCH] Added missing object deref in ecma_promise_reject_or_resolve
 (#4144)

fixes #4131

JerryScript-DCO-1.0-Signed-off-by: bence gabor kis kisbg@inf.u-szeged.hu
---
 .../ecma/operations/ecma-promise-object.c     |  1 +
 .../es.next/regression-test-issue-4131.js     | 49 +++++++++++++++++++
 2 files changed, 50 insertions(+)
 create mode 100644 tests/jerry/es.next/regression-test-issue-4131.js

diff --git a/jerry-core/ecma/operations/ecma-promise-object.c b/jerry-core/ecma/operations/ecma-promise-object.c
index d4abf3005..e8bd9a41a 100644
--- a/jerry-core/ecma/operations/ecma-promise-object.c
+++ b/jerry-core/ecma/operations/ecma-promise-object.c
@@ -806,6 +806,7 @@ ecma_promise_reject_or_resolve (ecma_value_t this_arg, /**< "this" argument */
 
   if (ECMA_IS_VALUE_ERROR (call_ret))
   {
+    ecma_deref_object (capability_obj_p);
     return call_ret;
   }
 
diff --git a/tests/jerry/es.next/regression-test-issue-4131.js b/tests/jerry/es.next/regression-test-issue-4131.js
new file mode 100644
index 000000000..4208e5392
--- /dev/null
+++ b/tests/jerry/es.next/regression-test-issue-4131.js
@@ -0,0 +1,49 @@
+// Copyright JS Foundation and other contributors, http://js.foundation
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+var P = function (executor) {
+  return new Promise (function () {
+    executor (
+      function () {},
+      function () {
+        throw new TypeError ();
+      }
+    );
+  });
+};
+
+try {
+  Promise.reject.call (P);
+  assert (false)
+} catch (e) {
+  assert ( e instanceof TypeError)
+}
+
+var P = function (executor) {
+  return new Promise ( function() {
+    executor(
+      function () {
+        throw new TypeError ();
+      },
+      function () {}
+    );
+  });
+};
+
+try {
+  Promise.resolve.call(P);
+  assert (false)
+} catch (e) {
+  assert ( e instanceof TypeError)
+}