archive-gh-me/ish
1
0
Fork 0
mirror of https://github.com/ish-app/ish.git synced 2026-02-01 14:32:26 +00:00
Code Issues Projects Releases Wiki Activity

Assert blocks don't get too big

Browse Source
This commit is contained in:
Theodore Dubois 2018-05-30 17:38:29 -07:00
parent 31edab5849
commit a092f01491
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
emu/jit.c
View File

@ -60,13 +60,15 @@ static struct jit_block *jit_block_compile(addr_t ip, struct tlb *tlb) {
while (true) {
if (!gen_step32(&state, tlb))
break;
// no block should span more than 2 pages, guarantee this by stopping
// as soon as there's less space left than the maximum length of an
// x86 instruction
// no block should span more than 2 pages
// guarantee this by limiting total block size to 1 page
// guarantee that by stopping as soon as there's less space left than
// the maximum length of an x86 instruction
// TODO refuse to decode instructions longer than 15 bytes
if (state.ip - ip >= PAGE_SIZE - 15)
break;
}
assert(state.ip - ip <= PAGE_SIZE);
return state.block;
}