From 7528efbd320a691e883a0b5d51682de2a704837a Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sat, 25 Aug 2018 11:31:23 -0400 Subject: [PATCH] grpc-js-core: remove use of deprecated Buffer() constructor The Buffer() constructor should not be used. This commit replaces its use in grpc-js-core tests with Buffer.from(). --- packages/grpc-js-core/test/test-metadata.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/grpc-js-core/test/test-metadata.ts b/packages/grpc-js-core/test/test-metadata.ts index 6e227532..dd2d7c94 100644 --- a/packages/grpc-js-core/test/test-metadata.ts +++ b/packages/grpc-js-core/test/test-metadata.ts @@ -30,7 +30,7 @@ describe('Metadata', () => { describe('set', () => { it('Only accepts string values for non "-bin" keys', () => { assert.throws(() => { - metadata.set('key', new Buffer('value')); + metadata.set('key', Buffer.from('value')); }); assert.doesNotThrow(() => { metadata.set('key', 'value'); @@ -42,7 +42,7 @@ describe('Metadata', () => { metadata.set('key-bin', 'value'); }); assert.doesNotThrow(() => { - metadata.set('key-bin', new Buffer('value')); + metadata.set('key-bin', Buffer.from('value')); }); }); @@ -89,7 +89,7 @@ describe('Metadata', () => { describe('add', () => { it('Only accepts string values for non "-bin" keys', () => { assert.throws(() => { - metadata.add('key', new Buffer('value')); + metadata.add('key', Buffer.from('value')); }); assert.doesNotThrow(() => { metadata.add('key', 'value'); @@ -101,7 +101,7 @@ describe('Metadata', () => { metadata.add('key-bin', 'value'); }); assert.doesNotThrow(() => { - metadata.add('key-bin', new Buffer('value')); + metadata.add('key-bin', Buffer.from('value')); }); }); @@ -151,7 +151,7 @@ describe('Metadata', () => { beforeEach(() => { metadata.add('key', 'value1'); metadata.add('key', 'value2'); - metadata.add('key-bin', new Buffer('value')); + metadata.add('key-bin', Buffer.from('value')); }); it('gets all values associated with a key', () => {