From a1a74ca19a9e51c666125567d287129a76521663 Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 26 Sep 2018 09:55:09 -0700 Subject: [PATCH 1/3] Add a jsdoc @deprecated for grpc.load. --- packages/grpc-native-core/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/grpc-native-core/index.js b/packages/grpc-native-core/index.js index 3a1c9f79..b01736b1 100644 --- a/packages/grpc-native-core/index.js +++ b/packages/grpc-native-core/index.js @@ -101,6 +101,8 @@ var loadObject = exports.loadObject; /** * Load a gRPC object from a .proto file. + * @deprecated Use the {@link https://www.npmjs.com/package/@grpc/proto-loader|proto-loader module} + with grpc.loadPackageDefinition instead. * @memberof grpc * @alias grpc.load * @param {string|{root: string, file: string}} filename The file to load @@ -376,4 +378,4 @@ exports.Channel = grpc.Channel; * {@link grpc.propagate} that indicates what information to propagate * from parentCall * @return {grpc~Call} - */ \ No newline at end of file + */ From 41c840d18601596c5c9ac64649bfa4d9fded70d7 Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 26 Sep 2018 09:59:10 -0700 Subject: [PATCH 2/3] Add a link to protobufjs' documentation. --- packages/grpc-protobufjs/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/grpc-protobufjs/README.md b/packages/grpc-protobufjs/README.md index 651da848..4c986ded 100644 --- a/packages/grpc-protobufjs/README.md +++ b/packages/grpc-protobufjs/README.md @@ -1,6 +1,8 @@ # gRPC Protobuf Loader A utility package for loading `.proto` files for use with gRPC, using the latest Protobuf.js package. +Please refer to [protobuf.js' documentation](https://github.com/dcodeIO/protobuf.js/blob/master/README.md) +to understands its usage and limitations. ## Installation From 696aafe19dacc3ca292bbb0ec249637cbcf2d66c Mon Sep 17 00:00:00 2001 From: Nicolas Noble Date: Wed, 26 Sep 2018 11:11:34 -0700 Subject: [PATCH 3/3] s/usage/features/ --- packages/grpc-protobufjs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/grpc-protobufjs/README.md b/packages/grpc-protobufjs/README.md index 4c986ded..481b8629 100644 --- a/packages/grpc-protobufjs/README.md +++ b/packages/grpc-protobufjs/README.md @@ -2,7 +2,7 @@ A utility package for loading `.proto` files for use with gRPC, using the latest Protobuf.js package. Please refer to [protobuf.js' documentation](https://github.com/dcodeIO/protobuf.js/blob/master/README.md) -to understands its usage and limitations. +to understands its features and limitations. ## Installation