From c415fe03cd33049d3875b39e7eb10b3e635353d1 Mon Sep 17 00:00:00 2001 From: Justin Beckwith Date: Thu, 15 Nov 2018 12:28:31 -0800 Subject: [PATCH] refactor: drop usage of _.forOwn --- packages/grpc-native-core/src/metadata.js | 9 ++++++--- packages/grpc-native-core/src/server.js | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/grpc-native-core/src/metadata.js b/packages/grpc-native-core/src/metadata.js index 2b10bc80..9d00c722 100644 --- a/packages/grpc-native-core/src/metadata.js +++ b/packages/grpc-native-core/src/metadata.js @@ -122,7 +122,8 @@ Metadata.prototype.get = function(key) { */ Metadata.prototype.getMap = function() { var result = {}; - _.forOwn(this._internal_repr, function(values, key) { + Object.keys(this._internal_repr).forEach(key => { + const values = this._internal_repr[key]; if(values.length > 0) { result[key] = values[0]; } @@ -136,7 +137,8 @@ Metadata.prototype.getMap = function() { */ Metadata.prototype.clone = function() { var copy = new Metadata(); - _.forOwn(this._internal_repr, function(value, key) { + Object.keys(this._internal_repr).forEach(key => { + const value = this._internal_repr[key]; copy._internal_repr[key] = _.clone(value); }); return copy; @@ -162,7 +164,8 @@ Metadata.prototype._getCoreRepresentation = function() { Metadata._fromCoreRepresentation = function(metadata) { var newMetadata = new Metadata(); if (metadata) { - _.forOwn(metadata, function(value, key) { + Object.keys(metadata).forEach(key => { + const value = metadata[key]; newMetadata._internal_repr[key] = _.clone(value); }); } diff --git a/packages/grpc-native-core/src/server.js b/packages/grpc-native-core/src/server.js index 15b43022..bc333e4a 100644 --- a/packages/grpc-native-core/src/server.js +++ b/packages/grpc-native-core/src/server.js @@ -878,7 +878,8 @@ Server.prototype.addService = function(service, implementation) { throw new Error('Can\'t add a service to a started server.'); } var self = this; - _.forOwn(service, function(attrs, name) { + Object.keys(service).forEach(name => { + const attrs = service[name]; var method_type; if (attrs.requestStream) { if (attrs.responseStream) {