From 989288c1f03f651fade22b28c57ef10187da863e Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Thu, 7 Nov 2019 17:22:03 -0800 Subject: [PATCH] grpc-js: Add detail to invalid metadata error --- packages/grpc-js/src/metadata.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/grpc-js/src/metadata.ts b/packages/grpc-js/src/metadata.ts index 67a23960..873e5ff5 100644 --- a/packages/grpc-js/src/metadata.ts +++ b/packages/grpc-js/src/metadata.ts @@ -16,6 +16,8 @@ */ import * as http2 from 'http2'; +import { log } from './logging'; +import { LogVerbosity } from './constants'; const LEGAL_KEY_REGEX = /^[0-9a-z_.-]+$/; const LEGAL_NON_BINARY_VALUE_REGEX = /^[ -~]*$/; @@ -272,8 +274,8 @@ export class Metadata { } } } catch (error) { - error.message = `Failed to add metadata entry ${key}: ${values}. ${error.message}`; - process.emitWarning(error); + const message = `Failed to add metadata entry ${key}: ${values}. ${error.message}. For more information see https://github.com/grpc/grpc-node/issues/1173`; + log(LogVerbosity.ERROR, message); } }); return result;