From 4886dddee57a81a1e0dc07ad298e584bfa0292b9 Mon Sep 17 00:00:00 2001 From: Marek Gilbert Date: Tue, 26 Jan 2016 05:53:11 -0800 Subject: [PATCH] Allocate node Buffer contents with new[] Nan::NewBuffer(char* data, uint32_t size) frees the provided buffer by calling delete[]. This matches the allocation method to the free method. Fixes grpc/grpc#4867. --- ext/byte_buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/byte_buffer.cc b/ext/byte_buffer.cc index c306292c..4878219a 100644 --- a/ext/byte_buffer.cc +++ b/ext/byte_buffer.cc @@ -69,7 +69,7 @@ Local ByteBufferToBuffer(grpc_byte_buffer *buffer) { return scope.Escape(Nan::Null()); } size_t length = grpc_byte_buffer_length(buffer); - char *result = reinterpret_cast(calloc(length, sizeof(char))); + char *result = new char[length]; size_t offset = 0; grpc_byte_buffer_reader reader; grpc_byte_buffer_reader_init(&reader, buffer);