From 7c2bb2a237eb25eb13f4aefbdc03a53ca2031236 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Fri, 21 Jun 2019 19:34:45 -0400 Subject: [PATCH] grpc-js: don't overwrite existing error codes This commit causes RPC handlers to default to INTERNAL when an error occurs, but does not overwrite an existing error code. --- packages/grpc-js/src/server.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts index 0d92881b..e6d17619 100644 --- a/packages/grpc-js/src/server.ts +++ b/packages/grpc-js/src/server.ts @@ -374,7 +374,11 @@ export class Server { } } catch (err) { const call = new Http2ServerCallStream(stream, null!); - err.code = Status.INTERNAL; + + if (err.code === undefined) { + err.code = Status.INTERNAL; + } + call.sendError(err); } }