archive-gh-me/grpc-node
1
0
Fork 0
mirror of https://github.com/grpc/grpc-node.git synced 2025-12-08 18:23:54 +00:00
Code Issues Projects Releases Wiki Activity

Don't allow null load balancing configs

Browse Source
This commit is contained in:
Michael Lumish 2020-05-05 14:29:53 -07:00
parent 6e202e0b53
commit 7aa9177fa3
4 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/grpc-js/src/load-balancer-child-handler.ts
View File

@ -84,12 +84,9 @@ export class ChildLoadBalancerHandler implements LoadBalancer {
*/
updateAddressList(
addressList: SubchannelAddress[],
lbConfig: LoadBalancingConfig | null,
lbConfig: LoadBalancingConfig,
attributes: { [key: string]: unknown }
): void {
if (lbConfig === null) {
return;
}
let childToUpdate: LoadBalancer;
if (
this.currentChild === null ||

2
packages/grpc-js/src/load-balancer-pick-first.ts
View File

@ -383,7 +383,7 @@ export class PickFirstLoadBalancer implements LoadBalancer {
updateAddressList(
addressList: SubchannelAddress[],
lbConfig: LoadBalancingConfig | null
lbConfig: LoadBalancingConfig
): void {
// lbConfig has no useful information for pick first load balancing
/* To avoid unnecessary churn, we only do something with this address list

2
packages/grpc-js/src/load-balancer-round-robin.ts
View File

@ -189,7 +189,7 @@ export class RoundRobinLoadBalancer implements LoadBalancer {
updateAddressList(
addressList: SubchannelAddress[],
lbConfig: LoadBalancingConfig | null
lbConfig: LoadBalancingConfig
): void {
this.resetSubchannelList();
trace(

2
packages/grpc-js/src/load-balancer.ts
View File

@ -67,7 +67,7 @@ export interface LoadBalancer {
*/
updateAddressList(
addressList: SubchannelAddress[],
lbConfig: LoadBalancingConfig | null,
lbConfig: LoadBalancingConfig,
attributes: { [key: string]: unknown }
): void;
/**