archive-gh-me/grpc-node
1
0
Fork 0
mirror of https://github.com/grpc/grpc-node.git synced 2025-12-08 18:23:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2073 from murgatroid99/grpc-js_write_error_handling

Browse Source 
grpc-js: Avoid surfacing errors without gRPC error codes
This commit is contained in:
Michael Lumish 2022-03-30 09:39:52 -07:00 committed by GitHub
commit 76d03e7f47
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/grpc-js/src/call-stream.ts
View File

@ -839,7 +839,16 @@ export class Http2CallStream implements Call {
message,
flags: context.flags,
};
const cb: WriteCallback = context.callback ?? (() => {});
const cb: WriteCallback = (error?: Error | null) => {
let code: Status = Status.UNAVAILABLE;
if ((error as NodeJS.ErrnoException)?.code === 'ERR_STREAM_WRITE_AFTER_END') {
code = Status.INTERNAL;
}
if (error) {
this.cancelWithStatus(code, `Write error: ${error.message}`);
}
context.callback?.();
};
this.isWriteFilterPending = true;
this.filterStack.sendMessage(Promise.resolve(writeObj)).then((message) => {
this.isWriteFilterPending = false;