archive-gh-me/grpc-node
1
0
Fork 0
mirror of https://github.com/grpc/grpc-node.git synced 2025-12-08 18:23:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #579 from murgatroid99/native_async_bind_port

Browse Source 
Native: add Server#bindAsync
This commit is contained in:
Michael Lumish 2018-10-19 15:58:48 -07:00 committed by GitHub
commit 65cd6bafd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
packages/grpc-native-core/src/server.js
View File

@ -954,6 +954,7 @@ Server.prototype.addProtoService = util.deprecate(function(service,
* "address:port"
* @param {grpc.ServerCredentials} creds Server credential object to be used for
* SSL. Pass an insecure credentials object for an insecure port.
* @return {number} The bound port number. Negative if binding the port failed.
*/
Server.prototype.bind = function(port, creds) {
if (this.started) {
@ -962,4 +963,32 @@ Server.prototype.bind = function(port, creds) {
return this._server.addHttp2Port(port, creds);
};
/**
* Called with the result of attempting to bind a port
* @callback grpc.Server~bindCallback
* @param {Error=} error If non-null, indicates that binding the port failed.
* @param {number} port The bound port number. If binding the port fails, this
* will be negative to match the output of bind.
*/
/**
* Binds the server to the given port, with SSL disabled if creds is an
* insecure credentials object. Provides the result asynchronously.
* @param {string} port The port that the server should bind on, in the format
* "address:port"
* @param {grpc.ServerCredentials} creds Server credential object to be used for
* SSL. Pass an insecure credentials object for an insecure port.
*/
Server.prototype.bindAsync = function(port, creds, callback) {
/* This can throw. We do not try to catch that error because it indicates an
* incorrect use of the function, which should not be surfaced asynchronously
*/
const result = this.bind(port, creds)
if (result < 0) {
setImmediate(callback, new Error('Failed to bind port'), result);
} else {
setImmediate(callback, null, result);
}
}
exports.Server = Server;

14
packages/grpc-native-core/test/async_test.js
View File

@ -37,14 +37,16 @@ var getServer = require('./math/math_server.js');
var server = getServer();
let serverCreds = grpc.ServerCredentials.createInsecure();
describe('Async functionality', function() {
before(function(done) {
var port_num = server.bind('0.0.0.0:0',
grpc.ServerCredentials.createInsecure());
server.start();
math_client = new math.Math('localhost:' + port_num,
grpc.credentials.createInsecure());
done();
server.bindAsync('0.0.0.0:0', serverCreds, (error, port_num) => {
server.start();
math_client = new math.Math('localhost:' + port_num,
grpc.credentials.createInsecure());
done();
});
});
after(function() {
grpc.closeClient(math_client);