From 9c3291eeaa646d4f2c02ea0fae9004b9c60eb77e Mon Sep 17 00:00:00 2001 From: Ileriayo Adebiyi Date: Mon, 12 Feb 2024 14:48:05 +0100 Subject: [PATCH 1/3] Fix deprecated code --- examples/helloworld/dynamic_codegen/greeter_server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/helloworld/dynamic_codegen/greeter_server.js b/examples/helloworld/dynamic_codegen/greeter_server.js index c606cd8c..29924be7 100644 --- a/examples/helloworld/dynamic_codegen/greeter_server.js +++ b/examples/helloworld/dynamic_codegen/greeter_server.js @@ -45,7 +45,7 @@ function main() { var server = new grpc.Server(); server.addService(hello_proto.Greeter.service, {sayHello: sayHello}); server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => { - server.start(); + server; }); } From 300a23698c970f00554718f0f9951e769860394b Mon Sep 17 00:00:00 2001 From: Ileriayo Adebiyi Date: Mon, 12 Feb 2024 21:09:18 +0100 Subject: [PATCH 2/3] Fix deprecated statement --- examples/deadline/server.js | 7 +++++-- examples/helloworld/dynamic_codegen/greeter_server.js | 7 +++++-- examples/helloworld/static_codegen/greeter_server.js | 7 +++++-- examples/metadata/server.js | 7 +++++-- 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/examples/deadline/server.js b/examples/deadline/server.js index 1618a9d5..d78be852 100644 --- a/examples/deadline/server.js +++ b/examples/deadline/server.js @@ -100,8 +100,11 @@ function main() { }); const server = new grpc.Server(); server.addService(echoProto.Echo.service, serviceImplementation); - server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), () => { - server.start(); + server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), (err, port) => { + if (err != null) { + return console.error(err); + } + console.log(`gRPC listening on ${port}`) }); client = new echoProto.Echo(`localhost:${argv.port}`, grpc.credentials.createInsecure()); } diff --git a/examples/helloworld/dynamic_codegen/greeter_server.js b/examples/helloworld/dynamic_codegen/greeter_server.js index 29924be7..183caf50 100644 --- a/examples/helloworld/dynamic_codegen/greeter_server.js +++ b/examples/helloworld/dynamic_codegen/greeter_server.js @@ -44,8 +44,11 @@ function sayHello(call, callback) { function main() { var server = new grpc.Server(); server.addService(hello_proto.Greeter.service, {sayHello: sayHello}); - server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => { - server; + server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), (err, port) => { + if (err != null) { + return console.error(err); + } + console.log(`gRPC listening on ${port}`) }); } diff --git a/examples/helloworld/static_codegen/greeter_server.js b/examples/helloworld/static_codegen/greeter_server.js index 7a3e87d8..ae2ab949 100644 --- a/examples/helloworld/static_codegen/greeter_server.js +++ b/examples/helloworld/static_codegen/greeter_server.js @@ -37,8 +37,11 @@ function sayHello(call, callback) { function main() { var server = new grpc.Server(); server.addService(services.GreeterService, {sayHello: sayHello}); - server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), () => { - server.start(); + server.bindAsync('0.0.0.0:50051', grpc.ServerCredentials.createInsecure(), (err, port) => { + if (err != null) { + return console.error(err); + } + console.log(`gRPC listening on ${port}`) }); } diff --git a/examples/metadata/server.js b/examples/metadata/server.js index b061d20a..5a28433c 100644 --- a/examples/metadata/server.js +++ b/examples/metadata/server.js @@ -148,8 +148,11 @@ function main() { }); const server = new grpc.Server(); server.addService(echoProto.Echo.service, serviceImplementation); - server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), () => { - server.start(); + server.bindAsync(`0.0.0.0:${argv.port}`, grpc.ServerCredentials.createInsecure(), (err, port) => { + if (err != null) { + return console.error(err); + } + console.log(`gRPC listening on ${port}`) }); } From 76717f88a6b3dfd32b4ab74fefb9e421cd857383 Mon Sep 17 00:00:00 2001 From: Ileriayo Adebiyi Date: Mon, 12 Feb 2024 21:09:43 +0100 Subject: [PATCH 3/3] Fix missing import --- examples/metadata/server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/metadata/server.js b/examples/metadata/server.js index 5a28433c..68fdb182 100644 --- a/examples/metadata/server.js +++ b/examples/metadata/server.js @@ -18,6 +18,7 @@ const grpc = require('@grpc/grpc-js'); const protoLoader = require('@grpc/proto-loader'); +const parseArgs = require('minimist'); const PROTO_PATH = __dirname + '/../protos/echo.proto';