From 9a7be95df9d4d5808b2045127d67ab35d5a58c90 Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Mon, 14 Sep 2015 13:53:07 -0700 Subject: [PATCH 1/3] Fixed Op destructors not being called --- ext/call.cc | 5 ++++- ext/call.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ext/call.cc b/ext/call.cc index 560869e6..49b30620 100644 --- a/ext/call.cc +++ b/ext/call.cc @@ -172,6 +172,9 @@ Handle Op::GetOpType() const { return NanEscapeScope(NanNew(GetTypeString())); } +Op::~Op() { +} + class SendMetadataOp : public Op { public: Handle GetNodeValue() const { @@ -325,7 +328,7 @@ class ReadMessageOp : public Op { } ~ReadMessageOp() { if (recv_message != NULL) { - gpr_free(recv_message); + grpc_byte_buffer_destroy(recv_message); } } Handle GetNodeValue() const { diff --git a/ext/call.h b/ext/call.h index 89f81dcf..a01f0348 100644 --- a/ext/call.h +++ b/ext/call.h @@ -88,6 +88,7 @@ struct Resources { class Op { public: + virtual ~Op(); virtual v8::Handle GetNodeValue() const = 0; virtual bool ParseOp(v8::Handle value, grpc_op *out, shared_ptr resources) = 0; @@ -98,7 +99,6 @@ class Op { }; typedef std::vector> OpVec; - struct tag { tag(NanCallback *callback, OpVec *ops, shared_ptr resources); From fc892feb19463dfe9e3088bd51f8f5fe7387a906 Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Mon, 14 Sep 2015 14:16:04 -0700 Subject: [PATCH 2/3] Fixed memory leak in Buffer construction --- ext/byte_buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/byte_buffer.cc b/ext/byte_buffer.cc index 7eff11c2..fe7735d4 100644 --- a/ext/byte_buffer.cc +++ b/ext/byte_buffer.cc @@ -77,7 +77,7 @@ Handle ByteBufferToBuffer(grpc_byte_buffer *buffer) { memcpy(result + offset, GPR_SLICE_START_PTR(next), GPR_SLICE_LENGTH(next)); offset += GPR_SLICE_LENGTH(next); } - return NanEscapeScope(MakeFastBuffer(NanNewBufferHandle(result, length))); + return NanEscapeScope(MakeFastBuffer(NanBufferUse(result, length))); } Handle MakeFastBuffer(Handle slowBuffer) { From 3e43d49399843ebaee4551d194f1759fae8e18cb Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Tue, 15 Sep 2015 09:23:55 -0700 Subject: [PATCH 3/3] Fixed a couple of incorrect "this" references in Node library --- src/server.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/server.js b/src/server.js index b6f162ad..70b4a9d8 100644 --- a/src/server.js +++ b/src/server.js @@ -276,6 +276,7 @@ function ServerWritableStream(call, serialize) { function _write(chunk, encoding, callback) { /* jshint validthis: true */ var batch = {}; + var self = this; if (!this.call.metadataSent) { batch[grpc.opType.SEND_INITIAL_METADATA] = (new Metadata())._getCoreRepresentation(); @@ -290,7 +291,7 @@ function _write(chunk, encoding, callback) { batch[grpc.opType.SEND_MESSAGE] = message; this.call.startBatch(batch, function(err, value) { if (err) { - this.emit('error', err); + self.emit('error', err); return; } callback(); @@ -305,6 +306,7 @@ ServerWritableStream.prototype._write = _write; */ function sendMetadata(responseMetadata) { /* jshint validthis: true */ + var self = this; if (!this.call.metadataSent) { this.call.metadataSent = true; var batch = []; @@ -312,7 +314,7 @@ function sendMetadata(responseMetadata) { responseMetadata._getCoreRepresentation(); this.call.startBatch(batch, function(err) { if (err) { - this.emit('error', err); + self.emit('error', err); return; } });