From 3cbb46b1f78bef6cd75c715769eaac9baf4cbd70 Mon Sep 17 00:00:00 2001 From: murgatroid99 Date: Thu, 5 Mar 2020 12:32:08 -0800 Subject: [PATCH] Don't explicitly reject any promises --- packages/grpc-js/src/server.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts index 8e6af3d3..fd2af1fc 100644 --- a/packages/grpc-js/src/server.ts +++ b/packages/grpc-js/src/server.ts @@ -249,11 +249,7 @@ export class Server { const bindSpecificPort = (addressList: SubchannelAddress[], portNum: number, previousCount: number): Promise => { if (addressList.length === 0) { - if (previousCount > 0) { - return Promise.resolve({port: portNum, count: previousCount}); - } else { - return Promise.reject(new Error('No addresses bound')); - } + return Promise.resolve({port: portNum, count: previousCount}); } return Promise.all(addressList.map(address => { let addr: SubchannelAddress; @@ -303,7 +299,7 @@ export class Server { const bindWildcardPort = (addressList: SubchannelAddress[]): Promise => { if (addressList.length === 0) { - return Promise.reject(new Error('No addresses bound')); + return Promise.resolve({port: 0, count: 0}); } const address = addressList[0]; const http2Server = setupServer();