From 2c75b640718d69eef02b857a9eb60d02dcd96ad3 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sat, 25 Aug 2018 12:23:08 -0400 Subject: [PATCH] grpc-js-core: remove extra map() calls in fromHttp2Headers() The extra map() calls added an extra loop over the arrays just to trim() a string. This commit moves the trim() into the forEach() and drops the map(). --- packages/grpc-js-core/src/metadata.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/grpc-js-core/src/metadata.ts b/packages/grpc-js-core/src/metadata.ts index 71fe5e09..e53b18a9 100644 --- a/packages/grpc-js-core/src/metadata.ts +++ b/packages/grpc-js-core/src/metadata.ts @@ -205,9 +205,9 @@ export class Metadata { result.add(key, Buffer.from(value, 'base64')); }); } else if (values !== undefined) { - values.split(',') - .map(v => v.trim()) - .forEach(v => result.add(key, Buffer.from(v, 'base64'))); + values.split(',').forEach(v => { + result.add(key, Buffer.from(v.trim(), 'base64')); + }); } } else { if (Array.isArray(values)) { @@ -215,7 +215,7 @@ export class Metadata { result.add(key, value); }); } else if (values !== undefined) { - values.split(',').map(v => v.trim()).forEach(v => result.add(key, v)); + values.split(',').forEach(v => result.add(key, v.trim())); } } });