From 1fc284f59d67b4120dec5f8fc6372f5aa5741eca Mon Sep 17 00:00:00 2001 From: Michael Lumish Date: Wed, 2 Sep 2020 15:17:57 -0700 Subject: [PATCH] Revert "fix(grpc-js): Add support for impl type to server.addService" --- packages/grpc-js/src/server.ts | 10 +++------- packages/grpc-js/test/test-server.ts | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts index 64c17a02..8d8952e8 100644 --- a/packages/grpc-js/src/server.ts +++ b/packages/grpc-js/src/server.ts @@ -144,13 +144,9 @@ export class Server { throw new Error('Not implemented. Use addService() instead'); } - addService< - ImplementationType extends { - [key: string]: any - } - >( - service: ServiceDefinition, - implementation: ImplementationType + addService( + service: ServiceDefinition, + implementation: UntypedServiceImplementation ): void { if (this.started === true) { throw new Error("Can't add a service to a started server."); diff --git a/packages/grpc-js/test/test-server.ts b/packages/grpc-js/test/test-server.ts index b30963fb..434efbbc 100644 --- a/packages/grpc-js/test/test-server.ts +++ b/packages/grpc-js/test/test-server.ts @@ -181,7 +181,7 @@ describe('Server', () => { const server = new Server(); assert.throws(() => { - server.addService(({} as any), dummyImpls); + server.addService({}, dummyImpls); }, /Cannot add an empty service to a server/); });