archive-gh-me/grpc-node
1
0
Fork 0
mirror of https://github.com/grpc/grpc-node.git synced 2025-12-08 18:23:54 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1297 from murgatroid99/grpc-js_dont_test_ipv6_records

Browse Source 
grpc-js: tests: skip checking for IPv6 addresses from DNS servers
This commit is contained in:
Michael Lumish 2020-03-10 13:38:39 -07:00 committed by GitHub
commit 0956c247c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/grpc-js/test/test-resolver.ts
View File

@ -214,7 +214,9 @@ describe('Name Resolver', () => {
const resolver = resolverManager.createResolver(target, listener);
resolver.updateResolution();
});
it('Should resolve a DNS name to an IPv6 address', done => {
/* TODO(murgatroid99): re-enable this test, once we can get the IPv6 result
* consistently */
it.skip('Should resolve a DNS name to an IPv6 address', done => {
const target = 'loopback6.unittest.grpc.io';
const listener: resolverManager.ResolverListener = {
onSuccessfulResolution: (
@ -255,14 +257,8 @@ describe('Name Resolver', () => {
addr.port === 443
)
);
assert(
addressList.some(
addr =>
isTcpSubchannelAddress(addr) &&
addr.host === '::1' &&
addr.port === 443
)
);
/* TODO(murgatroid99): check for IPv6 result, once we can get that
* consistently */
done();
},
onError: (error: StatusObject) => {