Most distributions do not package 1.25 yet and we do not rely on 1.25
features so far. Make sure to propagate the go.mod version and not the
Go version used to build/run in the postrel helper.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Switch to the current recommendation of defining env vars and fix a typo in the goflags_arg variable.
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
This change adds a new job in `//.github/workflows:build.yml` named
`container`, to build the container image. This is being added as a
quick hack to fix a critical issue with this repository (in regards to
its container image), namely, that it is not built except for releases.
This means that both source code and configuration changes that break
the container build will not be caught until an attempt to create a new
release is made (more specifically, given the current configuration of
the `//.github/workflows:container.yml` pipeline, whenever a new ref is
pushed up matching `refs/tags/v*`).
An example of this is a recent change to the required version of `go`,
made in commit 4c2caf3e9b6f1c65857c0d33208e3273c2ab7eb3 (ca. October
2024), which did not udpate the base `golang` image referenced in
`//:Dockerfile`.
As a requirement to pass the new pipeline, this change also updates the
`golang` image we source in `//:Dockerfile`, in order to fix the build.
Signed-off-by: sudoforge <no-reply@sudoforge.com>
This change refactors container image references to use a fully
qualified registry URI (by adding the URI that `docker` implies
automatically, `docker.io/library`). This improves support for
other tools like `podman` or `buildah`.
Signed-off-by: sudoforge <no-reply@sudoforge.com>
* [CLEANUP] Moving options to the correct config section
This adds an easy migration path to our config handling, which should
allow us to migrate option names around much more easily in the future.
Any system level config or env variables options are not migrated.
This also fixes a bug in our test code, where the root mount path was
not properly set in our config, because we used "path:" instead of
"path=" to set it.
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [DOCUMENTATION] Document legacy options and their migration path
This also makes sure that legacy options aren't used in the code anymore using the docs test and its regexp
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [n/a] Removing weird spaces from changelog
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [DOCUMENTATION] Reformatting our Markdown tables properly
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [TESTING] Patching a timezone bug in tests
This is a fun one where if your Timezone isn't UTC and you are past midnight but it's not past midnight UTC, the tests would fail because you're not using the right date to validate it.
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [n/a] Fix a typo and use the correct Env variables in the doc about the custom Env variables
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [BREAKING] Custom Env options moved from GOPASS_CONFIG_CONFIG_KEY_i to GOPASS_CONFIG_KEY_i
As discussed in #2617, this actually reflects the way GIT_CONFIG works.
It also fixes a potential Panic in our codebase when IsSet was called
without any Preset config on a non-existing key.
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [CLEANUP] Patching all of the new linter complaints
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [CLEANUP] Use Go1.21 everywhere
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [n/a] Increase our Golangci timeout
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
* [n/a] code review comment and extra regression test
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
---------
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
