From f71889ac3684f3fdaa79279e9d53efa35ca136b5 Mon Sep 17 00:00:00 2001 From: Martin Booth Date: Wed, 1 Jan 2025 21:48:26 -0800 Subject: [PATCH] Fix issue StrictMode issue where dependencies are incorrectly updated --- packages/gl-react/src/Node.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/gl-react/src/Node.js b/packages/gl-react/src/Node.js index 4970349..416e4c8 100755 --- a/packages/gl-react/src/Node.js +++ b/packages/gl-react/src/Node.js @@ -718,10 +718,10 @@ export default class Node extends Component { newdeps: Array ): [Array, Array] { const olddeps = this.dependencies; - const additions = newdeps.filter((node) => olddeps.indexOf(node) === -1); - const deletions = olddeps.filter((node) => newdeps.indexOf(node) === -1); - additions.forEach((d) => d._addDependent(this)); - deletions.forEach((d) => d._removeDependent(this)); + const additions = newdeps.filter(node => olddeps.indexOf(node) === -1); + const deletions = olddeps.filter(node => newdeps.indexOf(node) === -1); + olddeps.forEach(d => d._removeDependent(this)); + newdeps.forEach(d => d._addDependent(this)); this.dependencies = newdeps; return [additions, deletions]; }