Wouter Verlaek dc68610c0e
[ws-manager-mk2] Ignore container killed failures (#17118)
* [ws-manager-mk2] Ignore container killed failures

* ClusterRole + Binding
2023-03-31 23:31:41 +02:00

340 lines
13 KiB
Go

// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
// Licensed under the GNU Affero General Public License (AGPL).
// See License-AGPL.txt in the project root for license information.
package controllers
import (
"bytes"
"context"
"encoding/json"
"fmt"
wsk8s "github.com/gitpod-io/gitpod/common-go/kubernetes"
config "github.com/gitpod-io/gitpod/ws-manager/api/config"
workspacev1 "github.com/gitpod-io/gitpod/ws-manager/api/crd/v1"
"golang.org/x/xerrors"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/log"
)
const (
// containerKilledExitCode is the exit code Kubernetes uses for a container which was killed by the system.
// We expect such containers to be restarted by Kubernetes if they're supposed to be running.
// We never deliberately terminate a container like this.
containerKilledExitCode = 137
// containerUnknownExitCode is the exit code containerd uses if it cannot determine the cause/exit status of
// a stopped container.
containerUnknownExitCode = 255
)
func (r *WorkspaceReconciler) updateWorkspaceStatus(ctx context.Context, workspace *workspacev1.Workspace, pods corev1.PodList, cfg *config.Configuration) error {
log := log.FromContext(ctx)
switch len(pods.Items) {
case 0:
if workspace.Status.Phase == "" {
workspace.Status.Phase = workspacev1.WorkspacePhasePending
}
if workspace.Status.Phase == workspacev1.WorkspacePhaseStopping && isDisposalFinished(workspace) {
workspace.Status.Phase = workspacev1.WorkspacePhaseStopped
}
return nil
case 1:
// continue below
default:
// This is exceptional - not sure what to do here. Probably fail the pod
workspace.Status.SetCondition(
workspacev1.NewWorkspaceConditionFailed("multiple pods exists - this should never happen"))
return nil
}
if c := wsk8s.GetCondition(workspace.Status.Conditions, string(workspacev1.WorkspaceConditionDeployed)); c == nil {
workspace.Status.SetCondition(workspacev1.NewWorkspaceConditionDeployed())
}
pod := &pods.Items[0]
if workspace.Status.Runtime == nil {
workspace.Status.Runtime = &workspacev1.WorkspaceRuntimeStatus{}
}
if workspace.Status.Runtime.NodeName == "" && pod.Spec.NodeName != "" {
workspace.Status.Runtime.NodeName = pod.Spec.NodeName
}
if workspace.Status.Runtime.HostIP == "" && pod.Status.HostIP != "" {
workspace.Status.Runtime.HostIP = pod.Status.HostIP
}
if workspace.Status.Runtime.PodIP == "" && pod.Status.PodIP != "" {
workspace.Status.Runtime.PodIP = pod.Status.PodIP
}
if workspace.Status.Runtime.PodName == "" && pod.Name != "" {
workspace.Status.Runtime.PodName = pod.Name
}
if workspace.Status.URL == "" {
url, err := config.RenderWorkspaceURL(cfg.WorkspaceURLTemplate, workspace.Name, workspace.Spec.Ownership.WorkspaceID, cfg.GitpodHostURL)
if err != nil {
return xerrors.Errorf("cannot get workspace URL: %w", err)
}
workspace.Status.URL = url
}
if workspace.Status.OwnerToken == "" {
ownerToken, err := getRandomString(32)
if err != nil {
return xerrors.Errorf("cannot create owner token: %w", err)
}
workspace.Status.OwnerToken = ownerToken
}
failure, phase := r.extractFailure(ctx, workspace, pod)
if phase != nil {
workspace.Status.Phase = *phase
}
if failure != "" && !wsk8s.ConditionPresentAndTrue(workspace.Status.Conditions, string(workspacev1.WorkspaceConditionFailed)) {
// workspaces can fail only once - once there is a failed condition set, stick with it
workspace.Status.Conditions = wsk8s.AddUniqueCondition(workspace.Status.Conditions, metav1.Condition{
Type: string(workspacev1.WorkspaceConditionFailed),
Status: metav1.ConditionTrue,
LastTransitionTime: metav1.Now(),
Message: failure,
})
r.Recorder.Event(workspace, corev1.EventTypeWarning, "Failed", failure)
}
switch {
case isPodBeingDeleted(pod):
workspace.Status.Phase = workspacev1.WorkspacePhaseStopping
if controllerutil.ContainsFinalizer(pod, workspacev1.GitpodFinalizerName) {
if isDisposalFinished(workspace) {
workspace.Status.Phase = workspacev1.WorkspacePhaseStopped
}
} else {
// We do this independently of the dispostal status because pods only get their finalizer
// once they're running. If they fail before they reach the running phase we'll never see
// a disposal status, hence would never stop the workspace.
workspace.Status.Phase = workspacev1.WorkspacePhaseStopped
}
case pod.Status.Phase == corev1.PodPending:
var creating bool
// check if any container is still pulling images
for _, cs := range pod.Status.ContainerStatuses {
if cs.State.Waiting != nil {
switch cs.State.Waiting.Reason {
case "ContainerCreating", "ImagePullBackOff", "ErrImagePull":
creating = true
}
if creating {
break
}
}
}
if creating {
workspace.Status.Phase = workspacev1.WorkspacePhaseCreating
} else {
workspace.Status.Phase = workspacev1.WorkspacePhasePending
}
case pod.Status.Phase == corev1.PodRunning:
var ready bool
for _, cs := range pod.Status.ContainerStatuses {
if cs.Ready {
ready = true
break
}
}
if ready {
// workspace is ready - hence content init is done
workspace.Status.Phase = workspacev1.WorkspacePhaseRunning
} else {
// workspace has not become ready yet - it must be initializing then.
workspace.Status.Phase = workspacev1.WorkspacePhaseInitializing
}
case workspace.IsHeadless() && (pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed):
workspace.Status.Phase = workspacev1.WorkspacePhaseStopping
if isDisposalFinished(workspace) {
workspace.Status.Phase = workspacev1.WorkspacePhaseStopped
}
case pod.Status.Phase == corev1.PodUnknown:
workspace.Status.Phase = workspacev1.WorkspacePhaseUnknown
default:
log.Info("cannot determine workspace phase", "podStatus", pod.Status)
workspace.Status.Phase = workspacev1.WorkspacePhaseUnknown
}
return nil
}
func isDisposalFinished(ws *workspacev1.Workspace) bool {
return wsk8s.ConditionPresentAndTrue(ws.Status.Conditions, string(workspacev1.WorkspaceConditionBackupComplete)) ||
wsk8s.ConditionPresentAndTrue(ws.Status.Conditions, string(workspacev1.WorkspaceConditionBackupFailure)) ||
wsk8s.ConditionPresentAndTrue(ws.Status.Conditions, string(workspacev1.WorkspaceConditionAborted)) ||
// Nothing to dispose if content wasn't ready.
!wsk8s.ConditionPresentAndTrue(ws.Status.Conditions, string(workspacev1.WorkspaceConditionContentReady)) ||
// Image builds have nothing to dispose.
ws.Spec.Type == workspacev1.WorkspaceTypeImageBuild
}
// extractFailure returns a pod failure reason and possibly a phase. If phase is nil then
// one should extract the phase themselves. If the pod has not failed, this function returns "", nil.
// This failure is then stored in the Failed condition on the workspace.
func (r *WorkspaceReconciler) extractFailure(ctx context.Context, ws *workspacev1.Workspace, pod *corev1.Pod) (string, *workspacev1.WorkspacePhase) {
// Check for content init failure.
if c := wsk8s.GetCondition(ws.Status.Conditions, string(workspacev1.WorkspaceConditionContentReady)); c != nil {
if c.Status == metav1.ConditionFalse && c.Reason == workspacev1.ReasonInitializationFailure {
return c.Message, nil
}
}
// Check for backup failure.
if c := wsk8s.GetCondition(ws.Status.Conditions, string(workspacev1.WorkspaceConditionBackupFailure)); c != nil {
return c.Message, nil
}
status := pod.Status
if status.Phase == corev1.PodFailed && (status.Reason != "" || status.Message != "") {
// Don't force the phase to UNKNONWN here to leave a chance that we may detect the actual phase of
// the workspace, e.g. stopping.
return fmt.Sprintf("%s: %s", status.Reason, status.Message), nil
}
for _, cs := range status.ContainerStatuses {
if cs.State.Waiting != nil {
if cs.State.Waiting.Reason == "ImagePullBackOff" || cs.State.Waiting.Reason == "ErrImagePull" {
// If the image pull failed we were definitely in the api.WorkspacePhase_CREATING phase,
// unless of course this pod has been deleted already.
var res *workspacev1.WorkspacePhase
if isPodBeingDeleted(pod) {
// The pod is being deleted already and we have to decide the phase based on the presence of the
// finalizer and disposal status annotation. That code already exists in the remainder of getStatus,
// hence we defer the decision.
res = nil
} else {
c := workspacev1.WorkspacePhaseCreating
res = &c
}
return fmt.Sprintf("cannot pull image: %s", cs.State.Waiting.Message), res
}
}
terminationState := cs.State.Terminated
if terminationState == nil {
terminationState = cs.LastTerminationState.Terminated
}
if terminationState != nil {
// a workspace terminated container is not neccesarily bad. During shutdown workspaces containers
// can go in this state and that's ok. However, if the workspace was shutting down due to deletion,
// we would not be here as we've checked for a DeletionTimestamp prior. So let's find out why the
// container is terminating.
if terminationState.ExitCode != 0 && terminationState.Message != "" {
var phase workspacev1.WorkspacePhase
if !isPodBeingDeleted(pod) {
// If the wrote a termination message and is not currently being deleted,
// then it must have been/be running. If we did not force the phase here,
// we'd be in unknown.
phase = workspacev1.WorkspacePhaseRunning
}
if terminationState.ExitCode == containerKilledExitCode && terminationState.Reason == "ContainerStatusUnknown" {
// For some reason, the pod is killed with unknown container status and no taints on the underlying node.
// Therefore, we skip extracting the failure from the terminated message.
// ref: https://github.com/gitpod-io/gitpod/issues/12021
var node corev1.Node
if ws.Status.Runtime != nil && ws.Status.Runtime.NodeName != "" {
if err := r.Get(ctx, types.NamespacedName{Namespace: "", Name: ws.Status.Runtime.NodeName}, &node); err == nil && len(node.Spec.Taints) == 0 {
return "", nil
}
}
}
// the container itself told us why it was terminated - use that as failure reason
return extractFailureFromLogs([]byte(terminationState.Message)), &phase
} else if terminationState.Reason == "Error" {
if !isPodBeingDeleted(pod) && terminationState.ExitCode != containerKilledExitCode {
phase := workspacev1.WorkspacePhaseRunning
return fmt.Sprintf("container %s ran with an error: exit code %d", cs.Name, terminationState.ExitCode), &phase
}
} else if terminationState.Reason == "Completed" && !isPodBeingDeleted(pod) {
if ws.IsHeadless() {
// headless workspaces are expected to finish
return "", nil
}
return fmt.Sprintf("container %s completed; containers of a workspace pod are not supposed to do that", cs.Name), nil
} else if !isPodBeingDeleted(pod) && terminationState.ExitCode != containerUnknownExitCode {
// if a container is terminated and it wasn't because of either:
// - regular shutdown
// - the exit code "UNKNOWN" (which might be caused by an intermittent issue and is handled in extractStatusFromPod)
// - another known error
// then we report it as UNKNOWN
phase := workspacev1.WorkspacePhaseUnknown
return fmt.Sprintf("workspace container %s terminated for an unknown reason: (%s) %s", cs.Name, terminationState.Reason, terminationState.Message), &phase
}
}
}
return "", nil
}
// extractFailureFromLogs attempts to extract the last error message from a workspace
// container's log output.
func extractFailureFromLogs(logs []byte) string {
var sep = []byte("\n")
var msg struct {
Error string `json:"error"`
Message string `json:"message"`
}
var nidx int
for idx := bytes.LastIndex(logs, sep); idx > 0; idx = nidx {
nidx = bytes.LastIndex(logs[:idx], sep)
if nidx < 0 {
nidx = 0
}
line := logs[nidx:idx]
err := json.Unmarshal(line, &msg)
if err != nil {
continue
}
if msg.Message == "" {
continue
}
if msg.Error == "" {
return msg.Message
}
return msg.Message + ": " + msg.Error
}
return string(logs)
}
// isPodBeingDeleted returns true if the pod is currently being deleted
func isPodBeingDeleted(pod *corev1.Pod) bool {
// if the pod is being deleted the only marker we have is that the deletionTimestamp is set
return pod.ObjectMeta.DeletionTimestamp != nil
}
// isWorkspaceBeingDeleted returns true if the workspace resource is currently being deleted.
func isWorkspaceBeingDeleted(ws *workspacev1.Workspace) bool {
return ws.ObjectMeta.DeletionTimestamp != nil
}