mirror of
https://github.com/gitpod-io/gitpod.git
synced 2025-12-08 17:36:30 +00:00
0ba64e3d3e
* [public-api] refine mapping of json rpc error codes - map 4xx and 650 codes as invalid argument (client errors) - map 401, 411 related to unauthedicated and permission denied - mapp 429 to resource exhausted * Update errors.go
105 lines
2.9 KiB
Go
105 lines
2.9 KiB
Go
// Copyright (c) 2022 Gitpod GmbH. All rights reserved.
|
|
// Licensed under the GNU Affero General Public License (AGPL).
|
|
// See License.AGPL.txt in the project root for license information.
|
|
|
|
package proxy
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/bufbuild/connect-go"
|
|
protocol "github.com/gitpod-io/gitpod/gitpod-protocol"
|
|
"github.com/sourcegraph/jsonrpc2"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestConvertError(t *testing.T) {
|
|
scenarios := []struct {
|
|
Input error
|
|
ExpectedError error
|
|
}{
|
|
{
|
|
Input: &protocol.ErrBadHandshake{
|
|
URL: "https://foo.bar",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("Failed to establish caller identity")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 400,
|
|
Message: "user id is a required argument",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("user id is a required argument")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 401,
|
|
Message: "user is not authenticated",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("user is not authenticated")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 409,
|
|
Message: "already exists",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeAlreadyExists, fmt.Errorf("already exists")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 429,
|
|
Message: "too many requests",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeResourceExhausted, fmt.Errorf("too many requests")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 470,
|
|
Message: "user blocked",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodePermissionDenied, fmt.Errorf("user blocked")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 499,
|
|
Message: "catch all client error",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("catch all client error")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: 599,
|
|
Message: "catch all server error",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeInternal, fmt.Errorf("catch all server error")),
|
|
},
|
|
{
|
|
Input: &jsonrpc2.Error{
|
|
Code: -32603,
|
|
Message: "Request getWorkspace failed with message: No workspace with id 'some-id' found.",
|
|
},
|
|
ExpectedError: connect.NewError(connect.CodeInternal, fmt.Errorf("Request getWorkspace failed with message: No workspace with id 'some-id' found.")),
|
|
},
|
|
{
|
|
Input: nil,
|
|
ExpectedError: nil,
|
|
},
|
|
{
|
|
Input: errors.New("some other random error returns internal error"),
|
|
ExpectedError: connect.NewError(connect.CodeInternal, fmt.Errorf("some other random error returns internal error")),
|
|
},
|
|
{
|
|
Input: context.Canceled,
|
|
ExpectedError: connect.NewError(connect.CodeDeadlineExceeded, fmt.Errorf("Request timed out")),
|
|
},
|
|
}
|
|
|
|
for _, s := range scenarios {
|
|
converted := ConvertError(s.Input)
|
|
require.Equal(t, s.ExpectedError, converted)
|
|
}
|
|
}
|