63 Commits

Author SHA1 Message Date
JenTing Hsiao
8bd4df75e7 ws-manager: skip failure from terminated message
For some reason, the pod is killed with unknown container status and no taints on the underlying node.
Therefore, we skip extracting the failure from the terminated message.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2023-01-13 06:06:52 +01:00
JenTing Hsiao
9f33031a6d ws-manager: add log to help troubleshoot
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2023-01-10 08:22:49 +01:00
JenTing Hsiao
bb96008cb6 Fix the metric workspace_starts_failure_total and workspace_stops_total
Increase the metric workspace_starts_failure_total when the workspace stops and
the pod's annotation "gitpod/never-ready" exist. It means the workspace pod never
went into the running state, probably because
- the workspace pod can't allocate to the workspace node
- content initialization failure
- the workspace pod is never ready

Increase the metric workspace_stop_total when the workspace stops and
the pod's annotation "gitpod/never-ready" does not exist. So, the metric
workspace_stop_total does not increase on the start failure.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2023-01-04 23:47:44 +01:00
utam0k
24a7d195db ws-manager: Update and add golden files 2022-12-28 23:23:37 +01:00
utam0k
a7fe67dd17 ws-manager: Prevent to slip the CREATING phase 2022-12-28 23:23:37 +01:00
Christian Weichel
478a75e744 Switch license to AGPL 2022-12-08 13:05:19 -03:00
JenTing Hsiao
d686ea9685 Add counter metrics to record error count
Add two metrics to record the `mount device failed` and `cannt mount volume`
error. So, we could know the frequency the error happened.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2022-11-03 10:57:07 +01:00
JenTing Hsiao
0a130f1cda Skip the cannot mount workspace event because it might be an intermediate state
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2022-11-03 10:57:07 +01:00
utam0k
8200bfb7c1 ws-manager: Add the workspace statys for PodInitialzing phase. 2022-10-25 17:04:40 +02:00
Pudong Zheng
a83040893e [ws-manager] refactory image layers 2022-10-13 20:08:30 +02:00
JenTing Hsiao
801de49c1f Skip "MountVolume.MountDevice failed for volume"
Ignore the FailedMount event with the message contains MountVolume.MountDevice failed for volume.

The ws-manager catches the FailedMount event and writes the error message into the workspace Conditions.Failed.
Then, the workspace pod is stopped, and the workspace failed message will be shown to the user.

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2022-10-12 02:44:27 +02:00
Anton Kosyakov
008ea3fadc [jb] prepare to split backend and plugin images 2022-08-30 09:36:14 +02:00
Pavel Tumik @ GitPod
23f3e4257a [ws-manager] simplify workspaceDisposalStatus and FinalBackupComplete condition 2022-08-26 01:54:10 +02:00
Pavel Tumik
07d80c8fa8 add support for aborting workspaces 2022-08-23 20:20:40 +02:00
Pavel Tumik
27763e8d6f [ws-manager] fix not handling workspaces that are completed 2022-08-01 17:24:46 -03:00
JenTing Hsiao
35c6bd1a86 ws-manager: go through stopping phase even if the workspace is not ready
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
2022-07-29 23:45:24 -03:00
Pavel Tumik
3f92a73ea8 [ws-manager] add metrics for unintentional workspace stop 2022-07-27 16:14:22 -03:00
Pavel Tumik
f4f86bb547 [ws-manager] fix incorrect handling of failure state for workspaces 2022-07-27 16:14:22 -03:00
Pudong
ef139861d1 Revert "[ws-manager] do not overwrite failed state"
This reverts commit 96c136f2d266ebe23deca3236221de1e9ad06a36.
2022-07-18 06:21:13 +02:00
Pavel Tumik
96c136f2d2 [ws-manager] do not overwrite failed state 2022-07-15 21:36:02 +02:00
Pavel Tumik
8553668174 [ws-manager] change log from debug to error 2022-06-11 03:47:20 +05:30
Pavel Tumik
35f0b08a5a Update components/ws-manager/pkg/manager/status.go
Co-authored-by: Christian Weichel <chris@gitpod.io>
2022-06-02 22:52:51 +05:30
Pavel Tumik
eeedfcdce6 [ws-manager] show why pod entered completed state 2022-06-02 22:52:51 +05:30
utam0k
6419e31102 Make the pods be removed when workspacekit fails. 2022-05-25 13:56:39 +05:30
Pavel Tumik
99204170c5 ensure volume snapshot naming consistency 2022-05-25 13:17:39 +05:30
Pavel Tumik
88768f6e50 snapshot volume support 2022-05-25 13:17:39 +05:30
Christian Weichel
0150cf8cce [ws-manager] Introduce workspace classes 2022-04-29 14:24:15 +05:30
Pavel Tumik
0c66eb259d [ws-manager] fix workspace status flipping pending to deleted 2022-04-21 20:44:34 +05:30
Prince Rachit Sinha
4d48ccb997 Add maximum lifetime constraint for a workspace 2022-02-22 16:25:02 +05:30
Pudong Zheng
85cda2bd1e [ws-manager] fix incorrect status when image pull is open 2022-02-21 14:11:00 +05:30
Pavel Tumik
1870c1251a remove contact support message 2022-02-11 22:21:32 +01:00
Cornelius A. Ludmann
6509092ad4 [ws-manager] Add supervisor ref to IDEImage 2021-11-11 08:34:08 +01:00
Manuel Alejandro de Brito Fontes
037eb40107 Refactor ws-manager to stop using services 2021-11-05 10:33:03 +01:00
Cornelius A. Ludmann
e7c93eb382 [ws-manager] Add destkop_ide_image 2021-10-26 15:02:04 +02:00
Christian Weichel
20adf1dbe6 [ws-manager] Introduce stoppedByRequest condition 2021-10-14 18:12:01 -03:00
Christian Weichel
c9d4e37444 [ws-manager] Provide ordering of status updates 2021-09-29 07:37:46 -03:00
Christian Weichel
da28f48f11 [ws-manager] Recognise terminated pods as running 2021-08-27 06:38:25 -03:00
Christian Weichel
18b08d8a42 [ws-manager] Properly stop workspaces with failed img pull 2021-08-27 06:38:25 -03:00
Christian Weichel
b4a99407b0 [ws-manager] Stop workspaces that never ran 2021-08-27 06:38:25 -03:00
Christian Weichel
a32b5c088f [ws-manager] Don't nil-deref on timeout computation 2021-07-29 17:37:33 +02:00
Christian Weichel
479abb7869 [ws-manager] Don't add failed condition when headless task fails 2021-07-29 10:12:32 +02:00
Christian Weichel
1c7b10e228 [ws-manager] Stop workspaces timing out during backup 2021-07-26 16:14:30 +02:00
Christian Weichel
3bb79b04da [ws-manager] Properly stop all headless workspaces
not just prebuilds
2021-07-22 16:32:26 +02:00
Christian Weichel
133cdcfa0c [image-builder] Backport mk3 from gitpod-com 2021-07-22 16:32:26 +02:00
Gero Posmyk-Leinemann
8f0c24af66 [ws-manager, supervisor, bridge] Prebuild workspaces are done when their container stops 2021-07-08 09:27:34 +02:00
Christian Weichel
eb0f0c37d8 [ws-manager] Backport #4405 to use nodeName 2021-06-25 15:50:48 +02:00
Christian Weichel
715ef34b22
[ws-manager] Backup on pod eviction (#4405)
* [ws-manager] Backup on pod eviction

* Fixed changelog

* Update components/ws-manager/pkg/manager/monitor.go

Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
Co-authored-by: Jan Koehnlein <jan@gitpod.io>
Co-authored-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
2021-06-08 11:19:01 +02:00
Manuel Alejandro de Brito Fontes
cb2dd80d1c [ws-manager] Remove deprecated annotation 2021-05-25 12:25:01 -04:00
Jan Keromnes
7f8e5571df [server][ws-manager] Allow setting customTimeoutAnnotation for headless workspace pods 2021-05-21 09:23:35 +02:00
Jan Keromnes
c997daf0a1 [ws-manager] When a workspace times out, log the expected timeout instead of the actual time spent 2021-05-21 09:23:35 +02:00