From 3f9c37c06a4fff97053ef1010644bb82ff213423 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 13:15:56 -0400 Subject: [PATCH 1/7] Testing theory of multiple scripts for testing --- .travis.yml | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5ddef355..86a9da55 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,7 +22,6 @@ jobs: - &test stage: test - node_js: 8 before_script: ## Spin up container - cd test/docker/ @@ -33,16 +32,10 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') - script: npm run test - - - <<: *test - node_js: lts/* - - - <<: *test - node_js: 9 - - - <<: *test - node_js: node + script: nvm install 8 && npm run test + script: nvm install lts && npm run test + script: nvm install 9 && npm run test + script: nvm install node && npm run test - stage: release node_js: node From 707868ccfd44c5c6d41df942af26d3a7a24e4fa6 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 13:23:53 -0400 Subject: [PATCH 2/7] Set a default node version --- .travis.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 86a9da55..6c9df419 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,6 +22,7 @@ jobs: - &test stage: test + node_js: node before_script: ## Spin up container - cd test/docker/ @@ -32,10 +33,10 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') - script: nvm install 8 && npm run test - script: nvm install lts && npm run test - script: nvm install 9 && npm run test - script: nvm install node && npm run test + script: nvm install 8 && npm ci && npm run build && npm run test + script: nvm install lts && npm ci && npm run build && npm run test + script: nvm install 9 && npm ci && npm run build && npm run test + script: nvm install node && npm ci && npm run build && npm run test - stage: release node_js: node From a63e9fae8f1b32a64a6e7489d0eded0f071174a3 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 13:35:16 -0400 Subject: [PATCH 3/7] Array of scrips!! not multiple script tags --- .travis.yml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6c9df419..18b522d9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -17,8 +17,9 @@ jobs: include: - stage: lint and build node_js: node - script: npm run lint - script: npm run build + script: + - npm run lint + - npm run build - &test stage: test @@ -33,10 +34,11 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') - script: nvm install 8 && npm ci && npm run build && npm run test - script: nvm install lts && npm ci && npm run build && npm run test - script: nvm install 9 && npm ci && npm run build && npm run test - script: nvm install node && npm ci && npm run build && npm run test + script: + - nvm install 8 && npm ci && npm run build && npm run test + - nvm install lts && npm ci && npm run build && npm run test + - nvm install 9 && npm ci && npm run build && npm run test + - nvm install node && npm ci && npm run build && npm run test - stage: release node_js: node From d0adfea477aff1c2a30bfe43577df19c91b06479 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 13:45:18 -0400 Subject: [PATCH 4/7] npm ci doesnt exist for npm < 10 --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 18b522d9..06e2abed 100644 --- a/.travis.yml +++ b/.travis.yml @@ -35,9 +35,9 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') script: - - nvm install 8 && npm ci && npm run build && npm run test - - nvm install lts && npm ci && npm run build && npm run test - - nvm install 9 && npm ci && npm run build && npm run test + - nvm install 8 && npm install && npm run build && npm run test + - nvm install lts && npm install && npm run build && npm run test + - nvm install 9 && npm install && npm run build && npm run test - nvm install node && npm ci && npm run build && npm run test - stage: release From 432c1722983dd42c98a8906a28e139dbce13d8a3 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 13:57:54 -0400 Subject: [PATCH 5/7] Wrong lts argument --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 06e2abed..367b47b7 100644 --- a/.travis.yml +++ b/.travis.yml @@ -36,7 +36,7 @@ jobs: - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') script: - nvm install 8 && npm install && npm run build && npm run test - - nvm install lts && npm install && npm run build && npm run test + - nvm install --lts && npm install && npm run build && npm run test - nvm install 9 && npm install && npm run build && npm run test - nvm install node && npm ci && npm run build && npm run test From 204a01246b62bd1519e8b8efb7d9d6db31bf0409 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 14:02:36 -0400 Subject: [PATCH 6/7] Perform coverage only at the end --- .travis.yml | 9 +++++---- package.json | 2 ++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 367b47b7..e1b64d38 100644 --- a/.travis.yml +++ b/.travis.yml @@ -35,10 +35,11 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') script: - - nvm install 8 && npm install && npm run build && npm run test - - nvm install --lts && npm install && npm run build && npm run test - - nvm install 9 && npm install && npm run build && npm run test - - nvm install node && npm ci && npm run build && npm run test + - nvm install 8 && npm install && npm run build && npm run test:nocoverage + - nvm install --lts && npm install && npm run build && npm run test:nocoverage + - nvm install 9 && npm install && npm run build && npm run test:nocoverage + - nvm install node && npm ci && npm run build && npm run test:nocoverage + - npm run codecov - stage: release node_js: node diff --git a/package.json b/package.json index 7eb3821f..41d17979 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,9 @@ "test:bundles": "jest test/tests/bundles", "test:infrastructure": "jest test/tests/infrastructure", "test:services": "jest test/tests/services", + "test:nocoverage": "jest", "test": "jest && codecov", + "codecov": "codecov", "prepublishOnly": "npm run build", "semantic-release": "semantic-release -t '${version}'" }, From 67ea7edc2310e96056666e9e95d7c106726e7f03 Mon Sep 17 00:00:00 2001 From: Justin Date: Wed, 27 Jun 2018 14:15:33 -0400 Subject: [PATCH 7/7] Tests are run against the src, not the compiled versions, thus running 4 version of the scripts on different node versions doesnt make sense --- .travis.yml | 8 ++------ package.json | 2 -- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index e1b64d38..ca81d951 100644 --- a/.travis.yml +++ b/.travis.yml @@ -35,12 +35,8 @@ jobs: - export PERSONAL_ACCESS_TOKEN=$(docker exec -it gitlab bash -lc 'printf "%q" "${PERSONAL_ACCESS_TOKEN}"') - export GITLAB_URL=$(docker exec -it gitlab bash -lc 'printf "%q" "${GITLAB_URL}"') script: - - nvm install 8 && npm install && npm run build && npm run test:nocoverage - - nvm install --lts && npm install && npm run build && npm run test:nocoverage - - nvm install 9 && npm install && npm run build && npm run test:nocoverage - - nvm install node && npm ci && npm run build && npm run test:nocoverage - - npm run codecov - + - nvm install node && npm ci && npm run build && npm run test + - stage: release node_js: node script: diff --git a/package.json b/package.json index 41d17979..7eb3821f 100644 --- a/package.json +++ b/package.json @@ -15,9 +15,7 @@ "test:bundles": "jest test/tests/bundles", "test:infrastructure": "jest test/tests/infrastructure", "test:services": "jest test/tests/services", - "test:nocoverage": "jest", "test": "jest && codecov", - "codecov": "codecov", "prepublishOnly": "npm run build", "semantic-release": "semantic-release -t '${version}'" },