From 31592e65be93d19076525870eb1254c102b62240 Mon Sep 17 00:00:00 2001 From: Zack Urben Date: Thu, 3 Oct 2019 10:55:07 -0500 Subject: [PATCH 1/3] Fixing lint issue --- src/core/services/Labels.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/services/Labels.ts b/src/core/services/Labels.ts index b03f0aa0..67bacbe1 100644 --- a/src/core/services/Labels.ts +++ b/src/core/services/Labels.ts @@ -17,8 +17,7 @@ class Labels extends BaseService { if (projectId) { url = `projects/${encodeURIComponent(projectId)}/labels`; - } - else if (groupId) { + } else if (groupId) { url = `groups/${encodeURIComponent(groupId)}/labels`; } From 904862604bc38381dc27fb46572a00ff576336ca Mon Sep 17 00:00:00 2001 From: Zack Urben Date: Thu, 3 Oct 2019 11:03:27 -0500 Subject: [PATCH 2/3] Fixing formatting issues --- src/core/services/Labels.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/core/services/Labels.ts b/src/core/services/Labels.ts index 67bacbe1..ccf9f58e 100644 --- a/src/core/services/Labels.ts +++ b/src/core/services/Labels.ts @@ -14,7 +14,6 @@ class Labels extends BaseService { ...options }: ({ projectId: ProjectId } | { groupId: GroupId } | {}) & PaginatedRequestOptions) { let url; - if (projectId) { url = `projects/${encodeURIComponent(projectId)}/labels`; } else if (groupId) { From 0514f4389477fb6434c721a083e53f3a7f2d8bf4 Mon Sep 17 00:00:00 2001 From: Zack Urben Date: Thu, 3 Oct 2019 11:32:09 -0500 Subject: [PATCH 3/3] Fixing lint issues with prettier --- src/core/services/Labels.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/core/services/Labels.ts b/src/core/services/Labels.ts index ccf9f58e..366dc922 100644 --- a/src/core/services/Labels.ts +++ b/src/core/services/Labels.ts @@ -36,13 +36,19 @@ class Labels extends BaseService { edit(projectId: ProjectId, labelName: string, options?: BaseRequestOptions) { const pId = encodeURIComponent(projectId); - return RequestHelper.put(this, `projects/${pId}/labels`, { name: labelName, ...options }); + return RequestHelper.put(this, `projects/${pId}/labels`, { + name: labelName, + ...options, + }); } remove(projectId: ProjectId, labelName: string, options?: Sudo) { const pId = encodeURIComponent(projectId); - return RequestHelper.del(this, `projects/${pId}/labels`, { name: labelName, ...options }); + return RequestHelper.del(this, `projects/${pId}/labels`, { + name: labelName, + ...options, + }); } subscribe(projectId: ProjectId, labelId: LabelId, options?: Sudo) {