archive-gh-me/gitbeaker
1
0
Fork 0
mirror of https://github.com/jdalrymple/gitbeaker.git synced 2026-01-25 16:04:01 +00:00
Code Issues Projects Releases Wiki Activity

fix: Fixing Todos support. If todoId was not passed, an undefined value would be introduced into the url

Browse Source
This commit is contained in:
Justin Dalrymple 2018-10-15 12:45:26 -04:00
parent 0156724eb9
commit cbeef188d0
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/services/Todos.ts
View File

@ -1,23 +1,20 @@
import { BaseService, RequestHelper } from '../infrastructure'; import { BaseService, RequestHelper } from '../infrastructure';
interface TodosOptions {
todoId?: string;
}
class Todos extends BaseService { class Todos extends BaseService {
all(options) { all(options) {
return RequestHelper.get(this, 'todos', options); return RequestHelper.get(this, 'todos', options);
} }
create(projectId, mergerequestId) { create(projectId: number, mergerequestId: number) {
const [pId, mId] = [projectId, mergerequestId].map(encodeURIComponent); return RequestHelper.post(this, `projects/${projectId}/merge_requests/${mergerequestId}/todo`);
return RequestHelper.post(this, `projects/${pId}/merge_requests/${mId}/todo`);
} }
done({ todoId }: TodosOptions = {}) { done({ todoId }: { todoId?: number } = {}) {
const tId = encodeURIComponent(todoId); let url = 'mark_as_done';
return RequestHelper.delete(this, `todos/${tId}/mark_as_done`); if (todoId) url = `${todoId}/${url}`
return RequestHelper.delete(this, `todos/${url}`);
} }
} }