Fixing pagination for allDiffs and allCommits methods (#3388)

This commit is contained in:
Justin Dalrymple 2023-08-21 09:15:04 -04:00 committed by GitHub
parent 6f109f7cc0
commit a91c686771
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -296,11 +296,11 @@ export class MergeRequests<C extends boolean = false> extends BaseResource<C> {
return RequestHelper.get<MergeRequestSchema[]>()(this, `${prefix}merge_requests`, options);
}
allDiffs<E extends boolean = false>(
allDiffs<E extends boolean = false, P extends PaginationTypes = 'offset'>(
projectId: string | number,
mergerequestIId: number,
options?: Sudo & ShowExpanded<E>,
): Promise<GitlabAPIResponse<MergeRequestDiffSchema[], C, E, void>> {
): Promise<GitlabAPIResponse<MergeRequestDiffSchema[], C, E, P>> {
return RequestHelper.get<MergeRequestDiffSchema[]>()(
this,
endpoint`projects/${projectId}/merge_requests/${mergerequestIId}/diffs`,
@ -308,11 +308,11 @@ export class MergeRequests<C extends boolean = false> extends BaseResource<C> {
);
}
allCommits<E extends boolean = false>(
allCommits<E extends boolean = false, P extends PaginationTypes = 'offset'>(
projectId: string | number,
mergerequestIId: number,
options?: Sudo & ShowExpanded<E>,
): Promise<GitlabAPIResponse<CommitSchema[], C, E, void>> {
): Promise<GitlabAPIResponse<CommitSchema[], C, E, P>> {
return RequestHelper.get<CommitSchema[]>()(
this,
endpoint`projects/${projectId}/merge_requests/${mergerequestIId}/commits`,