From aa2738bb3e6eb65414f40e45507242d438068993 Mon Sep 17 00:00:00 2001 From: Norm MacLennan Date: Thu, 5 Jul 2018 09:54:51 -0400 Subject: [PATCH] Fix methods for editing MR approval/approver settings The code was previously trying to do GETs to the routes, which was giving me 404s. Updated to correctly change the `/approvals` router to POST and the `/approvers` router to PUT as in the GitLab API documentation: https://docs.gitlab.com/ee/api/merge_request_approvals.html --- src/services/MergeRequests.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services/MergeRequests.js b/src/services/MergeRequests.js index f48a8e0c..c5a95eb9 100644 --- a/src/services/MergeRequests.js +++ b/src/services/MergeRequests.js @@ -88,14 +88,14 @@ class MergeRequests extends BaseService { const pId = encodeURIComponent(projectId); const mergeRequest = mergerequestId ? `merge_requests/${encodeURIComponent(mergerequestId)}` : ''; - return RequestHelper.get(this, `projects/${pId}/${mergeRequest}approvals`, options); + return RequestHelper.post(this, `projects/${pId}/${mergeRequest}approvals`, options); } editApprovers(projectId, { mergerequestId, ...options }) { const pId = encodeURIComponent(projectId); const mergeRequest = mergerequestId ? `merge_requests/${encodeURIComponent(mergerequestId)}` : ''; - return RequestHelper.get(this, `projects/${pId}/${mergeRequest}approvers`, options); + return RequestHelper.put(this, `projects/${pId}/${mergeRequest}approvers`, options); } remove(projectId, mergerequestId) {