From f8e3d3c6eb5018b1abba6257d7a02fa8cbd94ec4 Mon Sep 17 00:00:00 2001 From: Simon Bailey Date: Thu, 15 May 2014 20:49:21 +0100 Subject: [PATCH] Removed manual wrapping of JSX code to bypass jshint errors and advised usage of JSXHint. Signed-off-by: Simon Bailey --- README.md | 6 ++++-- templates/common/root/.jshintrc | 2 +- templates/common/root/test/.jshintrc | 2 +- templates/javascript/App.jsx | 2 -- templates/javascript/Component.jsx | 4 +--- 5 files changed, 7 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index e2e46a0..b3fe8f5 100644 --- a/README.md +++ b/README.md @@ -65,7 +65,6 @@ Produces `src/scripts/components/Foo.jsx` (*javascript - JSX*): var React = require('react/addons'); var Foo = React.createClass({ - /*jshint ignore:start */ render: function () { return (
@@ -73,7 +72,6 @@ var Foo = React.createClass({
) } - /*jshint ignore:end */ }); module.exports = Foo; @@ -164,6 +162,10 @@ Out the box the [Gruntfile](http://gruntjs.com/api/grunt.file) is configured wit Included in the project is [Eric Meyer's reset.css](http://meyerweb.com/eric/tools/css/reset/) script. There is also a `src/styles/main.css` script that's required by the core `src/scripts/components/App.js` component using Webpack. +### JSHint + +Please use [JSXHint](https://github.com/STRML/JSXHint) for linting JSX and the corresponding Sublime package if using SLT3 [SublimeLinter-jsxhint](https://github.com/SublimeLinter/SublimeLinter-jsxhint). Note this is a global npm install and JSX files will need to be associated with the JSX file type withing SLT3. + ## Props Thanks to all who contributed to [generator-angular](https://github.com/yeoman/generator-angular) as the majority of code here has been shamelessy sourced from that repos. diff --git a/templates/common/root/.jshintrc b/templates/common/root/.jshintrc index b5f6ae1..2f22258 100644 --- a/templates/common/root/.jshintrc +++ b/templates/common/root/.jshintrc @@ -11,7 +11,7 @@ "latedef": true, "newcap": true, "noarg": true, - "quotmark": "single", + "quotmark": "false", "regexp": true, "undef": true, "unused": false, diff --git a/templates/common/root/test/.jshintrc b/templates/common/root/test/.jshintrc index 6d4b5b7..baa5704 100644 --- a/templates/common/root/test/.jshintrc +++ b/templates/common/root/test/.jshintrc @@ -11,7 +11,7 @@ "latedef": true, "newcap": true, "noarg": true, - "quotmark": "single", + "quotmark": "false", "regexp": true, "undef": true, "unused": false, diff --git a/templates/javascript/App.jsx b/templates/javascript/App.jsx index 1566ba9..83f17f7 100644 --- a/templates/javascript/App.jsx +++ b/templates/javascript/App.jsx @@ -14,7 +14,6 @@ require('../../styles/main.css'); var imageURL = '../../images/yeoman.png'; var <%= scriptAppName %> = React.createClass({ - /*jshint ignore:start */ render: function() { return (
@@ -24,7 +23,6 @@ var <%= scriptAppName %> = React.createClass({
); } - /*jshint ignore:end */ }); React.renderComponent(<<%= scriptAppName %> />, document.getElementById('content')); // jshint ignore:line diff --git a/templates/javascript/Component.jsx b/templates/javascript/Component.jsx index 2418a4b..7ce6a48 100644 --- a/templates/javascript/Component.jsx +++ b/templates/javascript/Component.jsx @@ -8,15 +8,13 @@ var React = require('react/addons'); require('../../styles/<%= classedName %>.css'); var <%= classedName %> = React.createClass({ - /*jshint ignore:start */ render: function () { return (

Content for <%= classedName %>

- ) + ); } - /*jshint ignore:end */ }); module.exports = <%= classedName %>;