feat: siteFile support custom control-cache (#4902)

Co-authored-by: yangbing <yangbing@immotors.com>

app/middleware/site_file.js

@@ -1,7 +1,6 @@
 'use strict';
 
 const path = require('path');
-const MAX_AGE = 'public, max-age=2592000'; // 30 days
 
 module.exports = options => {
   return function siteFile(ctx, next) {
@@ -19,7 +18,7 @@ module.exports = options => {
     // '/robots.txt': Buffer <xx..
     // content is buffer
     if (Buffer.isBuffer(content)) {
-      ctx.set('cache-control', MAX_AGE);
+      ctx.set('cache-control', options.cacheControl);
       ctx.body = content;
       ctx.type = path.extname(ctx.path);
       return;

config/config.default.js

@@ -190,6 +190,7 @@ module.exports = appInfo => {
    * You can map some files using this options, it will response immdiately when matching.
    *
    * @member {Object} Config#siteFile - key is path, and value is url or buffer.
+   * @property {String} cacheControl - files cache , default is public, max-age=2592000
    * @example
    * // specific app's favicon, => '/favicon.ico': 'https://eggjs.org/favicon.ico',
    * config.siteFile = {
@@ -198,6 +199,8 @@ module.exports = appInfo => {
    */
   config.siteFile = {
     '/favicon.ico': fs.readFileSync(path.join(__dirname, 'favicon.png')),
+    // default cache in 30 days
+    cacheControl: 'public, max-age=2592000',
   };
 
   /**

test/app/middleware/site_file.test.js

@@ -91,4 +91,20 @@ describe('test/app/middleware/site_file.test.js', () => {
         });
     });
   });
+
+  describe('siteFile.cacheControl = no-store', () => {
+    let app;
+    before(() => {
+      app = utils.app('apps/sitefile-custom-cachecontrol');
+      return app.ready();
+    });
+    after(() => app.close());
+
+    it('should get custom cache-control', async () => {
+      await app.httpRequest()
+        .get('/favicon.ico')
+        .expect(res => assert(res.headers['cache-control'].includes('no-store')))
+        .expect(200);
+    });
+  });
 });

test/fixtures/apps/siteFile-custom-cacheControl/app/router.js

@@ -0,0 +1,5 @@
+module.exports = app => {
+  app.get('/', function*() {
+    this.body = 'Hi, this is home';
+  });
+};

test/fixtures/apps/siteFile-custom-cacheControl/config/config.default.js

@@ -0,0 +1,5 @@
+exports.siteFile = {
+  cacheControl: 'no-store',
+};
+
+exports.keys = 'foo';

test/fixtures/apps/siteFile-custom-cacheControl/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "sitefile-custom-cachecontrol"
+}