463 Commits

Author SHA1 Message Date
Nguyễn Bá Hưng
aeb0a8779d Add TypeScript types for SortAnimation and update correct CDN link in README 2020-07-10 15:13:59 +07:00
Nguyễn Bá Hưng
2931209fff Add exclude field to Draggable options to allow disable default plugins and sensors
Remove duplicated code

Refactor to more readable

Change 'toBe' to 'toEqual' for compare value only
2020-07-08 11:24:43 +07:00
Max Hoffmann
e6fa782788
Merge pull request #390 from zjffun/fix-resize-mirror
fix(resize mirror plugin) : dont appends mirror when mirror was removed
2020-07-06 09:38:43 -04:00
JuFeng Zhang
eda2cca340 dont appends mirror when mirror was removed 2020-07-05 14:43:06 +08:00
Max Hoffmann
ad819543b8
Merge pull request #375 from randym/fix/rm_delay_distance
fix(delay_distance): fix drag start concurrency
2020-06-29 13:23:49 -04:00
Randy Morgan
d3e5e23507 fix(delay_distance): cleanup and evaluate pre-drag conditions without flags for TouchSensor 2020-06-29 16:50:24 +09:00
Randy Morgan
492d22db30 refactor(touchCoods): extract repeated touches/chagnedTouches lookup 2020-06-29 16:50:24 +09:00
Randy Morgan
f02a70bdbf fix(delay_distance): cleanup and evaluate pre-drag conditions without flags
Fail fast - do not add mouseup and mousemove listeners if there is no container
Store time and location of event for later evaluation of delay and distance
Prefer single code path to startDrag avoiding flags and secondary constraint evaluation

Add tests for all three configruations - only delay, only distance, both distance and delay
2020-06-29 16:50:24 +09:00
Randy Morgan
4ab09de80a fix(delay_distance): remove delayOver flag 2020-06-29 16:50:24 +09:00
Randy Morgan
02f28e4c9c chore(async_testing): Draggable should waitForDragDelay 2020-06-29 16:50:24 +09:00
Randy Morgan
e46ee07fe1 chore(matchers): enhance toHaveTriggeredSensorEvent with count
This ensures that we can verify that drag:start only happens once when there are both delay and distance conditions configured
2020-06-29 16:50:24 +09:00
Randy Morgan
052744eb51 chore(test_helpers): enable DRAG_DELAY for tests and complete event defaults
- configure DRAG_DELAY for tests to the library default of 100ms in order totest delayed dragging.
- Ensure Date.now is updated on waitForDragDelay so that time comparisons can be used to test for drag delay constraints
2020-06-29 16:50:24 +09:00
Randy Morgan
2367e2f8c9 chore(prettier): ensure prettier config matches eslint 2020-06-29 16:50:24 +09:00
Max Hoffmann
c533811a92
Merge pull request #395 from bahung1221/master
v1.0.0-beta.10 and update CHANGELOG
v1.0.0-beta.10
2020-06-18 12:46:59 -04:00
Nguyễn Bá Hưng
7174193baf v1.0.0-beta.10 and update CHANGELOG 2020-06-18 23:20:11 +07:00
Max Hoffmann
933fbf0ee3
Merge pull request #394 from bahung1221/master
Add SortAnimation plugin and example
2020-06-18 12:03:07 -04:00
bahung1221
d3dce507d9 Add SortAnimation plugin and example 2020-06-18 22:59:08 +07:00
Max Hoffmann
3226fe58f6
Merge pull request #388 from davidbielik/patch-2
Added `distance?: number` to DraggableOptions interface
2020-06-18 11:23:20 -04:00
davidbielik
e06957a6da Added distance?: number to DraggableOptions interface 2020-06-18 09:11:06 +08:00
Max Hoffmann
50ecde5496
Merge pull request #228 from dsandstrom/fix-mirror
Fix mirror dimensions when constrainDimensions is active and not using fixed item width
2020-06-10 13:02:05 -04:00
Darrell Sandstrom
9b82373542 Fix mirror dimensions
when constrainDimensions is active and not using fixed item width

When clicking an item, the mirror is added to the container.
Calculations are then made to figure out what size the mirror should be.
However, since the mirror is already in the container, the container now
has an extra item, thus reducing the width of all of the container's items.
Hence, the width calculated is too small and doesn't reflect the true
source size.

Instead, let's initially hide the mirror, figure out the intended width,
then show the mirror.
2020-06-09 08:31:48 +08:00
owen-m1
f8c4e1c8b5
Merge pull request #377 from Shopify/update-readme
Update maintainers in readme
2020-01-26 13:08:38 -05:00
Josh
92452289a4
Update maintainers in readme 2019-12-18 23:57:55 +13:00
Md. Abdul Munim Dibosh
60fb9cc886
Merge pull request #364 from dibosh/v1.0.0-beta.9-changelog
Add changelog for v1.0.0-beta.9
2019-08-30 15:34:46 +08:00
dibosh
7ee6e50557 Add changelog for v1.0.0-beta.9 2019-08-30 15:27:30 +08:00
Max Hoffmann
97dc19f10f
v1.0.0-beta.9 v1.0.0-beta.9 2019-08-26 11:33:56 -04:00
Yassir Mounsif
d394dd8369 Edit DroppableStopEvent type 2019-07-12 17:29:41 -04:00
owen-m1
5672beb525
Merge pull request #264 from fdietze/fix-sortablesortevent
Fix SortableSortEvent.{over,overContainer}
2019-07-11 12:08:46 -04:00
Felix Dietze
b3dba80b79 Fix SortableSortEvent.{over,overContainer} 2019-07-05 09:46:52 -04:00
owen-m1
58d79dc9fb
Add distance option 2019-06-09 12:45:49 -04:00
owen-m1
4b881a13f5
Merge pull request #344 from Jason-Cooke/patch-1
docs: fix typo
2019-06-03 19:47:54 -04:00
Jason Cooke
b2bade32f5
docs: fix typo 2019-06-04 11:05:45 +12:00
Owen Mills
2019ae1ce6
Add mirror threshold options 2019-05-11 10:51:18 -04:00
Tyler Kempt
ecc04b2cdb
Merge pull request #330 from Shopify/goodbye
Update README for collaborators
2019-04-03 17:50:56 -04:00
beefchimi
84b8a5f54c update readme for collaborators 2019-04-03 13:58:14 -04:00
Curtis Dulmage
88f785394c
Merge pull request #315 from richardkmichael/droppable-documentation
Improve Droppable documentation and example
2019-01-14 12:55:40 -05:00
Richard Michael
582b4f4199 Improve the Droppable documentation and example. 2019-01-14 12:20:08 -05:00
Curtis Dulmage
9f5e23c210
Merge pull request #311 from josh18/master
Add TypeScript type definitions
2018-12-31 12:02:16 -05:00
Josh Hunt
bd03d7f29d Add TypeScript type definitions 2018-12-21 16:21:06 +13:00
Curtis Dulmage
a277e16280
Merge pull request #310 from Shopify/fix-threads-url
Fix ssh url for threads
2018-12-14 09:33:38 -05:00
beefchimi
5d193e7824 fix ssh url for threads 2018-12-14 09:32:35 -05:00
Curtis Dulmage
7529bc5ed6
Merge pull request #291 from Shopify/enable-clabot
Enable CLA Bot (again)
2018-10-17 20:32:15 -04:00
Ben Scott
9b8517f38e Enable CLA Bot (again)
Yes this is a revert of a revert. Please don't judge me.
2018-10-17 17:22:20 -07:00
Curtis Dulmage
a9979453ee
Merge pull request #289 from Shopify/revert-286-cla
Revert "Enable CLA bot"
2018-10-17 09:23:10 -04:00
Tim Layton
17666602a3
Revert "Enable CLA bot" 2018-10-16 17:56:04 -07:00
Ben Scott
41c9ad2d73
Merge pull request #286 from Shopify/cla
Enable CLA bot
2018-10-11 17:20:32 -07:00
Tim Layton
a4e7b3d737
enable cla bot 2018-10-11 15:30:48 -07:00
Curtis Dulmage
fb58904966
Merge pull request #281 from Shopify/mirror-event-readme
Fix MirrorEvent link in main readme
2018-09-25 09:20:17 -04:00
beefchimi
52f42116f6 fix mirror event link in main readme 2018-09-25 09:19:02 -04:00
Max Hoffmann
c518fb184c
v1.0.0-beta.8 v1.0.0-beta.8 2018-09-07 11:14:39 -04:00