archive-gh-me/draggable
1
0
Fork 0
mirror of https://github.com/Shopify/draggable.git synced 2026-01-18 15:54:06 +00:00
Code Issues Projects Releases Wiki Activity

Sortable now appends into container on drag over container event

Browse Source
This commit is contained in:
Max Hoffmann 2017-11-07 12:49:23 -05:00
parent 089cff6686
commit b2c529e997
No known key found for this signature in database
GPG Key ID: 1DFA4D13DD27A676
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Sortable/Sortable.js
View File

@ -235,15 +235,15 @@ function index(element) {
function move({source, over, overContainer, children}) {
const emptyOverContainer = !children.length;
const differentContainer = over && (source.parentNode !== over.parentNode);
const sameContainer = over && (source.parentNode === over.parentNode);
const differentContainer = (source.parentNode !== overContainer);
const sameContainer = over && !differentContainer;
if (emptyOverContainer) {
return moveInsideEmptyContainer(source, overContainer);
} else if (sameContainer) {
return moveWithinContainer(source, over);
} else if (differentContainer) {
return moveOutsideContainer(source, over);
return moveOutsideContainer(source, over, overContainer);
} else {
return null;
}
@ -270,10 +270,15 @@ function moveWithinContainer(source, over) {
return {oldContainer: source.parentNode, newContainer: source.parentNode};
}
function moveOutsideContainer(source, over) {
function moveOutsideContainer(source, over, overContainer) {
const oldContainer = source.parentNode;
over.parentNode.insertBefore(source, over);
if (over) {
over.parentNode.insertBefore(source, over);
} else {
// need to figure out proper position
overContainer.appendChild(source);
}
return {oldContainer, newContainer: source.parentNode};
}