mirror of
https://github.com/sameersbn/docker-gitlab.git
synced 2026-01-25 14:08:09 +00:00
e910e3024c
As a result, an Internet connection is no longer required to use relative URLs. To enable relative url, we execute `gitlab:assets:compile`. This have been removed in official documentation in v10.0.0 (first committed to gitlab-foss, then ported to gitlab(-ee)) - EE: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/1139/ - CE: https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/8831 An internet connection was required when enabling relative urls to install the node modules required for compilation. I reviewed the rake task `gitlab:assets:compile` and investigated whether it was necessary to compile all assets just because the relative url changed, and found that this rake task is internally a separate rake task `gitlab:assets :fix_urls` which rewrite the reference URL in the css. I removed rake task `gitlab:assets:compile` at runtime and confirmed that the gitlab application worked normally as before. I have confirmed that at least the following functions work properly. - Administrator password reset at first login - Create empty project - Edit/add and commit files using web IDE - Create merge request/issue - Attach files to comments - Create empty group - Move existing project to group In addition, we no longer need to do following things - persist node_modules, recompiled assets and caches - apply patches to gitlab itself to avoid removing (symlink to) node_modules/ This change also reduces startup time in certain cases when the relative URL feature is enabled (when assets are compiled; for example, when performing a version upgrade or changing the relative URL) (on my environment, `gitlab:assets:fix_urls` took about 20 seconds)