mirror of
https://github.com/sameersbn/docker-gitlab.git
synced 2026-01-18 13:58:25 +00:00
da0d78bf5b
note: Only affected if using the relative_url feature `gitlab/script/frontent/preinstall.mjs` is introduced since v16.4.0. This script is executed on container startup, if using the relative url. This script removes `NODE_MODULES` (/home/git/gitlab/node_modules) when "the folder seems to end up being a corrupted somehow" See more detail: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/130938 On sameersbn/gitlab, the folder node_modules is declared as volume. The volume is always busy so that cannot be removed in the container. You can see following error reported on container startup (sameersbn/gitlab:16.4.0 or later). ```` yarn install v1.22.19 $ node ./scripts/frontend/preinstall.mjs [WARNING] package.json changed significantly. Removing node_modules to be sure there are no problems. node:internal/process/esm_loader:97 internalBinding('errors').triggerUncaughtException( ^ [Error: EBUSY: resource busy or locked, rmdir '/home/git/gitlab/node_modules'] { errno: -16, code: 'EBUSY', syscall: 'rmdir', path: '/home/git/gitlab/node_modules' } Node.js v18.17.1 error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. ----- ```` This PR add a build time patch to change the behavior of script/frontend/preinstall.mjs to not to remove node_modules directly, but empty it instead.