From b321150da5fc94530d080c7bf2ee02047e306f3b Mon Sep 17 00:00:00 2001
From: Joerg Stoever <joerg.stoever@gmail.com>
Date: Fri, 20 Sep 2024 12:03:42 +0900
Subject: [PATCH] health check: remove curl's --location option

When the healthcheck feature introduced, the script were generated on build time
and url was fixed to "http://localhost/-/liveness".
See pull request #2102

nginx is configured to redirect all http traffic to https when `GITLAB_HTTPS` is enabled.
(see https://github.com/sameersbn/docker-gitlab/blob/ac9e1fe/assets/runtime/config/nginx/gitlab-ssl#L41-L54),
`--location` option is set to follow the redirection.
See pull request #2165

Health check script generation has been ported to the runtime,
allowing us to dynamically generate health check URLs
while referencing configuration parameters.
See #2338

If configured correctly, the redirect will not occur and the option can be removed.

Original removal suggestion by @Gaibhne , additional (historical) research by @kkimurak.
Co-authored-by: Kazunori Kimura <kkimura@ims.ac.jp>
---
 assets/runtime/functions | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assets/runtime/functions b/assets/runtime/functions
index 2a9cfe0b..4f7908bb 100644
--- a/assets/runtime/functions
+++ b/assets/runtime/functions
@@ -1861,7 +1861,7 @@ generate_healthcheck_script() {
 cat > /usr/local/sbin/healthcheck <<EOF
 #!/bin/bash
 url=${HEALTHCHECK_PROTOCOL}://localhost${GITLAB_RELATIVE_URL_ROOT}/-/liveness
-options=( '--insecure' '--location' '--silent' )
+options=( '--insecure' '--silent' )
 curl "\${options[@]}" \$url
 [[ "\$(curl \${options[@]} -o /dev/null -I -w '%{http_code}' \$url)" == "200" ]]
 EOF