archive-gh-me/debug
1
0
Fork 0
mirror of https://github.com/debug-js/debug.git synced 2026-01-25 16:42:28 +00:00
Code Issues Projects Releases Wiki Activity

Don't set DEBUG if namespaces is undefined.

Browse Source 
On Node.js, if you set a process.env field to either null or undefined,
it gets cast to string 'null' or 'undefined'.

For debug, this means that if you don't have DEBUG set, it will get set
to the string 'undefined'. There are other modules (like
node-rest-client) which use the DEBUG environment variable that will
start spewing debug output when you don't want it to.
This commit is contained in:
David M. Lee 2014-06-06 14:49:26 -05:00
parent a4de5389c0
commit 3aa365ae93
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
browser.js
View File

@ -103,7 +103,11 @@ function log() {
function save(namespaces) {
try {
localStorage.debug = namespaces;
if (null == namespaces) {
delete localStorage.debug;
} else {
localStorage.debug = namespaces;
}
} catch(e) {}
}

8
node.js
View File

@ -84,7 +84,13 @@ function log() {
*/
function save(namespaces) {
process.env.DEBUG = namespaces;
if (null == namespaces) {
// If you set a process.env field to null or undefined, it gets cast to the
// string 'null' or 'undefined'. Just delete instead.
delete process.env.DEBUG;
} else {
process.env.DEBUG = namespaces;
}
}
/**