From e4ca954f33b0201580b6a6bc67cec4e2c09b70b2 Mon Sep 17 00:00:00 2001 From: MikeBeaton Date: Thu, 4 Mar 2021 11:57:10 +0000 Subject: [PATCH] OcLog.c: Correct SerialPortWrite return value handling --- Library/OcDebugLogLib/OcLog.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/Library/OcDebugLogLib/OcLog.c b/Library/OcDebugLogLib/OcLog.c index 9224e7f8..f13c30df 100755 --- a/Library/OcDebugLogLib/OcLog.c +++ b/Library/OcDebugLogLib/OcLog.c @@ -208,13 +208,10 @@ OcLogAddEntry ( // Write to serial port. // if ((OcLog->Options & OC_LOG_SERIAL) != 0) { - Status = SerialPortWrite ((UINT8 *) Private->TimingTxt, TimingLength); - if (Status == EFI_NO_MAPPING) { - // - // Disable serial port option. - // - OcLog->Options &= ~OC_LOG_SERIAL; - } + // + // No return value check - SerialPortWrite either stalls or falsely return all bytes written if no serial available. + // + SerialPortWrite ((UINT8 *) Private->TimingTxt, TimingLength); SerialPortWrite ((UINT8 *) Private->LineBuffer, LineLength); }