From cb5f497a04f960f5b176f37edd87b43d40965a9d Mon Sep 17 00:00:00 2001
From: PMheart <17109513+PMheart@users.noreply.github.com>
Date: Wed, 3 Feb 2021 08:12:59 +0800
Subject: [PATCH] ocvalidate: Simply return non-zero on errors

---
 Utilities/ocvalidate/ocvalidate.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/Utilities/ocvalidate/ocvalidate.c b/Utilities/ocvalidate/ocvalidate.c
index 74505480..dae1b614 100644
--- a/Utilities/ocvalidate/ocvalidate.c
+++ b/Utilities/ocvalidate/ocvalidate.c
@@ -114,6 +114,10 @@ int ENTRY_POINT(int argc, const char *argv[]) {
   //
   DEBUG ((DEBUG_ERROR, "\n"));
   ErrorCount = CheckConfig (&Config);
+
+  OcConfigurationFree (&Config);
+  FreePool (ConfigFileBuffer);
+
   if (ErrorCount == 0) {
     DEBUG ((
       DEBUG_ERROR,
@@ -130,12 +134,11 @@ int ENTRY_POINT(int argc, const char *argv[]) {
       ErrorCount,
       ErrorCount > 1 ? "errors" : "error"
       ));
+
+    return EXIT_FAILURE;
   }
 
-  OcConfigurationFree (&Config);
-  FreePool (ConfigFileBuffer);
-
-  return ErrorCount;
+  return 0;
 }
 
 INT32 LLVMFuzzerTestOneInput(CONST UINT8 *Data, UINTN Size) {