From b743c4635f3aa526ce41d4e053660dc9d57dd493 Mon Sep 17 00:00:00 2001 From: PMheart <17109513+PMheart@users.noreply.github.com> Date: Wed, 13 Jan 2021 16:59:12 +0800 Subject: [PATCH] ocvalidate: Drop RebaseRegions check --- Utilities/ocvalidate/README.md | 1 - Utilities/ocvalidate/ValidateAcpi.c | 14 -------------- 2 files changed, 15 deletions(-) diff --git a/Utilities/ocvalidate/README.md b/Utilities/ocvalidate/README.md index f590d8bf..521e46df 100644 --- a/Utilities/ocvalidate/README.md +++ b/Utilities/ocvalidate/README.md @@ -27,7 +27,6 @@ Utility to validate whether a `config.plist` matches requirements and convention ### ACPI #### Add - Entry[N]->Path: Only `.aml` and `.bin` filename suffix are accepted. -- Entry[N]->Path: If a customised DSDT is added and enabled, `RebaseRegions` in `ACPI->Quirks` should be enabled. ### Booter #### MmioWhitelist diff --git a/Utilities/ocvalidate/ValidateAcpi.c b/Utilities/ocvalidate/ValidateAcpi.c index 2a3467fc..554f467f 100644 --- a/Utilities/ocvalidate/ValidateAcpi.c +++ b/Utilities/ocvalidate/ValidateAcpi.c @@ -59,11 +59,9 @@ CheckACPIAdd ( OC_ACPI_CONFIG *UserAcpi; CONST CHAR8 *Path; CONST CHAR8 *Comment; - BOOLEAN HasCustomDSDT; ErrorCount = 0; UserAcpi = &Config->Acpi; - HasCustomDSDT = FALSE; for (Index = 0; Index < UserAcpi->Add.Count; ++Index) { Path = OC_BLOB_GET (&UserAcpi->Add.Values[Index]->Path); @@ -86,10 +84,6 @@ CheckACPIAdd ( DEBUG ((DEBUG_WARN, "ACPI->Add[%u]->Path has filename suffix other than .aml and .bin!\n", Index)); ++ErrorCount; } - - if (OcAsciiStriStr (Path, "DSDT") != NULL && UserAcpi->Add.Values[Index]->Enabled) { - HasCustomDSDT = TRUE; - } } // @@ -102,14 +96,6 @@ CheckACPIAdd ( ACPIAddHasDuplication ); - // - // Check for RebaseRegions when using customised DSDT. - // - if (HasCustomDSDT && !UserAcpi->Quirks.RebaseRegions) { - DEBUG ((DEBUG_WARN, "ACPI->Quirks->RebaseRegions is not enabled when customised DSDT table is in use!\n")); - ++ErrorCount; - } - return ErrorCount; }