archive-gh-me/OpenCorePkg
1
0
Fork 0
mirror of https://github.com/acidanthera/OpenCorePkg.git synced 2025-12-08 19:25:01 +00:00
Code Issues Projects Releases Wiki Activity

OcAppleKernelLib: Clarify Vtable TODO

Browse Source
This commit is contained in:
vit9696 2019-07-06 18:56:13 +03:00
parent ac698454a1
commit 951a668bc4
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/OcAppleKernelLib/PrelinkedKext.c
View File

@ -814,10 +814,12 @@ InternalLinkPrelinkedKext (
Kext->StringTable = NULL;
Kext->NumberOfSymbols = 0;
//
// FIXME: VTable and entry names are not updated after relocating StringTable
// Decide whether to keep re-constructing VTables, recalculate
// addresses after linking has finished or store the name's offset and
// access via a StringTable pointer.
// TODO: VTable and entry names are not updated after relocating StringTable,
// which means that to avoid linkage issues for plugins we must either continue
// re-constructing VTables (as done below) or implement some optimisations.
// For example, we could recalculate addresses after linking has finished.
// We could also store the name's offset and access via a StringTable pointer,
// yet it was prone to errors and was already removed once.
//
if (Kext->LinkedVtables != NULL) {
FreePool (Kext->LinkedVtables);