archive-gh-me/OpenCorePkg
1
0
Fork 0
mirror of https://github.com/acidanthera/OpenCorePkg.git synced 2026-02-01 15:59:39 +00:00
Code Issues Projects Releases Wiki Activity

OcCryptoLib: Sha2

Browse Source 
Add note regarding int overflow and mem limit
This commit is contained in:
yourmother 2019-09-04 20:28:43 +03:00
parent 0b16565c18
commit 887aed4928
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Include/Library/OcCryptoLib.h
View File

@ -282,7 +282,7 @@ Sha512 (
VOID
Sha384Init (
SHA384_CONTEXT *Context
SHA384_CONTEXT *Context
);
VOID

8
Library/OcCryptoLib/Sha2.c
View File

@ -493,7 +493,7 @@ Sha512 (
//
VOID
Sha384Init (
SHA384_CONTEXT *Context
SHA384_CONTEXT *Context
)
{
INTN Index;
@ -556,6 +556,12 @@ Sha384Final (
BlockNb = ((SHA384_BLOCK_SIZE - 17) < (Context->Length % SHA384_BLOCK_SIZE)) + 1;
//
// @TODO: Using 32 bit integer for data len doesn't work for a big memory blocks.
// Also there are possible integer overflow
// Context->TotalLength + Context->Length
// Same thing for 512-bit implementation above
//
LenB = (Context->TotalLength + Context->Length) << 3;
PmLen = BlockNb << 7;