archive-gh-me/OpenCorePkg
1
0
Fork 0
mirror of https://github.com/acidanthera/OpenCorePkg.git synced 2025-12-08 19:25:01 +00:00
Code Issues Projects Releases Wiki Activity

OcAppleImageVerificationLib: Fix potential memory corruption

Browse Source 
The reallocated pointer is not returned and thus lost locally (leak). Because ReallocatePool frees the old buffer on success, the caller pointers are unsafe after calling this function (potential corruption). Because the rest of the buffer is zero'd right before, there should be no security concern keeping the current buffer.
This commit is contained in:
Download-Fritz 2019-11-13 09:39:09 +01:00
parent 3e9ef5ac41
commit 2ceee875bf
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/OcAppleImageVerificationLib/OcAppleImageVerification.c
View File

@ -548,14 +548,6 @@ SanitizeApplePeImage (
(UINT8 *) Image + *RealImageSize,
ImageSize - *RealImageSize
);
//
// Reallocate file buffer
//
Image = ReallocatePool (
ImageSize,
*RealImageSize,
Image
);
}
}