archive-gh-me/OpenCorePkg
1
0
Fork 0
mirror of https://github.com/acidanthera/OpenCorePkg.git synced 2025-12-08 19:25:01 +00:00
Code Issues Projects Releases Wiki Activity

OcMachoLib: Remove unsafe VTable API.

Browse Source
This commit is contained in:
Download-Fritz 2019-03-25 20:25:27 +01:00
parent 6dddd23a9b
commit 01c867ad8e
2 changed files with 1 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Include/Library/OcMachoLib.h
View File

@ -581,19 +581,6 @@ MachoSymbolNameIsCxx (
IN CONST CHAR8 *Name
);
/**
Returns the number of VTable entires in VtableData.
@param[in,out] Context Context of the Mach-O.
@param[in] VtableData The VTable's data.
**/
UINT32
MachoVtableGetNumberOfEntries64 (
IN OUT OC_MACHO_CONTEXT *Context,
IN CONST UINT64 *VtableData
);
/**
Retrieves Metaclass symbol of a SMCP.

43
Library/OcMachoLib/CxxSymbols.c
View File

@ -284,10 +284,7 @@ MachoGetClassNameFromMetaClassPointer (
ASSERT (Context->StringTable != NULL);
Result = MachoSymbolNameIsMetaclassPointer64 (Context, MetaClassName);
if (!Result) {
return FALSE;
}
ASSERT (MachoSymbolNameIsMetaclassPointer64 (Context, MetaClassName));
PrefixSize = L_STR_LEN (OSOBJ_PREFIX);
SuffixSize = L_STR_LEN (METACLASS_TOKEN);
@ -507,44 +504,6 @@ MachoSymbolNameIsCxx (
return AsciiStrnCmp (Name, CXX_PREFIX, L_STR_LEN (CXX_PREFIX)) == 0;
}
/**
Returns the number of VTable entires in VtableData.
@param[in,out] Context Context of the Mach-O.
@param[in] VtableData The VTable's data.
**/
UINT32
MachoVtableGetNumberOfEntries64 (
IN OUT OC_MACHO_CONTEXT *Context,
IN CONST UINT64 *VtableData
)
{
UINT32 Index;
UINT32 NumberOfEntries;
UINT64 *LastEntry;
ASSERT (Context != NULL);
ASSERT (VtableData != NULL);
ASSERT (&VtableData[0] > (UINT64 *) Context->MachHeader);
LastEntry = (UINT64 *) ((UINTN) Context->MachHeader + Context->FileSize) - 1;
ASSERT (&VtableData[VTABLE_HEADER_LEN_64] <= LastEntry);
NumberOfEntries = 0;
//
// Assumption: Not ARM. Currently verified by the Context initialization.
//
Index = VTABLE_HEADER_LEN_64;
while (&VtableData[Index] <= LastEntry && VtableData[Index] != 0) {
++NumberOfEntries;
++Index;
}
return NumberOfEntries;
}
/**
Retrieves Metaclass symbol of a SMCP.