archive-gh-me/Leaflet
1
0
Fork 0
mirror of https://github.com/Leaflet/Leaflet.git synced 2025-12-08 21:26:14 +00:00
Code Issues Projects Releases Wiki Activity

Do not propagate click when element has been removed from dom (#9052)

Browse Source
This commit is contained in:
Yohan Boniface 2023-08-01 12:07:31 +02:00 committed by GitHub
parent 847fbb4d62
commit b2048d2d8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
spec/suites/layer/PopupSpec.js
View File

@ -308,6 +308,21 @@ describe('Popup', () => {
expect(map.hasLayer(layer._popup)).to.be.true;
});
it('can change popup content with a click on removed DOM', () => {
const popup = new Popup()
.setLatLng(center)
.setContent('<p onclick="this.parentNode.innerHTML = \'changed\'">initial</p>')
.openOn(map);
UIEventSimulator.fire('click', popup._container.querySelector('p'));
expect(popup._container.innerHTML).to.not.contain('initial');
expect(popup._container.innerHTML).to.contain('changed');
expect(map.hasLayer(popup)).to.be.true;
});
describe('autoPan option should pan popup into visibility', () => {
// Helper function which calculates the offset of the map-container & popup-container in pixel
function getPopupOffset(map, popup) {

2
src/map/Map.js
View File

@ -1389,7 +1389,7 @@ export const Map = Evented.extend({
_isClickDisabled(el) {
while (el && el !== this._container) {
if (el['_leaflet_disable_click']) { return true; }
if (el['_leaflet_disable_click'] || !el.parentNode) { return true; }
el = el.parentNode;
}
},