From ec7c42294880f856492f291e5dee6121480bbd02 Mon Sep 17 00:00:00 2001 From: Eliezer Graber Date: Mon, 3 Jul 2017 19:50:52 -0400 Subject: [PATCH] Address codacy issues --- .../handler/BetterLinkMovementExtended.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/com/fastaccess/provider/timeline/handler/BetterLinkMovementExtended.java b/app/src/main/java/com/fastaccess/provider/timeline/handler/BetterLinkMovementExtended.java index 65bde2d9..f6064368 100644 --- a/app/src/main/java/com/fastaccess/provider/timeline/handler/BetterLinkMovementExtended.java +++ b/app/src/main/java/com/fastaccess/provider/timeline/handler/BetterLinkMovementExtended.java @@ -44,7 +44,7 @@ public class BetterLinkMovementExtended extends LinkMovementMethod { } private final class LinkClickGestureListener extends GestureDetector.SimpleOnGestureListener { - GestureDetector.SimpleOnGestureListener listener = null; + private GestureDetector.SimpleOnGestureListener listener = null; @Override public boolean onDown(MotionEvent e) { if(listener != null) listener.onDown(e); @@ -150,13 +150,11 @@ public class BetterLinkMovementExtended extends LinkMovementMethod { boolean ret = gestureDetector.onTouchEvent(event); - if(!ret) { - if(event.getAction() == MotionEvent.ACTION_UP) { - clickGestureListener.listener = null; - removeUrlHighlightColor(view); - this.touchStartedOverLink = false; - ret = true; - } + if(!ret && event.getAction() == MotionEvent.ACTION_UP) { + clickGestureListener.listener = null; + removeUrlHighlightColor(view); + this.touchStartedOverLink = false; + ret = true; } return ret;