From e2004df297afd9360b4bf78f47a5a32fa4f61e59 Mon Sep 17 00:00:00 2001 From: Kosh Date: Sun, 26 Mar 2017 15:38:53 +0800 Subject: [PATCH] possible solution to progress not being hidden when we introduced custom error messages. --- .../NotificationSchedulerJobTask.java | 2 +- .../fastaccess/ui/modules/feeds/FeedsView.java | 14 ++++++++++++-- .../fastaccess/ui/modules/gists/GistsView.java | 13 +++++++++++-- .../gists/gist/comments/GistCommentsView.java | 11 ++++++++++- .../ui/modules/main/issues/MyIssuesView.java | 11 ++++++++++- .../main/pullrequests/MyPullRequestView.java | 11 ++++++++++- .../modules/notification/NotificationsView.java | 13 +++++++++++-- .../profile/followers/ProfileFollowersView.java | 13 +++++++++++-- .../profile/following/ProfileFollowingView.java | 13 +++++++++++-- .../modules/profile/gists/ProfileGistsView.java | 13 +++++++++++-- .../profile/overview/ProfileOverviewView.java | 13 +++++++++++-- .../modules/profile/repos/ProfileReposView.java | 13 +++++++++++-- .../profile/starred/ProfileStarredView.java | 17 ++++++++++++----- .../repos/code/commit/RepoCommitsView.java | 15 ++++++++++++--- .../details/comments/CommitCommentsView.java | 11 ++++++++++- .../code/contributors/RepoContributorsView.java | 13 +++++++++++-- .../modules/repos/code/files/RepoFilesView.java | 13 +++++++++++-- .../code/files/paths/RepoFilePathView.java | 13 +++++++++++-- .../repos/code/prettifier/ViewerView.java | 5 +++++ .../repos/code/releases/RepoReleasesView.java | 13 +++++++++++-- .../repos/extras/milestone/MilestoneView.java | 13 +++++++++++-- .../issues/issue/RepoClosedIssuesView.java | 11 ++++++++++- .../issues/issue/RepoOpenedIssuesView.java | 11 ++++++++++- .../details/comments/IssueCommentsView.java | 11 ++++++++++- .../issue/details/events/IssueDetailsView.java | 13 +++++++++++-- .../pull_request/RepoPullRequestView.java | 11 ++++++++++- .../details/commits/PullRequestCommitsView.java | 13 +++++++++++-- .../details/events/PullRequestDetailsView.java | 11 ++++++++++- .../ui/modules/search/code/SearchCodeView.java | 11 ++++++++++- .../modules/search/issues/SearchIssuesView.java | 11 ++++++++++- .../modules/search/repos/SearchReposView.java | 11 ++++++++++- .../modules/search/users/SearchUsersView.java | 11 ++++++++++- 32 files changed, 326 insertions(+), 52 deletions(-) diff --git a/app/src/main/java/com/fastaccess/provider/tasks/notification/NotificationSchedulerJobTask.java b/app/src/main/java/com/fastaccess/provider/tasks/notification/NotificationSchedulerJobTask.java index 3ef74fd4..8a15966e 100644 --- a/app/src/main/java/com/fastaccess/provider/tasks/notification/NotificationSchedulerJobTask.java +++ b/app/src/main/java/com/fastaccess/provider/tasks/notification/NotificationSchedulerJobTask.java @@ -107,7 +107,7 @@ public class NotificationSchedulerJobTask extends JobService { Bitmap largeIcon = BitmapFactory.decodeResource(context.getResources(), R.mipmap.ic_launcher); int primaryColor = ViewHelper.getPrimaryColor(context); - android.app.Notification grouped = getNotification(getString(R.string.notifications), getString(R.string.no_unread_notifications)) + android.app.Notification grouped = getNotification(getString(R.string.notifications), getString(R.string.unread_notification)) .setLargeIcon(largeIcon) .setGroup(NOTIFICATION_GROUP_ID) .setGroupSummary(true) diff --git a/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsView.java b/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsView.java index 003c89a2..33481389 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/feeds/FeedsView.java @@ -84,9 +84,19 @@ public class FeedsView extends BaseFragment imple stateLayout.hideProgress(); } - @Override public void showErrorMessage(@NonNull String msgRes) { + @Override public void showErrorMessage(@NonNull String message) { + showReload(); + super.showErrorMessage(message); + } + + @Override public void showMessage(int titleRes, int msgRes) { + showReload(); + super.showMessage(titleRes, msgRes); + } + + private void showReload() { + hideProgress(); stateLayout.showReload(adapter.getItemCount()); - super.showErrorMessage(msgRes); } @Override public void onOpenRepoChooser(@NonNull ArrayList models) { diff --git a/app/src/main/java/com/fastaccess/ui/modules/gists/GistsView.java b/app/src/main/java/com/fastaccess/ui/modules/gists/GistsView.java index b0257f05..2a3c064d 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/gists/GistsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/gists/GistsView.java @@ -74,10 +74,19 @@ public class GistsView extends BaseFragment imple stateLayout.hideProgress(); } - @Override public void showErrorMessage(@NonNull String msgRes) { + @Override public void showErrorMessage(@NonNull String message) { + showReload(); + super.showErrorMessage(message); + } + + @Override public void showMessage(int titleRes, int msgRes) { + showReload(); + super.showMessage(titleRes, msgRes); + } + + private void showReload() { hideProgress(); stateLayout.showReload(adapter.getItemCount()); - super.showErrorMessage(msgRes); } @NonNull @Override public GistsPresenter providePresenter() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsView.java b/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsView.java index 98a6d12b..aa822460 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/gists/gist/comments/GistCommentsView.java @@ -91,9 +91,18 @@ public class GistCommentsView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/main/pullrequests/MyPullRequestView.java b/app/src/main/java/com/fastaccess/ui/modules/main/pullrequests/MyPullRequestView.java index fb63b09f..ed052c11 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/main/pullrequests/MyPullRequestView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/main/pullrequests/MyPullRequestView.java @@ -78,9 +78,18 @@ public class MyPullRequestView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/notification/NotificationsView.java b/app/src/main/java/com/fastaccess/ui/modules/notification/NotificationsView.java index 888696fd..58f45c56 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/notification/NotificationsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/notification/NotificationsView.java @@ -113,10 +113,19 @@ public class NotificationsView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/profile/following/ProfileFollowingView.java b/app/src/main/java/com/fastaccess/ui/modules/profile/following/ProfileFollowingView.java index b84dae2a..b76d23a5 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/profile/following/ProfileFollowingView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/profile/following/ProfileFollowingView.java @@ -79,10 +79,19 @@ public class ProfileFollowingView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/profile/gists/ProfileGistsView.java b/app/src/main/java/com/fastaccess/ui/modules/profile/gists/ProfileGistsView.java index 927429c7..ad35a6d3 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/profile/gists/ProfileGistsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/profile/gists/ProfileGistsView.java @@ -84,10 +84,19 @@ public class ProfileGistsView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/profile/starred/ProfileStarredView.java b/app/src/main/java/com/fastaccess/ui/modules/profile/starred/ProfileStarredView.java index dc952cc7..c41d772e 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/profile/starred/ProfileStarredView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/profile/starred/ProfileStarredView.java @@ -69,7 +69,6 @@ public class ProfileStarredView extends BaseFragment getLoadMore() { if (onLoadMore == null) { diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/RepoCommitsView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/RepoCommitsView.java index 0903e819..f25a5829 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/RepoCommitsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/RepoCommitsView.java @@ -118,11 +118,20 @@ public class RepoCommitsView extends BaseFragment branchesData, boolean firstTime) { diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerView.java index 4b2ec687..7c35464e 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerView.java @@ -95,6 +95,11 @@ public class ViewerView extends BaseFragment im super.showErrorMessage(msgRes); } + @Override public void showMessage(int titleRes, int msgRes) { + stateLayout.hideProgress(); + super.showMessage(titleRes, msgRes); + } + @Override protected int fragmentLayout() { return R.layout.general_viewer_layout; } diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/code/releases/RepoReleasesView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/code/releases/RepoReleasesView.java index f524f0e0..0d8daa7f 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/code/releases/RepoReleasesView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/code/releases/RepoReleasesView.java @@ -119,10 +119,19 @@ public class RepoReleasesView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/RepoOpenedIssuesView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/RepoOpenedIssuesView.java index 7e2d1b5c..3947e40a 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/RepoOpenedIssuesView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/RepoOpenedIssuesView.java @@ -120,9 +120,18 @@ public class RepoOpenedIssuesView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/details/comments/IssueCommentsView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/details/comments/IssueCommentsView.java index 930237ea..034cc66f 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/details/comments/IssueCommentsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/issue/details/comments/IssueCommentsView.java @@ -90,9 +90,18 @@ public class IssueCommentsView extends BaseFragment getLoadMore() { diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/pull_requests/pull_request/details/commits/PullRequestCommitsView.java b/app/src/main/java/com/fastaccess/ui/modules/repos/pull_requests/pull_request/details/commits/PullRequestCommitsView.java index 73ef681c..f3d00efc 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/pull_requests/pull_request/details/commits/PullRequestCommitsView.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/pull_requests/pull_request/details/commits/PullRequestCommitsView.java @@ -84,10 +84,19 @@ public class PullRequestCommitsView extends BaseFragment