From c40fa9d1ca19c3e60b1006b7e222dc45fb3bdd7e Mon Sep 17 00:00:00 2001 From: Kosh Date: Thu, 23 Feb 2017 21:02:25 +0800 Subject: [PATCH] fixed a bug in code viewer where we might endup in infinite loop if we failed to display the data from the url. --- .../java/com/fastaccess/provider/scheme/SchemeParser.java | 2 +- .../ui/modules/repos/code/prettifier/ViewerPresenter.java | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/fastaccess/provider/scheme/SchemeParser.java b/app/src/main/java/com/fastaccess/provider/scheme/SchemeParser.java index 4f48aefd..58025d94 100644 --- a/app/src/main/java/com/fastaccess/provider/scheme/SchemeParser.java +++ b/app/src/main/java/com/fastaccess/provider/scheme/SchemeParser.java @@ -95,7 +95,7 @@ public class SchemeParser { if (gist != null) { return GistView.createIntent(context, gist); } - } else if (HOST_DEFAULT.equals(data.getHost())) { + } else { Intent userIntent = getUser(context, data); Intent pullRequestIntent = getPullRequestIntent(context, data); Intent issueIntent = getIssueIntent(context, data); diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerPresenter.java b/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerPresenter.java index eb3d6acb..bcfd6b06 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerPresenter.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/code/prettifier/ViewerPresenter.java @@ -67,9 +67,7 @@ class ViewerPresenter extends BasePresenter implements ViewerMvp if (downloadedStream == null) { manageSubscription(FileModel.get(url) .subscribe(fileModel -> { - if (fileModel == null) { - onWorkOnline(); - } else { + if (fileModel != null) { isImage = MarkDownProvider.isImage(fileModel.getFullUrl()); if (isImage) { sendToView(view -> view.onSetImageUrl(fileModel.getFullUrl()));