From 0f08ecc1bc1d7cb424d6b00e56016eccab5ab9bb Mon Sep 17 00:00:00 2001 From: Kosh Date: Wed, 10 May 2017 16:42:52 +0800 Subject: [PATCH 1/2] this commit fixes commit comments are being added and not updated. --- .../code/commit/details/comments/CommitCommentsFragments.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/details/comments/CommitCommentsFragments.java b/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/details/comments/CommitCommentsFragments.java index b3efa6b4..b562dd87 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/details/comments/CommitCommentsFragments.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/code/commit/details/comments/CommitCommentsFragments.java @@ -143,7 +143,7 @@ public class CommitCommentsFragments extends BaseFragment Date: Wed, 10 May 2017 16:43:31 +0800 Subject: [PATCH 2/2] this commit fixes commit comments are be --- .../com/fastaccess/ui/modules/editor/EditorActivity.java | 5 ++++- .../com/fastaccess/ui/modules/editor/EditorPresenter.java | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/fastaccess/ui/modules/editor/EditorActivity.java b/app/src/main/java/com/fastaccess/ui/modules/editor/EditorActivity.java index 61e66cd2..e370f734 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/editor/EditorActivity.java +++ b/app/src/main/java/com/fastaccess/ui/modules/editor/EditorActivity.java @@ -175,7 +175,10 @@ public class EditorActivity extends BaseActivity " + sentVia.getText(); + String temp = savedText.toString(); + if (!temp.contains("\n> " + sentVia.getText())) { + savedText = savedText + "\n> " + sentVia.getText(); + } } getPresenter().onHandleSubmission(savedText, extraType, itemId, commentId, login, issueNumber, sha); return true; diff --git a/app/src/main/java/com/fastaccess/ui/modules/editor/EditorPresenter.java b/app/src/main/java/com/fastaccess/ui/modules/editor/EditorPresenter.java index d064bebd..683502f0 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/editor/EditorPresenter.java +++ b/app/src/main/java/com/fastaccess/ui/modules/editor/EditorPresenter.java @@ -179,7 +179,7 @@ class EditorPresenter extends BasePresenter implements EditorMvp CommentRequestModel requestModel = new CommentRequestModel(); requestModel.setBody(savedText.toString()); makeRestCall(RestProvider.getRepoService().editCommitComment(login, itemId, id, requestModel), - comment -> sendToView(view -> view.onSendResultAndFinish(comment, true))); + comment -> sendToView(view -> view.onSendResultAndFinish(comment, false))); } } }