No Wiki", "", arrayListOf()))
}
- s.onNext(WikiContentModel(content, "", sidebarList))
- } else {
- s.onNext(WikiContentModel("No Wiki", "", arrayListOf()))
+ } catch (e: Exception) {
+ e.printStackTrace()
}
s.onComplete()
}
diff --git a/app/src/main/java/com/fastaccess/ui/modules/reviews/AddReviewDialogFragment.kt b/app/src/main/java/com/fastaccess/ui/modules/reviews/AddReviewDialogFragment.kt
index 26b716a2..ea599c0d 100644
--- a/app/src/main/java/com/fastaccess/ui/modules/reviews/AddReviewDialogFragment.kt
+++ b/app/src/main/java/com/fastaccess/ui/modules/reviews/AddReviewDialogFragment.kt
@@ -3,7 +3,6 @@ package com.fastaccess.ui.modules.reviews
import android.content.Context
import android.graphics.Color
import android.os.Bundle
-import android.support.design.widget.TextInputLayout
import android.support.v4.content.ContextCompat
import android.support.v7.widget.Toolbar
import android.view.View
@@ -18,6 +17,7 @@ import com.fastaccess.helper.ViewHelper
import com.fastaccess.ui.base.BaseDialogFragment
import com.fastaccess.ui.base.mvp.BaseMvp
import com.fastaccess.ui.base.mvp.presenter.BasePresenter
+import com.fastaccess.ui.modules.editor.comment.CommentEditorFragment
import com.fastaccess.ui.modules.reviews.callback.ReviewCommentListener
import com.fastaccess.ui.widgets.SpannableBuilder
@@ -29,8 +29,10 @@ class AddReviewDialogFragment : BaseDialogFragment(BundleConstant.ITEM)
lineNo.text = SpannableBuilder.builder()
.append(if (item.leftLineNo >= 0) String.format("%s.", item.leftLineNo) else "")
@@ -75,11 +84,12 @@ class AddReviewDialogFragment : BaseDialogFragment(), ReviewChangesMvp.View {
-
+class ReviewChangesActivity : BaseDialogFragment(), ReviewChangesMvp.View {
@BindView(R.id.toolbar) lateinit var toolbar: Toolbar
@BindView(R.id.reviewMethod) lateinit var spinner: Spinner
- @BindView(R.id.editText) lateinit var editText: TextInputLayout
@State var reviewRequest: ReviewRequestModel? = null
@State var repoId: String? = null
@State var owner: String? = null
@State var number: Long? = null
- @State var isProgressShowing: Boolean = false
@State var isClosed: Boolean = false
+ @State var isAuthor: Boolean = false
- override fun layout(): Int = R.layout.add_review_dialog_layout
+ private var subimssionCallback: ReviewChangesMvp.ReviewSubmissionCallback? = null
- override fun isTransparent(): Boolean = true
+ private val commentEditorFragment: CommentEditorFragment? by lazy {
+ childFragmentManager.findFragmentByTag("commentContainer") as CommentEditorFragment?
+ }
- override fun canBack(): Boolean = true
+ override fun onAttach(context: Context?) {
+ super.onAttach(context)
+ if (parentFragment is ReviewChangesMvp.ReviewSubmissionCallback) {
+ subimssionCallback = parentFragment as ReviewChangesMvp.ReviewSubmissionCallback
+ } else if (context is ReviewChangesMvp.ReviewSubmissionCallback) {
+ subimssionCallback = context
+ }
+ }
- override fun isSecured(): Boolean = false
+ override fun onDetach() {
+ subimssionCallback = null
+ super.onDetach()
+ }
override fun providePresenter(): ReviewChangesPresenter = ReviewChangesPresenter()
- override fun onCreate(savedInstanceState: Bundle?) {
- ThemeEngine.applyDialogTheme(this)
- super.onCreate(savedInstanceState)
- setToolbarIcon(R.drawable.ic_clear)
- val bundle = intent.extras!!
- reviewRequest = bundle.getParcelable(BundleConstant.EXTRA)
- repoId = bundle.getString(BundleConstant.EXTRA_TWO)
- owner = bundle.getString(BundleConstant.EXTRA_THREE)
- number = bundle.getLong(BundleConstant.ID)
- isClosed = bundle.getBoolean(BundleConstant.EXTRA_FIVE)
- val isAuthor = bundle.getBoolean(BundleConstant.EXTRA_FOUR)
+ override fun fragmentLayout(): Int = R.layout.add_review_dialog_layout
+
+ override fun onFragmentCreated(view: View, savedInstanceState: Bundle?) {
+ if (savedInstanceState == null) {
+ val fragment = CommentEditorFragment()
+ fragment.arguments = Bundler.start().put(BundleConstant.YES_NO_EXTRA, true).end()
+ childFragmentManager.beginTransaction()
+ .replace(R.id.commentContainer, fragment, "commentContainer")
+ .commit()
+ val bundle = arguments!!
+ reviewRequest = bundle.getParcelable(BundleConstant.EXTRA)
+ repoId = bundle.getString(BundleConstant.EXTRA_TWO)
+ owner = bundle.getString(BundleConstant.EXTRA_THREE)
+ number = bundle.getLong(BundleConstant.ID)
+ isClosed = bundle.getBoolean(BundleConstant.EXTRA_FIVE)
+ isAuthor = bundle.getBoolean(BundleConstant.EXTRA_FOUR)
+ }
+ toolbar.navigationIcon = ContextCompat.getDrawable(context, R.drawable.ic_clear)
+ toolbar.inflateMenu(R.menu.done_menu)
+ toolbar.setNavigationOnClickListener { dismiss() }
+ toolbar.setOnMenuItemClickListener {
+ if (it.itemId == R.id.submit) {
+ if (spinner.selectedItemPosition != 0 && commentEditorFragment?.getEditText()?.text.isNullOrEmpty()) {
+ commentEditorFragment?.getEditText()?.error = getString(R.string.required_field)
+ } else {
+ commentEditorFragment?.getEditText()?.error = null
+ presenter.onSubmit(reviewRequest!!, repoId!!, owner!!, number!!, InputHelper.toString(commentEditorFragment?.getEditText()?.text)
+ , spinner.selectedItem as String)
+ }
+ }
+ return@setOnMenuItemClickListener true
+ }
+
if (isAuthor || isClosed) {
spinner.setSelection(2, true)
spinner.isEnabled = false
}
}
- override fun onCreateOptionsMenu(menu: Menu?): Boolean {
- menuInflater.inflate(R.menu.done_menu, menu)
- return super.onCreateOptionsMenu(menu)
- }
-
- override fun onOptionsItemSelected(item: MenuItem?): Boolean {
- when (item?.itemId) {
- R.id.submit -> {
- if (spinner.selectedItemPosition != 0 && editText.editText?.text.isNullOrEmpty()) {
- editText.error = getString(R.string.required_field)
- } else {
- editText.error = null
- presenter.onSubmit(reviewRequest!!, repoId!!, owner!!, number!!, InputHelper.toString(editText), spinner.selectedItem as String)
- }
- return true
- }
- else -> {
- return super.onOptionsItemSelected(item)
- }
- }
- }
-
override fun onSuccessfullySubmitted() {
- setResult(Activity.RESULT_OK)
- finish()
+ hideProgress()
+ subimssionCallback?.onSuccessfullyReviewed()
+ dismiss()
}
override fun onErrorSubmitting() {
showErrorMessage(getString(R.string.network_error))
}
- override fun showProgress(@StringRes resId: Int) {
- var msg = getString(R.string.in_progress)
- if (resId != 0) {
- msg = getString(resId)
- }
- if (!isProgressShowing && !isFinishing) {
- var fragment = AppHelper.getFragmentByTag(supportFragmentManager,
- ProgressDialogFragment.TAG) as ProgressDialogFragment?
- if (fragment == null) {
- isProgressShowing = true
- fragment = ProgressDialogFragment.newInstance(msg, false)
- fragment.show(supportFragmentManager, ProgressDialogFragment.TAG)
- }
- }
- }
-
- override fun hideProgress() {
- val fragment = AppHelper.getFragmentByTag(supportFragmentManager, ProgressDialogFragment.TAG) as ProgressDialogFragment?
- if (fragment != null) {
- isProgressShowing = false
- fragment.dismiss()
- }
- }
-
override fun showMessage(titleRes: Int, msgRes: Int) {
hideProgress()
super.showMessage(titleRes, msgRes)
@@ -133,9 +117,26 @@ class ReviewChangesActivity : BaseActivity? {
+ return arrayListOf()
+ }
+
companion object {
- fun startForResult(activity: Activity, view: View, reviewChanges: ReviewRequestModel, repoId: String, owner: String, number: Long,
- isAuthor: Boolean, isEnterprise: Boolean, isClosed: Boolean) {
+ fun startForResult(reviewChanges: ReviewRequestModel, repoId: String, owner: String, number: Long,
+ isAuthor: Boolean, isEnterprise: Boolean, isClosed: Boolean): ReviewChangesActivity {
+ val fragment = ReviewChangesActivity()
val bundle = Bundler.start()
.put(BundleConstant.EXTRA, reviewChanges)
.put(BundleConstant.EXTRA_TWO, repoId)
@@ -145,9 +146,8 @@ class ReviewChangesActivity : BaseActivity(), ReviewCha
} else {
sendToView { it.onErrorSubmitting() }
}
- })
+ }, false)
}
}
\ No newline at end of file
diff --git a/app/src/main/java/com/fastaccess/ui/modules/settings/SlackBottomSheetDialog.java b/app/src/main/java/com/fastaccess/ui/modules/settings/SlackBottomSheetDialog.java
index 91cf9aed..e999d0ca 100644
--- a/app/src/main/java/com/fastaccess/ui/modules/settings/SlackBottomSheetDialog.java
+++ b/app/src/main/java/com/fastaccess/ui/modules/settings/SlackBottomSheetDialog.java
@@ -51,7 +51,7 @@ public class SlackBottomSheetDialog extends BaseBottomSheetDialog {
@OnClick({R.id.cancel, R.id.ok}) public void onViewClicked(View view) {
switch (view.getId()) {
case R.id.ok:
- ActivityHelper.startCustomTab(getActivity(), "http://rebrand.ly/fasthub-slack");
+ ActivityHelper.startCustomTab(getActivity(), "http://rebrand.ly/fasthub");
break;
}
if (listener != null) listener.onDismissed();
diff --git a/app/src/main/java/com/fastaccess/ui/modules/theme/ThemeActivity.kt b/app/src/main/java/com/fastaccess/ui/modules/theme/ThemeActivity.kt
index 7f776c80..aade5618 100644
--- a/app/src/main/java/com/fastaccess/ui/modules/theme/ThemeActivity.kt
+++ b/app/src/main/java/com/fastaccess/ui/modules/theme/ThemeActivity.kt
@@ -7,6 +7,7 @@ import android.os.Bundle
import android.view.View
import android.view.ViewAnimationUtils
import butterknife.BindView
+import butterknife.OnClick
import com.fastaccess.R
import com.fastaccess.data.dao.FragmentPagerAdapterModel
import com.fastaccess.helper.PrefGetter
@@ -14,6 +15,7 @@ import com.fastaccess.ui.adapter.FragmentsPagerAdapter
import com.fastaccess.ui.base.BaseActivity
import com.fastaccess.ui.base.mvp.BaseMvp
import com.fastaccess.ui.base.mvp.presenter.BasePresenter
+import com.fastaccess.ui.modules.main.premium.PremiumActivity
import com.fastaccess.ui.modules.theme.fragment.ThemeFragmentMvp
import com.fastaccess.ui.widgets.CardsPagerTransformerBasic
import com.fastaccess.ui.widgets.ViewPagerView
@@ -28,8 +30,11 @@ class ThemeActivity : BaseActivity
@BindView(R.id.pager) lateinit var pager: ViewPagerView
@BindView(R.id.parentLayout) lateinit var parentLayout: View
- override fun layout(): Int = R.layout.theme_viewpager
+ @OnClick(R.id.premium) fun onOpenPremium() {
+ PremiumActivity.startActivity(this)
+ }
+ override fun layout(): Int = R.layout.theme_viewpager
override fun isTransparent(): Boolean = false
diff --git a/app/src/main/java/com/fastaccess/ui/modules/theme/fragment/ThemeFragment.kt b/app/src/main/java/com/fastaccess/ui/modules/theme/fragment/ThemeFragment.kt
index dfe09b87..39a3325d 100644
--- a/app/src/main/java/com/fastaccess/ui/modules/theme/fragment/ThemeFragment.kt
+++ b/app/src/main/java/com/fastaccess/ui/modules/theme/fragment/ThemeFragment.kt
@@ -11,7 +11,6 @@ import android.view.ContextThemeWrapper
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
-import android.widget.ProgressBar
import butterknife.BindView
import butterknife.ButterKnife
import butterknife.Unbinder
@@ -19,6 +18,7 @@ import com.fastaccess.R
import com.fastaccess.helper.*
import com.fastaccess.ui.base.BaseFragment
import com.fastaccess.ui.modules.main.donation.DonateActivity
+import com.fastaccess.ui.modules.main.premium.PremiumActivity
import com.fastaccess.ui.widgets.SpannableBuilder
/**
@@ -113,6 +113,7 @@ class ThemeFragment : BaseFragment setTheme(getString(R.string.dark_theme_mode))
R.style.ThemeAmlod -> applyAmlodTheme()
R.style.ThemeBluish -> applyBluishTheme()
+ R.style.ThemeMidnight -> applyMidnightTheme()
}
}
@@ -134,6 +135,15 @@ class ThemeFragment : BaseFragment(), Tr
val bundle = intent.extras
if (bundle != null) {
val lang: String = bundle.getString(BundleConstant.EXTRA)
- val query: String = bundle.getString(BundleConstant.EXTRA_TWO)
+ val query: String? = bundle.getString(BundleConstant.EXTRA_TWO)
if (!lang.isEmpty()) {
selectedTitle = lang
}
- if (!query.isEmpty()) {
- when (query.toLowerCase()) {
+ if (query.isNullOrEmpty()) {
+ daily.isSelected = true
+ } else {
+ when (query?.toLowerCase()) {
"daily" -> daily.isSelected = true
"weekly" -> weekly.isSelected = true
"monthly" -> monthly.isSelected = true
}
- } else {
- daily.isSelected = true
}
} else {
daily.isSelected = true
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/StateLayout.java b/app/src/main/java/com/fastaccess/ui/widgets/StateLayout.java
index fbfbd6e1..7a126f42 100644
--- a/app/src/main/java/com/fastaccess/ui/widgets/StateLayout.java
+++ b/app/src/main/java/com/fastaccess/ui/widgets/StateLayout.java
@@ -95,8 +95,8 @@ public class StateLayout extends NestedScrollView {
}
public void setEmptyText(@NonNull String text) {
- this.emptyTextValue = text;
- emptyText.setText(text);
+ this.emptyTextValue = text + "\n\n¯\\_(ツ)_/¯";
+ emptyText.setText(emptyTextValue);
}
public void showEmptyState() {
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/dialog/ProgressDialogFragment.java b/app/src/main/java/com/fastaccess/ui/widgets/dialog/ProgressDialogFragment.java
index 1e2a70ed..8a1222d6 100644
--- a/app/src/main/java/com/fastaccess/ui/widgets/dialog/ProgressDialogFragment.java
+++ b/app/src/main/java/com/fastaccess/ui/widgets/dialog/ProgressDialogFragment.java
@@ -10,6 +10,7 @@ import android.support.v4.app.DialogFragment;
import com.fastaccess.helper.AnimHelper;
import com.fastaccess.helper.Bundler;
+import com.fastaccess.helper.PrefGetter;
/**
* Created by Kosh on 09 Dec 2016, 5:18 PM
@@ -39,7 +40,8 @@ public class ProgressDialogFragment extends DialogFragment {
progressDialog.setCancelable(isCancelable);
setCancelable(isCancelable);
if (getActivity() != null && !getActivity().isFinishing()) {
- progressDialog.setOnShowListener(dialogInterface -> AnimHelper.revealDialog(progressDialog, 200));
+ if (!PrefGetter.isAppAnimationDisabled())
+ progressDialog.setOnShowListener(dialogInterface -> AnimHelper.revealDialog(progressDialog, 200));
}
return progressDialog;
}
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/markdown/MarkDownLayout.kt b/app/src/main/java/com/fastaccess/ui/widgets/markdown/MarkDownLayout.kt
index 92aa472f..b3715652 100644
--- a/app/src/main/java/com/fastaccess/ui/widgets/markdown/MarkDownLayout.kt
+++ b/app/src/main/java/com/fastaccess/ui/widgets/markdown/MarkDownLayout.kt
@@ -35,6 +35,7 @@ class MarkDownLayout : LinearLayout {
var markdownListener: MarkdownListener? = null
@BindView(R.id.editorIconsHolder) lateinit var editorIconsHolder: HorizontalScrollView
+ @BindView(R.id.addEmoji) lateinit var addEmojiView: View
constructor(context: Context?) : super(context)
constructor(context: Context?, attrs: AttributeSet?) : super(context, attrs)
@@ -61,12 +62,14 @@ class MarkDownLayout : LinearLayout {
editText.isEnabled = false
MarkDownProvider.setMdText(editText, InputHelper.toString(editText))
editorIconsHolder.visibility = View.INVISIBLE
+ addEmojiView.visibility = View.INVISIBLE
ViewHelper.hideKeyboard(editText)
} else {
editText.setText(it.getSavedText())
editText.setSelection(editText.text.length)
editText.isEnabled = true
editorIconsHolder.visibility = View.VISIBLE
+ addEmojiView.visibility = View.VISIBLE
ViewHelper.showKeyboard(editText)
}
}
@@ -84,8 +87,10 @@ class MarkDownLayout : LinearLayout {
Snackbar.make(this, R.string.error_highlighting_editor, Snackbar.LENGTH_SHORT).show()
} else {
when {
- v.id == R.id.link -> EditorLinkImageDialogFragment.newInstance(true).show(it.fragmentManager(), "BannerDialogFragment")
- v.id == R.id.image -> EditorLinkImageDialogFragment.newInstance(false).show(it.fragmentManager(), "BannerDialogFragment")
+ v.id == R.id.link -> EditorLinkImageDialogFragment.newInstance(true)
+ .show(it.fragmentManager(), "EditorLinkImageDialogFragment")
+ v.id == R.id.image -> EditorLinkImageDialogFragment.newInstance(false)
+ .show(it.fragmentManager(), "EditorLinkImageDialogFragment")
v.id == R.id.addEmoji -> {
ViewHelper.hideKeyboard(it.getEditText())
EmojiBottomSheet().show(it.fragmentManager(), "EmojiBottomSheet")
@@ -126,6 +131,8 @@ class MarkDownLayout : LinearLayout {
} else {
it.setText(it.text.toString().replace(sentFromFastHub, ""))
}
+ editText.setSelection(it.text.length)
+ editText.requestFocus()
}
}
}
@@ -135,12 +142,7 @@ class MarkDownLayout : LinearLayout {
markdownListener?.getEditText()?.let { editText ->
ViewHelper.showKeyboard(editText)
emoji?.let {
- editText.setText(if (editText.text.isNullOrEmpty()) {
- ":${it.aliases[0]}:"
- } else {
- "${editText.text} :${it.aliases[0]}:"
- })
- editText.setSelection(editText.text.length)
+ MarkDownProvider.insertAtCursor(editText, ":${it.aliases[0]}:")
}
}
}
@@ -150,4 +152,14 @@ class MarkDownLayout : LinearLayout {
fun fragmentManager(): FragmentManager
fun getSavedText(): CharSequence?
}
+
+ fun onAppendLink(title: String?, link: String?, isLink: Boolean) {
+ markdownListener?.let {
+ if (isLink) {
+ MarkDownProvider.addLink(it.getEditText(), InputHelper.toString(title), InputHelper.toString(link))
+ } else {
+ MarkDownProvider.addPhoto(it.getEditText(), InputHelper.toString(title), InputHelper.toString(link))
+ }
+ }
+ }
}
\ No newline at end of file
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/DynamicRecyclerView.java b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/DynamicRecyclerView.java
index 27f3de75..f110d1fa 100644
--- a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/DynamicRecyclerView.java
+++ b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/DynamicRecyclerView.java
@@ -64,6 +64,7 @@ public class DynamicRecyclerView extends RecyclerView {
}
}
+
public void removeBottomDecoration() {
if (bottomPaddingDecoration != null) {
removeItemDecoration(bottomPaddingDecoration);
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/InfiniteScroll.java b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/InfiniteScroll.java
index d3e5e87e..7a55a496 100644
--- a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/InfiniteScroll.java
+++ b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/InfiniteScroll.java
@@ -48,6 +48,7 @@ public abstract class InfiniteScroll extends RecyclerView.OnScrollListener {
newlyAdded = false;
return;
}
+ onScrolled(dy > 0);
if (layoutManager == null) {
initLayoutManager(recyclerView.getLayoutManager());
}
@@ -103,5 +104,7 @@ public abstract class InfiniteScroll extends RecyclerView.OnScrollListener {
public abstract boolean onLoadMore(int page, int totalItemsCount);
+ public void onScrolled(boolean isUp) {}
+
}
diff --git a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/RecyclerViewFastScroller.java b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/RecyclerViewFastScroller.java
index e7c246d8..ca41c086 100755
--- a/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/RecyclerViewFastScroller.java
+++ b/app/src/main/java/com/fastaccess/ui/widgets/recyclerview/scroll/RecyclerViewFastScroller.java
@@ -229,6 +229,8 @@ public class RecyclerViewFastScroller extends FrameLayout {
protected void hideShow() {
if (recyclerView != null && recyclerView.getAdapter() != null) {
setVisibility(recyclerView.getAdapter().getItemCount() > 10 ? VISIBLE : GONE);
+ } else {
+ setVisibility(GONE);
}
}
}
\ No newline at end of file
diff --git a/app/src/main/java/com/prettifier/pretty/PrettifyWebView.java b/app/src/main/java/com/prettifier/pretty/PrettifyWebView.java
index 1b79bcdf..bd9f6900 100644
--- a/app/src/main/java/com/prettifier/pretty/PrettifyWebView.java
+++ b/app/src/main/java/com/prettifier/pretty/PrettifyWebView.java
@@ -19,6 +19,7 @@ import android.webkit.WebViewClient;
import com.fastaccess.R;
import com.fastaccess.helper.AppHelper;
import com.fastaccess.helper.InputHelper;
+import com.fastaccess.helper.Logger;
import com.fastaccess.helper.ViewHelper;
import com.fastaccess.provider.markdown.MarkDownProvider;
import com.fastaccess.provider.scheme.SchemeParser;
@@ -195,15 +196,21 @@ public class PrettifyWebView extends NestedWebView {
post(() -> loadDataWithBaseURL("file:///android_asset/md/", page, "text/html", "utf-8", null));
}
- public void loadImage(@NonNull String url) {
+ public void loadImage(@NonNull String url, boolean isSvg) {
WebSettings settings = getSettings();
settings.setLayoutAlgorithm(WebSettings.LayoutAlgorithm.SINGLE_COLUMN);
setScrollBarStyle(View.SCROLLBARS_INSIDE_OVERLAY);
settings.setSupportZoom(true);
settings.setBuiltInZoomControls(true);
settings.setDisplayZoomControls(false);
- String html = "![](\"")
";
+ String html;
+ if (isSvg) {
+ html = url;
+ } else {
+ html = "" +
+ "";
+ }
+ Logger.e(html);
loadData(html, "text/html", null);
}
diff --git a/app/src/main/java/com/prettifier/pretty/helper/GithubHelper.java b/app/src/main/java/com/prettifier/pretty/helper/GithubHelper.java
index f341da43..a88bac09 100644
--- a/app/src/main/java/com/prettifier/pretty/helper/GithubHelper.java
+++ b/app/src/main/java/com/prettifier/pretty/helper/GithubHelper.java
@@ -23,7 +23,8 @@ import java.util.ArrayList;
public class GithubHelper {
@NonNull public static String generateContent(@NonNull Context context, @NonNull String source,
- @Nullable String baseUrl, boolean dark, boolean isWiki, boolean replace) {
+ @Nullable String baseUrl, boolean dark,
+ boolean isWiki, boolean replace) {
if (baseUrl == null) {
return mergeContent(context, source, dark, replace);
} else {
diff --git a/app/src/main/res/drawable/fastscroller_bubble.xml b/app/src/main/res/drawable/fastscroller_bubble.xml
index 611c1571..30d3322f 100755
--- a/app/src/main/res/drawable/fastscroller_bubble.xml
+++ b/app/src/main/res/drawable/fastscroller_bubble.xml
@@ -3,7 +3,7 @@
xmlns:android="http://schemas.android.com/apk/res/android">
-
-
+
diff --git a/app/src/main/res/layouts/main_layouts/layout-land/repo_file_header_layout.xml b/app/src/main/res/layouts/main_layouts/layout-land/repo_file_header_layout.xml
index 12abc715..d624a675 100644
--- a/app/src/main/res/layouts/main_layouts/layout-land/repo_file_header_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout-land/repo_file_header_layout.xml
@@ -83,6 +83,19 @@
android:padding="@dimen/spacing_micro"
android:src="@drawable/ic_download"/>
+
+
+ android:layout_margin="@dimen/spacing_xs_large"
+ android:entries="@array/review_methods"/>
-
-
-
-
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/comment_box_layout.xml b/app/src/main/res/layouts/main_layouts/layout/comment_box_layout.xml
index c8c131f2..ee8c2667 100644
--- a/app/src/main/res/layouts/main_layouts/layout/comment_box_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/comment_box_layout.xml
@@ -8,15 +8,11 @@
android:background="?colorPrimary"
android:orientation="vertical">
-
diff --git a/app/src/main/res/layouts/main_layouts/layout/delete_repo_file_layout.xml b/app/src/main/res/layouts/main_layouts/layout/delete_repo_file_layout.xml
new file mode 100644
index 00000000..fd278f40
--- /dev/null
+++ b/app/src/main/res/layouts/main_layouts/layout/delete_repo_file_layout.xml
@@ -0,0 +1,94 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/edit_repo_file_layout.xml b/app/src/main/res/layouts/main_layouts/layout/edit_repo_file_layout.xml
new file mode 100644
index 00000000..7b8e8bcd
--- /dev/null
+++ b/app/src/main/res/layouts/main_layouts/layout/edit_repo_file_layout.xml
@@ -0,0 +1,112 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml b/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
index 24b0fd93..dc553a76 100644
--- a/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/issue_pager_activity.xml
@@ -8,7 +8,7 @@
android:layout_height="match_parent"
android:fitsSystemWindows="true">
-
+ android:layout_height="match_parent"
+ android:layout_above="@+id/commentFragment">
+
diff --git a/app/src/main/res/layouts/main_layouts/layout/pro_features_layout.xml b/app/src/main/res/layouts/main_layouts/layout/pro_features_layout.xml
index 879cee18..03f16f36 100644
--- a/app/src/main/res/layouts/main_layouts/layout/pro_features_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/pro_features_layout.xml
@@ -2,6 +2,8 @@
@@ -274,4 +276,24 @@
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/project_columns_layout.xml b/app/src/main/res/layouts/main_layouts/layout/project_columns_layout.xml
new file mode 100644
index 00000000..22c30db4
--- /dev/null
+++ b/app/src/main/res/layouts/main_layouts/layout/project_columns_layout.xml
@@ -0,0 +1,106 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/projects_activity_layout.xml b/app/src/main/res/layouts/main_layouts/layout/projects_activity_layout.xml
new file mode 100644
index 00000000..848b5831
--- /dev/null
+++ b/app/src/main/res/layouts/main_layouts/layout/projects_activity_layout.xml
@@ -0,0 +1,40 @@
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/pull_request_files_layout.xml b/app/src/main/res/layouts/main_layouts/layout/pull_request_files_layout.xml
new file mode 100644
index 00000000..de055b8e
--- /dev/null
+++ b/app/src/main/res/layouts/main_layouts/layout/pull_request_files_layout.xml
@@ -0,0 +1,96 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/repo_file_header_layout.xml b/app/src/main/res/layouts/main_layouts/layout/repo_file_header_layout.xml
index d35bf4bc..e8b6ba28 100644
--- a/app/src/main/res/layouts/main_layouts/layout/repo_file_header_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/repo_file_header_layout.xml
@@ -48,6 +48,7 @@
android:layout_height="wrap_content"
android:orientation="horizontal">
+
-
-
-
+ android:layout_height="wrap_content"/>
\ No newline at end of file
diff --git a/app/src/main/res/layouts/main_layouts/layout/search_layout.xml b/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
index 1c406f4e..041aef20 100644
--- a/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
+++ b/app/src/main/res/layouts/main_layouts/layout/search_layout.xml
@@ -57,7 +57,7 @@
android:contentDescription="@string/clear"
android:padding="@dimen/spacing_micro"
android:src="@drawable/ic_clear"
- android:visibility="invisible"/>
+ android:visibility="gone"/>
-
@@ -9,7 +10,20 @@
\ No newline at end of file
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/layouts/row_layouts/layout/comments_row_item.xml b/app/src/main/res/layouts/row_layouts/layout/comments_row_item.xml
index d0bd5ede..2414ebf7 100644
--- a/app/src/main/res/layouts/row_layouts/layout/comments_row_item.xml
+++ b/app/src/main/res/layouts/row_layouts/layout/comments_row_item.xml
@@ -119,7 +119,7 @@
-
+ android:orientation="horizontal">
-
+
-
+
-
+
FastHub changelog
-
-Version 4.0.3 (Multiple Accounts, Enterprise & PR changes)
-
-
- Thanks to
- @passsy & his company
- @grandcentrix
- for providing me with an Enterprise account in their server to ease implementing Enterprise support in FastHub.
-
-
-
- Thanks to
- cookicons
- for creating
- FastHub
- new icon.
-
-
-
- Thanks to
- @dedepete
- for helping out with CI & configuring nightly builds for
- FastHub
-
-
-Bugs , Enhancements & new Features (4.0.3 & 4.0.0)
-
-
- - (4.0.3 Fix) Disabled tinting in light theme
- - (4.0.3 Fix) Fixed some notification crashes on some devices
- - (4.0.3 Fix) Updated app shortcuts icons (thanks @lucasvalenteds)
- - (4.0.3 Fix) Ordering langauge locales
- - (4.0.3 Fix) Attempt to fix a crash on some devices when browsing large number of Commit files
- - (4.0.3 New) Added copy URL to commit
- - (4.0.2 New) Added a way to disable navigation bar tinitng in different themes (Settings/Customization)
- - (4.0.2 Fix) Fixed clicking on notification might crash on some devices
- - (4.0.2 Fix) Fixed app shortcut icons to follow material design guidelines
- - (4.0.2 Fix) Fixed Traditional & Simplified Chinese langauge locale
- - (4.0.2 Fix) This release also has an attempt to fix Google Play Service crash when installing
- FastHub
-
- - (4.0.2 Fix) This release fixes app hangs on devices that don't have Google Play Service installed.
- - (4.0.1 Fix) Pinned repos crashes
- - (4.0.1 Fix) Multiple Accounts (if enterprise account login is same as GitHub) thanks
- @passsy
-
- - (New) Multiple Accounts
- - (New) Enterprise support
- - (New) PR review changes & on-line-number reviews
- - (New) Support to all merge strategies (Squash & Rebase)
- - (New) Comment on Commit file changes (on Code line number)
- - (New) Revamp of Branches & Tags, now its easy to differentiate between them
- - (New) Clicking on multiple Commits now will ask you which one to open.
- - (New) Now you can share links to FastHub from external Apps
- - (New) Showing owner & original poster in comments
- - (New) Custom code color palette
- - (New) Clicking on License should open its corresponding file
- - (New) Comment links are now copy-able thanks to (@eygraber)
- - (New) Pinned repos are now smart to sort your Pinned Repos by itself.
- - (New) Access your Repos from Menu Drawer
- - (New) Access your Starred Repos from Menu Drawer
- - (New) Showing the top most 5 accessed Pinned Repos in Menu Drawer
- - (New)
- FastHub
- now has Nightly builds thanks (@dedepete)
-
- - (New) Disabling Issues Tab if Issues disabled in Repo.
- - (New) Added Share to Users & Organizations profiles
- - (New) Czech language thanks to (@hejsekvojtech)
- - (New) Spanish language thanks to (@alete)
- - (Enhancement) Opening FastHub from other Apps should open FastHub in new document thanks to (@eygraber)
- - (Enhancement) Wiki links
- - (Enhancement) Issue & PRs grammar
- - (Enhancement) Overall app layouts enhancements.
- - (Fix) Opening Submodule.
- - (Fix) Trending Language & today's stars.
- - (Fix) Code wrapping.
- - (Fix) PRs/Issues where the assigned user was a Team.
- - (Fix) Added back support for Local DB in some places
- - (Fix) Added Pagination to Branches & Tags.
- - (Fix) Traditional & Simplified Chinese language selector.
- - (Fix) Deep markdown images relative paths.
- - (Fix) Brought back fully zoom-out in code.
- - (Fix) More deeper file links parsing
- - (Fix) First Comment edited date.
- - (Fix) All notifications refresh isn’t disappeared.
- - (Fix) Readme progressbar
- - (Fix) Some crashes from the crash report.
- - (Fix) Lots of bug fixes
- - There are more stuff are not mentioned, find them out :p
-
-
- P.S: FastHub is still in development mode, things will eventually come, rating FastHub 1 or 5 stars in Play store to request a new
- feature or to report an issue they’ll be ignored, the best place to report issues/FRs are in GitHub issue ticket, you could go to
- About & click on
- Report Issue
- and the issue will be posted directly to
- FastHub
- repo.
-
-
-
- Thanks to everyone who contributed either via reporting bugs or via code contribution
-
-
- Thank you very much
-
\ No newline at end of file
+
+
+
+
+ Untitled Document.md
+
+
+
+ FastHub changelog
+
+ Version 4.2.0 (Create, Edit & Delete files (make Commits))
+
+
+ Reporting Issues or Feature Requests in Google Play review section, will be ignored or might even get your account to be blocked from
+ FastHub. You are using an app for GitHub, which provides a proper way to report issues.
+
+ Please report the issues in FastHub repo instead, by opening the Drawer Menu, click about and click “Report an Issue”PLEASE
+ USE IT.
+
+
+ Bugs , Enhancements & new Features (3.2.0)
+
+
+ - (New) Make commits on repos from FastHub (this only applies for repo owners so far).
+ PRO
+
+ - (New) Long pressing files/directories will open up their Commit/Git History.
+ - (New) Indicates PR review line has a comment.
+ - (New) Showing number of addition, deletion & files in PR files tab.
+ - (New) Untoggle MD rendering to see their actual code.
+ - (New) Settings option to disable Animations in FastHub.
+ - (New) Copy SHA from Commit.
+ - (New) Forks, Watchers & Stargazers links handling.
+ - (Enhancement) Loading larger number of comments per page.
+ - (Enhancement) Hide fab while scrolling in Issues & PR tab.
+ - (Fix) PR Status where it got somehow broken in previous release.
+ - (Fix) A text under PR status will indicates if the PR is mergable or not.
+ - (Fix) Tagging users in full screen editor.
+ - (Fix) Comments text selection where sometime they aren’t selectable.
+ - (Fix) PR Review footer is invisible in (4.1.0).
+ - (Fix) Cursor position after inserting emoji, links & images.
+ - (Fix) Teal customized accent was displayed as green.
+ - (Fix) Some crashes from the crash report.
+ - (Fix) Lots of bug fixes.
+ - There are more stuff are not mentioned, find them out :stuck_out_tongue:
+
+ What left in FastHub?
+
+
+
+ So far, FastHub has implemented almost all the features of GitHub, besides forProject Cards. Hopefully in the
+ next release FastHub will include that. The following releases will mainly be bug fixes or if a major feature is implemented.
+
+
+
+ How old is FastHub now?
+
+
+
+ FastHub is now 5 months & a week old. Since v1.0.0 it has really grow with each and every release. The only way this was
+ possible, was due to the community helping out either via reporting bugs, feature requests or even give hand to fix things or
+ implement things in the app. I’m really grateful for having such a great community. Thank you guys!
+
+
+
+ Thank you to all who have contributed either via reporting bugs or via code contribution.
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
index d24120f8..6dacd3b7 100644
--- a/app/src/main/res/values-de/strings.xml
+++ b/app/src/main/res/values-de/strings.xml
@@ -191,7 +191,7 @@
Wähle wie regelmäßig FastHub nach neuen Benachrichtigungen sucht.
Benachrichtigunssynchronisierungsintervall
Alle
- Verhalten :\& Aussehen
+ Verhalten & Aussehen
Listenanimationen aktivieren
Listenanimationen
Dialog deaktivieren, der verhindert, dass du FastHub ausversehen verlässt
diff --git a/app/src/main/res/values-ko/strings.xml b/app/src/main/res/values-ko/strings.xml
new file mode 100644
index 00000000..f7aeec1e
--- /dev/null
+++ b/app/src/main/res/values-ko/strings.xml
@@ -0,0 +1,430 @@
+
+ 로딩 중, 잠시만 기다려주세요
+ 행동
+ 설정
+ 제거
+ 취소
+ OK
+ 데이터 없음
+ 검색
+ FastHub를 계속 사용하려면 로그인하세요
+ FastHub를 사용하기 위해서 GitHub에 로그인하세요
+ 로그인 실패
+ 로그인
+ 공유
+ 새로고침
+ 프로필
+ 오류
+ 종료하려면 다시 한 번 눌러주세요
+ 열림
+ 닫힘
+ 저장소 선택
+ 팔로워
+ 팔로잉
+ 개요
+ 팔로우
+ 언팔로우
+ 사용자
+ 세부
+ 파일을 다운로드하여 해당 컨텐츠를 보세요
+ 최소 글자 (3)
+ 파일을 찾을 수 없습니다
+ readme를 찾을 수 없습니다
+ 다운로드 중…
+ 파일 다운로드 중…
+ 릴리즈됨
+ 초안 저장됨
+ 릴리즈
+ 내용 없음
+ 기여자
+ 기여
+ by
+ 영어로 요구 사항를 보내주세요
+ 이슈 닫기
+ 이슈 다시 열기
+ 다시 열기
+ 닫기
+ 성공적으로 다시 열었습니다
+ 대화 잠금은 다음을 의미합니다:\n·다른 사람은 이 이슈에 새로운 댓글을 남길 수 없습니다.\n·너와 이 저장소에 접근할 수 있는 공동작업자는 다른 사람이 볼 수 있는 댓글을 남길 수 있습니다\n·언제든 이 이슈를 잠금해제 할 수 있습니다.\n
+ 대화 잠금해제는 다음을 의미합니다:\n·모두가 이 이슈에 덧글을 남길 수 있습니다.\n·언제든 이 이슈를 잠글 수 있습니다.\n
+ 대화 잠금
+ 대화 잠금해제
+ 이슈 닫기 오류, 잠시 후 다시 시도해주세요
+ 이슈 다시 열기 오류, 잠시 후 다시 시도해주세요
+ 이슈 닫기 성공
+ 설명 없음
제목 1
+ 제목 2
+ 제목 3
+ 굵게
+ 기울임
+ 취소선
+ 순서없는 목록
+ 순서있는 목록
+ 제목
+ 인용구
+ 링크
+ 이미지
+ 제거
+ 추가
+ 변경
+ 상태
+ 계속 하시겠습니까?
+ 성공
+ to
+ 댓글을 삭제하는 중에 오류가 발생했습니다
+ 제거
+ 댓글
+ 댓글
+ 병합 성공
+ 파일 메뉴
+ 파일
+ 다운로드
+ 뒤로가기
+ 상위 폴더
+ 코드 뷰어
+ 브라우저로 열기
+ 큰 파일
+ 파일이 너무 커서 열 수 없습니다.\n"예"를 눌러 다운로드하세요
+ 뷰어
+ 보내기
+ 이곳에 입력해주세요
+ 설명
+ 파일 이름
+ 확장명을 가진 파일 이름
+ 비공개 Gist
+ 공개 Gist
+ 다음으로 보내기
+ 삭제
+ Gist를 삭제하는 중에 오류가 발생했습니다.
+ 파일 없음
+ 필수 입력란
+ 제출 성공
+ Gist 생성
+ 클리어
+ 사용자
+ 제목
+ 파일
+ 이정표
+ 자신을 담당자에 할당
+ 이슈 보내기
+ 이슈를 생성하는 중에 오류가 발생했습니다
+ 이슈 생성
+ 수정을 계속하려면 강조 표시를 선택 해제하세요
+ 알림
+ 읽지 않은 알림이 있습니다
+ 열기
+ 새로운 창 열기
+ 알림 종류
+ 꼬리표
+ 꼬리표 없음
+ 꼬리표 추가 성공
+ 피드백 보내기
+ 로그아웃
+ 피드백 감사합니다
+ 현재 버전
+ 버전
+ 개발을 지원하려면 광고를 활성화하세요
+ 사용자 이름
+ 비밀번호
+ 이중 인증 코드
+ 로그인
+ Gist 설명
+ 사용자 아바타를 클릭하여 사용자의 프로필을 열 수 있습니다
+ 포크 이벤트를 길게 클릭하여 원본 또는 분기된 저장소를 엽니 다
+ Release 다운로드
+ 설정
+ 파일 다운로드 또는 디렉토리 공유
+ 댓글을 탭하면 작성자의 태그를 지정하거나 댓글을 수정할 수 있습니다.\n길게 누르면 삭제됩니다
+ 저장소 즐겨찾기/즐겨찾기해제
+ 구독
+ 저장소 구독/구독해제
+ 사이드바에서 더 빨리 액세스 할 수 있도록 저장소를 고정하세요
+ 모두 닫기
+ URL을 찾을 수 없습니다
+ 마지막 업데이트
+ 미리보기
+ 구문 강조기
+ 구문 강조기를 활성화/비활성화합니다.
+ \n더 많은 설정을 보려면 Markdown 편집기 아이콘을 스크롤하세요.
+ 생성일
+ 파일 생성 날짜
+ 파일 업데이트 날짜
+ 모두 읽음으로 표시
+ 모든 알림
+ 읽지 않음
+ 모든
+ 저장소 삭제
+ 저장소 삭제는 되돌릴 수 없습니다
+ 30분
+ 20분
+ 10분
+ 5분
+ 1분
+ 1시간
+ 2시간
+ 3시간
+ 생성됨
+ 커밋됨
+ 다운로드됨
+ 팔로우됨
+ 이슈 댓글
+ 구성원
+ 풀 리퀘스트 댓글
+ 푸시됨
+ 팀
+ 삭제됨
+ 알 수 없음
+ 커밋 댓글
+ 분기 변경
+ 담당자
+ 수정
+ \u2022 수정됨
+ 이슈 업데이트
+ 풀 리퀘스트 업데이트
+ 이정표 없음
+ 추가
+ 완료
+ 홈
+ 이정표 생성
+ 이정표를 생성하는 중에 오류가 발생했습니다
+ 만기일
+ 담당자 없음
+ 이 분기
+ 커밋이 선택한 분기로 전환되었습니다
+ 일반
+ FastHub이 새 알림을 확인하는 빈도를 변경합니다
+ 동기화 간격
+ 항상
+ 행동
+ 사용자 정의
+ 목록 효과 활성화
+ 목록 효과
+ 앱 종료 확인 다이얼로그를 비활성화합니다
+ 앱 종료 확인 비활성화
+ 복원
+ 백업
+ 백업 성공!
+ 복원할 백업 선택
+ 허락되지 않은 권한
+ 마지막 업데이트: %s
+ 지금
+ 저장되지 않은 변경사항을 삭제하시겠습니까?
+ 비공개
+ 원형 아바타 대신 둥근 사각형 아바타를 사용합니다
+ 둥근 사각형 아바타
+ 앱 평점 매기기
+ 개발자
+ GitHub에서 포크하기
+ 이메일 보내기
+ FastHub에 관한 질문
+ 피드백
+ 오류 보고
+ 오류가 있습니까? 이곳에 입력해주세요.
+ 앱 정보
+ 알림
+ 끄기
+ 인증되지 않은 사용자
+ 이중 인증이 필요합니다
+ 이슈 없음
+ URL 복사
+ 복사됨
+ 커밋 메시지
+ 서버와 통신하는 중 오류가 발생했습니다
+ API를 요청하는 중에 오류가 발생했습니다
+ 서버 요청 오류, 잠시 후 다시 시도하세요
+ 알림을 읽음으로 표시
+ Gist 포크
+ 기본 브라우저로 로그인 (OAuth)
+ 또는
+ 알림 읽음 비활성화
+ 알림을 클릭하면 읽음으로 표시 기능 사용을 비활성화합니다
+ 테마
+ 기본 테마 선택
+ 테마 강조 색상 선택
+ 테마 강조 색상
+ 웹사이트
+ 개발 지원
+ 대단히 감사합니다!
+ 테마가 제대로 적용되지 않으면, 앱을 수동으로 재시작해주세요
+ 고정
+ 고정됨
+ 고정해제
+ 아직 고정된 저장소가 없으므로 여기에서 볼 수 있도록 고정하세요.\nP.S: 많이 액세스할수록 저장소는 위에 배치될 것입니다.
+ 네
+ 아니요
+ Feeds 없음
+ Gists 없음
+ 덧글 없음
+ 알림 없음
+ Follower 없음
+ Following 없음
+ 저장소 없음
+ 즐겨찾기된 저장소 없음
+ 커밋 없음
+ 기여자 없음
+ 릴리즈 없음
+ 닫힌 이슈 없음
+ 열린 이슈 없음
+ 이벤트 없음
+ 열린 풀 리퀘스트 없음
+ 닫힌 풀 리퀘스트 없음
+ 검색 결과 없음
+ 파일을 보기 위해 FastHub에서 파일을 저장하려면 권한을 허용하세요
+ 공개 Gist
+ 광고 활성화
+ 이슈 없음
+ 읽지 않은 알림 없음
+ 내 Gist
+ 변경사항
+ 클릭하여 알림 목록을 열거나 옆으로 밀어 닫으세요
+ 길게 누르면 어디서나 기본 화면으로 이동합니다
+ 생성됨
+ 담당됨
+ 언급됨
+ 이름
+ 색상
+ 꼬리표 샹성
+ 조직
+ 조직
+ 구성원
+ 팀
+ Members
+ 구성원 없음
+ 팀 없음
+ 조직 없음
+ 너의 조직을 찾을 수 없습니까?
+ 읽음으로 표시
+ 효과
+ 팝업 효과를 활성화합니다
+ 팝업 효과
+ 이정표
+ 담당자
+ 몇몇 검사를 통과하지 못했습니다
+ 몇몇 검사가 지연되었습니다
+ 모든 검사를 통과했습니다
+ 정렬
+ 최신 순
+ 오래된 순
+ 많은 댓글 순
+ 최신 댓글 순
+ 최신 업데이트 순
+ 최소 최신 업데이트 순
+ 최신 버전입니다
+ 새로운 버전이 있습니다
+ 검색 내용을 입력해주세요
+ 길게 누르면 이슈 티켓을 즉시 생성 할 수 있습니다
+ 이 풀 리퀘스트는 합병될 수 있습니다
+ 검토됨
+ 검토 취소됨
+ 변경 승인됨
+ 반응 없음
+ 반응
+ 줄 바꿈
+ 기본적으로 코드 뷰어에서 코드 줄 바꿈
+ 코드 줄 바꿈
+ 오픈소스 라이브러리
+ 알림음을 활성화합니다
+ 알림음 활성화
+ 알림 활성화
+ 개인 토큰으로 로그인
+ 개인 토큰
+ 기본 인증으로 로그인
+ 실제로 조직에 속해 있고 여기에서 볼 수 없다면 다음 링크를 따르십시오.
+ \nhttps://help.github.com/articles/about-third-party-application-restrictions\nPS: 조직에 FastHub 엑세스 권한을 부여하고 액세스 토큰을 사용해서 로그인할 수 있습니다.\n또한 https://github.com/settings/applications에서 FastHub를 찾아 조직 액세스로 스크롤 한 다음 승인 버튼을 클릭하세요.
+ 삽입
+ 선택
+ 사진 선택
+ $2.00 지원
+ $5.00 지원
+ $10.00 지원
+ $20.00 지원
+ 언어
+ 언어
+ 언어 선택
+ 언어를 선택하세요.
+ 구독 취소
+ from
+ in
+ 구독
+ 이 저장소에서 이슈가 사용 중지되었습니다
+ 엑세스 토큰
+ 기본 인증
+ 로그인 종류 선택
+ In Files
+ In Paths
+ 요청 검토
+ Slack 참여
+ FastHub Slack에 참여하시겠습니까?
+ 초대 성공
+ 답글
+ 이미지 불러오기에 실패했습니다
+ 병합 희망
+ 구독자
+ 검토자
+ 검토자 없음
+ %2$s%3$s을 사용하여 %1$s에서 보냈습니다
+ 서명 활성화
+ 서명을 통해 전송을 활성화합니다
+ 서명 상자 활성화
+ 확인란을 사용하여 텍스트 편집기에서 서명을 활성화/비활성화 할 수 있습니다.
+ 태그
+ 댓글 달기
+ 배너 소개
+ With FastHub 2.5.0, you can now better express yourself with banners
+ for your profile page.\n\nAnyone using the FastHub app, will see your header, and you\'ll
+ begin seeing other peoples headers as well! If you\'d like to create a banner for yourself,
+ make it 1280x384 or divisible, otherwise, it may get cropped.\n\nYou can add or change your
+ banner at any time, by creating a gist described "header.fst" with a file containing a
+ direct link to the header image.\n\nOr even simpler, just use the built-in image chooser!
+
+ 배너 선택
+ 이미지 불러오기 오류, 다시 시도하세요
+ 급상승
+ GitHub 제한 때문에 emojies로 정렬이 실제로 작동하지 않습니다
+ 위로 스크롤
+ 아래로 스크롤
+ 참여됨
+ 모두 선택됨
+ 모두 선택 취소됨
+ 구분선
+ 사용자 없음
+ 급상승 없음
+ 초기화
+ 적용
+ 필터
+ 종류
+ 정렬 순서
+ 담당자 추가 성공
+ 검토자 추가 성공
+ 이정표 추가 성공
+ Feed
+ 프리미엄 테마
+ 코드 색상 표
+ GitHub API의 모든 항목에 액세스하려면 GitHub 계정에 로그인하십시오.
+ 그렇지 않으면 GitHub API로 전송 된 토큰은 엔터프라이즈 계정에서 전송되기 때문에 Enterprise GitHub가 아닌
+ 다른 항목에 액세스 할 때마다 강제 로그아웃 될 수 있습니다.
+ 계정 추가
+ 계정 선택
+ 일치하지 않음
+ 경고
+ 소유자
+ 원본 포스터
+ 검토 취소
+ 테마에서 색상 네비게이션 바를 비활성화합니다
+ 무색 네비게이션
+ 알림 소리를 선택합니다
+ 알림 소리 선택
+ GIF 자동 재생 사용을 비활성화합니다
+ GIF 자동 재생 사용 비활성화
+ 요청된 변경 사항
+ Google Play 서비스를 사용할 수 없음
+ Gist 수정
+ 내용
+ 확장
+ SHA 복사
+ 코드로 보기
+ 앱 애니메이션
+ 모든 앱 애니메이션을 비활성화합니다
+ 이 풀 리퀘스트는 현재 병합될 수 없습니다
+
diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml
index 9624342f..dd08c90e 100644
--- a/app/src/main/res/values-pt-rBR/strings.xml
+++ b/app/src/main/res/values-pt-rBR/strings.xml
@@ -333,7 +333,7 @@
Token Pessoal
Entra com autenticação básica
Se você está ligado a alguma organização e não consegue vê-las aqui, por favor entre no link abaixo.
- \nhttps://help.github.com/articles/about-third-party-application-restrictions\nPS: Você poderia usar o token de acesso para entrar, o que vai
+ \nhttps://help.github.com/articles/about-third-party-application-restrictions\nPS: Você poderia usar o token de acesso para entrar, o que vai
permitir acesso ao FastHub para poder ver a lista de suas organizações.
Inserir
Selecionar
@@ -415,5 +415,18 @@
Original Poster
Cancelar Reviews
Desabilitar a coloração da barra de navegação nos temas
-Desabilitar a coloração da barra de navegação
+ Desabilitar a coloração da barra de navegação
+ Escolher som de notificação personalizado
+ Escolher Som de Notificação
+ Desabilitar o auto play de GIFs
+ Dessabilitar Reproduzir GIF
+ mudanças solicitadas
+ Google Play Service insdisponível
+ Editar Gist
+ Conteúdo
+ expandir
+ Copiar SHA
+ Ver como código
+ Animações no App
+ Desabilitar todas as animações no App.
diff --git a/app/src/main/res/values/arrays.xml b/app/src/main/res/values/arrays.xml
index f67089a7..faeb0a9a 100644
--- a/app/src/main/res/values/arrays.xml
+++ b/app/src/main/res/values/arrays.xml
@@ -130,6 +130,7 @@
- Český
- Español
- Български
+ - 한국어
@@ -148,6 +149,7 @@
- cs
- es
- bg
+ - ko
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index f3425700..66812982 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -91,6 +91,7 @@
Unlock
Unlock Everything
Feeds
-
Loading, please wait…
@@ -556,4 +556,13 @@
Edit Gist
Content
expand
+ Copy SHA
+ View as code
+ In App Animations
+ Disable in App animations everywhere.
+ This PR can\'t be merged now.
+ Projects
+ No Projects
+ No Cards
+ Added by %s
diff --git a/app/src/main/res/values/theme_amlod.xml b/app/src/main/res/values/theme_amlod.xml
index 6d2e6912..90f2ab1d 100644
--- a/app/src/main/res/values/theme_amlod.xml
+++ b/app/src/main/res/values/theme_amlod.xml
@@ -18,7 +18,7 @@
- @color/amlodWindowBackground
- #040408
- #010102
- - #483078
+ - #2962FF
- ?colorAccent
- ?colorPrimary
- true
@@ -150,7 +150,7 @@
- @style/TimeLineBackgroundAmlod
- #040408
- #08080F
- - #483078
+ - #2962FF
- @color/amlodWindowBackground
@@ -218,7 +218,7 @@
- @style/Theme.Mal.Dark.PopupOverlay
- #040408
- #08080F
- - #483078
+ - #2962FF
- false
- #eee
- #ffe0e0e0
diff --git a/app/src/main/res/values/theme_bluish.xml b/app/src/main/res/values/theme_bluish.xml
index 77dcb5d0..4d37c0a3 100644
--- a/app/src/main/res/values/theme_bluish.xml
+++ b/app/src/main/res/values/theme_bluish.xml
@@ -154,10 +154,14 @@
- @style/CommentBoxDarkBluish
- #eee
- @style/TimeLineBackgroundBluish
+ - @color/dark_patch_addition_color
+ - @color/dark_patch_deletion_color
+ - @color/dark_patch_ref_color
+ - @color/bluishDivider
+ - @color/bluishWindowBackground
- @color/bluish_primary
- @color/bluish_primary_dark
- @color/bluish_accent
- - @color/bluishWindowBackground
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/app/src/main/res/values/theme_midnight_blue.xml b/app/src/main/res/values/theme_midnight_blue.xml
deleted file mode 100644
index 1dddbdd0..00000000
--- a/app/src/main/res/values/theme_midnight_blue.xml
+++ /dev/null
@@ -1,204 +0,0 @@
-
-
-
- #FAFAFA
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
\ No newline at end of file
diff --git a/app/src/main/res/xml/behaviour_settings.xml b/app/src/main/res/xml/behaviour_settings.xml
index 4195416f..bbdbbe8e 100644
--- a/app/src/main/res/xml/behaviour_settings.xml
+++ b/app/src/main/res/xml/behaviour_settings.xml
@@ -4,7 +4,7 @@
**Message(s):**
{{#jobs}}{{#messages}}
{{message}}
{{/messages}}{{/jobs}}'
- on_build_success: false
- on_build_failure: true
- on_build_status_changed: false
\ No newline at end of file
diff --git a/build.gradle b/build.gradle
index 3147699c..0b0e929f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,8 +1,6 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext {
- taskRequests = getGradle().getStartParameter().getTaskRequests().toString()
- isProduction = taskRequests.toLowerCase().contains("release")
butterKnifeVersion = '8.5.1'
state_version = '1.1.0'
lombokVersion = '1.12.6'
@@ -15,7 +13,7 @@ buildscript {
assertjVersion = '2.5.0'
espresseVersion = '2.2.2'
requery = '1.3.2'
- kotlin_version = '1.1.4'
+ kotlin_version = '1.1.4-2'
commonmark = '0.9.0'
}
repositories {
@@ -24,11 +22,11 @@ buildscript {
google()
}
dependencies {
- classpath 'com.android.tools.build:gradle:3.0.0-beta2'
+ classpath 'com.android.tools.build:gradle:3.0.0-beta5'
classpath 'com.google.gms:google-services:3.0.0'
classpath 'com.novoda:gradle-build-properties-plugin:0.3'
classpath 'com.dicedmelon.gradle:jacoco-android:0.1.2'
- if (isProduction) classpath 'io.fabric.tools:gradle:1.22.2'
+ classpath 'io.fabric.tools:gradle:1.24.1'
classpath 'com.apollographql.apollo:gradle-plugin:0.4.0'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "com.github.viswaramamoorthy:gradle-util-plugins:0.1.0-RELEASE"
diff --git a/debug_gradle.properties b/debug_gradle.properties
index d5332fd0..1303a8bd 100644
--- a/debug_gradle.properties
+++ b/debug_gradle.properties
@@ -1,5 +1,5 @@
# Below API Keys are meant for debugging purpose & they aren't being used in production.
-org.gradle.jvmargs=-Xmx3g -XX:MaxPermSize=2048m -XX:+HeapDumpOnOutOfMemoryError
+org.gradle.jvmargs=-Xmx2536M
android_store_password=kosh2010
android_key_password=kosh2010
android_key_alias=FastAccess
@@ -8,5 +8,4 @@ github_secret=b2d158f949d3615078eaf570ff99eba81cfa1ff9
imgur_client_id=5fced7f255e1dc9
imgur_secret=03025033403196a4b68b48f0738e67ef136ad64f
redirect_url=fasthub://login
-android.enableD8=true
android.sdk.channel=2
diff --git a/jobdispatcher/build.gradle b/jobdispatcher/build.gradle
new file mode 100644
index 00000000..d326ddf2
--- /dev/null
+++ b/jobdispatcher/build.gradle
@@ -0,0 +1,79 @@
+apply plugin: "com.android.library"
+
+android {
+ compileSdkVersion 26
+ buildToolsVersion "26.0.1"
+
+ defaultConfig {
+ minSdkVersion 16
+ targetSdkVersion 26
+ versionCode 1
+ versionName "0.8.0"
+ testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner'
+ }
+
+ defaultPublishConfig "release"
+ publishNonDefault true
+
+ buildTypes {
+ debug {
+ testCoverageEnabled true
+ }
+ release {
+ minifyEnabled false
+ proguardFiles getDefaultProguardFile('proguard-android.txt')
+ }
+ }
+
+ sourceSets {
+ // A set of testing helpers that are shared across test types
+ testLib { java.srcDir("src/main") }
+ test { java.srcDir("src/testLib") } // Robolectric tests
+ androidTest { java.srcDir("src/testLib") } // Android (e2e) tests
+ }
+}
+
+dependencies {
+ // The main library only depends on the Android support lib
+ compile "com.android.support:support-v4:26.0.1"
+
+ def junit = 'junit:junit:4.12'
+ def robolectric = 'org.robolectric:robolectric:3.3.2'
+
+ // The common test library uses JUnit
+ testLibCompile junit
+
+ // The unit tests are written using JUnit, Robolectric, and Mockito
+ testCompile junit
+ testCompile robolectric
+ testCompile 'org.mockito:mockito-core:2.2.5'
+
+ // The Android (e2e) tests are written using JUnit and the test support lib
+ androidTestCompile junit
+ androidTestCompile 'com.android.support.test:runner:0.5'
+}
+
+task javadocs(type: Javadoc) {
+ description "Generate Javadocs"
+ source = android.sourceSets.main.java.sourceFiles
+ classpath += project.files(android.getBootClasspath().join(File.pathSeparator))
+ classpath += configurations.compile
+ failOnError false
+}
+
+task javadocsJar(type: Jar, dependsOn: javadocs) {
+ description "Package Javadocs into a jar"
+ classifier = "javadoc"
+ from javadocs.destinationDir
+}
+
+task sourcesJar(type: Jar) {
+ description "Package sources into a jar"
+ classifier = "sources"
+ from android.sourceSets.main.java.sourceFiles
+}
+
+task aar(dependsOn: "assembleRelease") {
+ group "artifact"
+ description "Builds the library AARs"
+}
diff --git a/jobdispatcher/coverage.gradle b/jobdispatcher/coverage.gradle
new file mode 100644
index 00000000..204f2dc2
--- /dev/null
+++ b/jobdispatcher/coverage.gradle
@@ -0,0 +1,40 @@
+apply plugin: "jacoco"
+
+jacoco {
+ // see https://github.com/jacoco/jacoco/pull/288 and the top build.gradle
+ toolVersion "0.7.6.201602180812"
+}
+
+android {
+ testOptions {
+ unitTests.all {
+ systemProperty "robolectric.logging.enabled", true
+ systemProperty "robolectric.logging", "stdout"
+
+ jacoco {
+ includeNoLocationClasses = true
+ }
+ }
+ }
+}
+
+// ignore these when generating coverage
+def ignoredPrefixes = ['R$', 'R.class', 'BuildConfig.class']
+
+task coverage(type: JacocoReport, dependsOn: ["testDebugUnitTest"]) {
+ group = "Reports"
+ description = "Generate a coverage report"
+
+ classDirectories = fileTree(
+ dir: "${project.buildDir}/intermediates/classes/debug/com/firebase/",
+ exclude: { d -> ignoredPrefixes.any { p -> d.file.name.startsWith(p) } }
+ )
+ sourceDirectories = files(["src/main/java/com/firebase/"])
+ executionData = files("${project.buildDir}/jacoco/testDebugUnitTest.exec")
+
+ reports {
+ xml.enabled = true
+ html.enabled = true
+ html.destination "${buildDir}/coverage_html"
+ }
+}
diff --git a/jobdispatcher/src/androidTest/AndroidManifest.xml b/jobdispatcher/src/androidTest/AndroidManifest.xml
new file mode 100644
index 00000000..c87f27fc
--- /dev/null
+++ b/jobdispatcher/src/androidTest/AndroidManifest.xml
@@ -0,0 +1,35 @@
+
+
+
+
+
+
+
+
+
+
+
diff --git a/jobdispatcher/src/androidTest/java/com/firebase/jobdispatcher/EndToEndTest.java b/jobdispatcher/src/androidTest/java/com/firebase/jobdispatcher/EndToEndTest.java
new file mode 100644
index 00000000..48b1048b
--- /dev/null
+++ b/jobdispatcher/src/androidTest/java/com/firebase/jobdispatcher/EndToEndTest.java
@@ -0,0 +1,69 @@
+// Copyright 2017 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+import static org.junit.Assert.assertTrue;
+
+import android.content.Context;
+import android.support.test.InstrumentationRegistry;
+import android.support.test.runner.AndroidJUnit4;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+/**
+ * Basic end to end test for the JobDispatcher. Requires Google Play services be installed and
+ * available.
+ */
+@RunWith(AndroidJUnit4.class)
+public final class EndToEndTest {
+ private Context appContext;
+ private FirebaseJobDispatcher dispatcher;
+
+ @Before public void setUp() {
+ appContext = InstrumentationRegistry.getTargetContext();
+ dispatcher = new FirebaseJobDispatcher(new GooglePlayDriver(appContext));
+ TestJobService.reset();
+ }
+
+ @Test public void basicImmediateJob() throws InterruptedException {
+ final CountDownLatch latch = new CountDownLatch(1);
+ TestJobService.setProxy(new TestJobService.JobServiceProxy() {
+ @Override
+ public boolean onStartJob(JobParameters params) {
+ latch.countDown();
+ return false;
+ }
+
+ @Override
+ public boolean onStopJob(JobParameters params) {
+ return false;
+ }
+ });
+
+ dispatcher.mustSchedule(
+ dispatcher.newJobBuilder()
+ .setService(TestJobService.class)
+ .setTrigger(Trigger.NOW)
+ .setTag("basic-immediate-job")
+ .build());
+
+ assertTrue("Latch wasn't counted down as expected", latch.await(120, TimeUnit.SECONDS));
+ }
+}
diff --git a/jobdispatcher/src/main/AndroidManifest.xml b/jobdispatcher/src/main/AndroidManifest.xml
new file mode 100644
index 00000000..71205bd8
--- /dev/null
+++ b/jobdispatcher/src/main/AndroidManifest.xml
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/jobdispatcher/src/main/java/com/firebase/jobdispatcher/BundleProtocol.java b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/BundleProtocol.java
new file mode 100644
index 00000000..774a8340
--- /dev/null
+++ b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/BundleProtocol.java
@@ -0,0 +1,49 @@
+// Copyright 2016 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+final class BundleProtocol {
+ static final String PACKED_PARAM_BUNDLE_PREFIX = "com.firebase.jobdispatcher.";
+
+ // PACKED_PARAM values are only read on the client side, so as long as the
+ // extraction process gets the same changes then it's fine.
+ static final String PACKED_PARAM_CONSTRAINTS = "constraints";
+ static final String PACKED_PARAM_LIFETIME = "persistent";
+ static final String PACKED_PARAM_RECURRING = "recurring";
+ static final String PACKED_PARAM_SERVICE = "service";
+ static final String PACKED_PARAM_TAG = "tag";
+ static final String PACKED_PARAM_EXTRAS = "extras";
+ static final String PACKED_PARAM_TRIGGER_TYPE = "trigger_type";
+ static final String PACKED_PARAM_TRIGGER_WINDOW_END = "window_end";
+ static final String PACKED_PARAM_TRIGGER_WINDOW_START = "window_start";
+ static final int TRIGGER_TYPE_EXECUTION_WINDOW = 1;
+ static final int TRIGGER_TYPE_IMMEDIATE = 2;
+ static final int TRIGGER_TYPE_CONTENT_URI = 3;
+ static final String PACKED_PARAM_RETRY_STRATEGY_INITIAL_BACKOFF_SECONDS =
+ "initial_backoff_seconds";
+ static final String PACKED_PARAM_RETRY_STRATEGY_MAXIMUM_BACKOFF_SECONDS =
+ "maximum_backoff_seconds";
+ static final String PACKED_PARAM_RETRY_STRATEGY_POLICY = "retry_policy";
+ static final String PACKED_PARAM_REPLACE_CURRENT = "replace_current";
+ static final String PACKED_PARAM_CONTENT_URI_FLAGS_ARRAY = "content_uri_flags_array";
+ static final String PACKED_PARAM_CONTENT_URI_ARRAY = "content_uri_array";
+ static final String PACKED_PARAM_TRIGGERED_URIS = "triggered_uris";
+ static final String PACKED_PARAM_OBSERVED_URI = "observed_uris";
+
+ BundleProtocol() {
+ }
+}
diff --git a/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Constraint.java b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Constraint.java
new file mode 100644
index 00000000..ff413fb2
--- /dev/null
+++ b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Constraint.java
@@ -0,0 +1,108 @@
+// Copyright 2016 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+import android.support.annotation.IntDef;
+import android.support.annotation.VisibleForTesting;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+/**
+ * A Constraint is a runtime requirement for a job. A job only becomes eligible to run once its
+ * trigger has been activated and all constraints are satisfied.
+ */
+public final class Constraint {
+ /**
+ * Only run the job when an unmetered network is available.
+ */
+ public static final int ON_UNMETERED_NETWORK = 1;
+
+ /**
+ * Only run the job when a network connection is available. If both this and
+ * {@link #ON_UNMETERED_NETWORK} is provided, {@link #ON_UNMETERED_NETWORK} will take
+ * precedence.
+ */
+ public static final int ON_ANY_NETWORK = 1 << 1;
+
+ /**
+ * Only run the job when the device is currently charging.
+ */
+ public static final int DEVICE_CHARGING = 1 << 2;
+
+ /**
+ * Only run the job when the device is idle. This is ignored for devices that don't expose the
+ * concept of an idle state.
+ */
+ public static final int DEVICE_IDLE = 1 << 3;
+
+ @VisibleForTesting
+ static final int[] ALL_CONSTRAINTS = {
+ ON_ANY_NETWORK, ON_UNMETERED_NETWORK, DEVICE_CHARGING, DEVICE_IDLE};
+
+ /** Constraint shouldn't ever be instantiated. */
+ private Constraint() {}
+
+ /**
+ * A tooling type-hint for any of the valid constraint values.
+ */
+ @IntDef(flag = true, value = {
+ ON_ANY_NETWORK,
+ ON_UNMETERED_NETWORK,
+ DEVICE_CHARGING,
+ DEVICE_IDLE,
+ })
+ @Retention(RetentionPolicy.SOURCE)
+ public @interface JobConstraint {}
+
+ /**
+ * Compact a provided array of constraints into a single int.
+ *
+ * @see #uncompact(int)
+ */
+ static int compact(@JobConstraint int[] constraints) {
+ int result = 0;
+ if (constraints == null) {
+ return result;
+ }
+ for (int c : constraints) {
+ result |= c;
+ }
+ return result;
+ }
+
+ /**
+ * Unpack a single int into an array of constraints.
+ *
+ * @see #compact(int[])
+ */
+ static int[] uncompact(int compactConstraints) {
+ int length = 0;
+ for (int c : ALL_CONSTRAINTS) {
+ length += (compactConstraints & c) == c ? 1 : 0;
+ }
+ int[] list = new int[length];
+
+ int i = 0;
+ for (int c : ALL_CONSTRAINTS) {
+ if ((compactConstraints & c) == c) {
+ list[i++] = c;
+ }
+ }
+
+ return list;
+ }
+}
diff --git a/jobdispatcher/src/main/java/com/firebase/jobdispatcher/DefaultJobValidator.java b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/DefaultJobValidator.java
new file mode 100644
index 00000000..4804804e
--- /dev/null
+++ b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/DefaultJobValidator.java
@@ -0,0 +1,288 @@
+// Copyright 2016 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+import static com.firebase.jobdispatcher.RetryStrategy.RETRY_POLICY_EXPONENTIAL;
+import static com.firebase.jobdispatcher.RetryStrategy.RETRY_POLICY_LINEAR;
+
+import android.content.Context;
+import android.content.Intent;
+import android.content.pm.PackageManager;
+import android.content.pm.ResolveInfo;
+import android.os.Bundle;
+import android.os.Parcel;
+import android.support.annotation.CallSuper;
+import android.support.annotation.NonNull;
+import android.support.annotation.Nullable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Locale;
+
+/**
+ * Validates Jobs according to some safe standards.
+ *
+ * Custom JobValidators should typically extend from this.
+ */
+public class DefaultJobValidator implements JobValidator {
+
+ /**
+ * The maximum length of a tag, in characters (i.e. String.length()). Strings longer than this
+ * will cause validation to fail.
+ */
+ public static final int MAX_TAG_LENGTH = 100;
+
+ /**
+ * The maximum size, in bytes, that the provided extras bundle can be. Corresponds to
+ * {@link Parcel#dataSize()}.
+ */
+ public final static int MAX_EXTRAS_SIZE_BYTES = 10 * 1024;
+
+ /** Private ref to the Context. Necessary to check that the manifest is configured correctly. */
+ private final Context context;
+
+ public DefaultJobValidator(Context context) {
+ this.context = context;
+ }
+
+ /** @see {@link #MAX_EXTRAS_SIZE_BYTES}. */
+ private static int measureBundleSize(Bundle extras) {
+ Parcel p = Parcel.obtain();
+ extras.writeToParcel(p, 0);
+ int sizeInBytes = p.dataSize();
+ p.recycle();
+
+ return sizeInBytes;
+ }
+
+ /** Combines two {@literal Lists} together. */
+ @Nullable
+ private static List mergeErrorLists(@Nullable List errors,
+ @Nullable List newErrors) {
+ if (errors == null) {
+ return newErrors;
+ }
+ if (newErrors == null) {
+ return errors;
+ }
+
+ errors.addAll(newErrors);
+ return errors;
+ }
+
+ @Nullable
+ private static List addError(@Nullable List errors, String newError) {
+ if (newError == null) {
+ return errors;
+ }
+ if (errors == null) {
+ return getMutableSingletonList(newError);
+ }
+
+ Collections.addAll(errors, newError);
+
+ return errors;
+ }
+
+ @Nullable
+ private static List addErrorsIf(boolean condition, List errors, String newErr) {
+ if (condition) {
+ return addError(errors, newErr);
+ }
+
+ return errors;
+ }
+
+ /**
+ * Attempts to validate the provided {@code JobParameters}. If the JobParameters is valid, null will be
+ * returned. If the JobParameters has errors, a list of those errors will be returned.
+ */
+ @Nullable
+ @Override
+ @CallSuper
+ public List validate(JobParameters job) {
+ List errors = null;
+
+ errors = mergeErrorLists(errors, validate(job.getTrigger()));
+ errors = mergeErrorLists(errors, validate(job.getRetryStrategy()));
+
+ if (job.isRecurring() && job.getTrigger() == Trigger.NOW) {
+ errors = addError(errors, "ImmediateTriggers can't be used with recurring jobs");
+ }
+
+ errors = mergeErrorLists(errors, validateForTransport(job.getExtras()));
+ if (job.getLifetime() > Lifetime.UNTIL_NEXT_BOOT) {
+ //noinspection ConstantConditions
+ errors = mergeErrorLists(errors, validateForPersistence(job.getExtras()));
+ }
+
+ errors = mergeErrorLists(errors, validateTag(job.getTag()));
+ errors = mergeErrorLists(errors, validateService(job.getService()));
+
+ return errors;
+ }
+
+ /**
+ * Attempts to validate the provided Trigger. If valid, null is returned. Otherwise a list of
+ * errors will be returned.
+ *
+ * Note that a Trigger that passes validation here is not necessarily valid in all permutations
+ * of a JobParameters. For example, an Immediate is never valid for a recurring job.
+ * @param trigger
+ */
+ @Nullable
+ @Override
+ @CallSuper
+ public List validate(JobTrigger trigger) {
+ if (trigger != Trigger.NOW
+ && !(trigger instanceof JobTrigger.ExecutionWindowTrigger)
+ && !(trigger instanceof JobTrigger.ContentUriTrigger)) {
+ return getMutableSingletonList("Unknown trigger provided");
+ }
+
+ return null;
+ }
+
+ /**
+ * Attempts to validate the provided RetryStrategy. If valid, null is returned. Otherwise a list
+ * of errors will be returned.
+ */
+ @Nullable
+ @Override
+ @CallSuper
+ public List validate(RetryStrategy retryStrategy) {
+ List errors = null;
+
+ int policy = retryStrategy.getPolicy();
+ int initial = retryStrategy.getInitialBackoff();
+ int maximum = retryStrategy.getMaximumBackoff();
+
+ errors = addErrorsIf(policy != RETRY_POLICY_EXPONENTIAL && policy != RETRY_POLICY_LINEAR,
+ errors, "Unknown retry policy provided");
+ errors = addErrorsIf(maximum < initial,
+ errors, "Maximum backoff must be greater than or equal to initial backoff");
+ errors = addErrorsIf(300 > maximum,
+ errors, "Maximum backoff must be greater than 300s (5 minutes)");
+ errors = addErrorsIf(initial < 30,
+ errors, "Initial backoff must be at least 30s");
+
+ return errors;
+ }
+
+ @Nullable
+ private List validateForPersistence(Bundle extras) {
+ List errors = null;
+
+ if (extras != null) {
+ // check the types to make sure they're persistable
+ for (String k : extras.keySet()) {
+ errors = addError(errors, validateExtrasType(extras, k));
+ }
+ }
+
+ return errors;
+ }
+
+ @Nullable
+ private List validateForTransport(Bundle extras) {
+ if (extras == null) {
+ return null;
+ }
+
+ int bundleSizeInBytes = measureBundleSize(extras);
+ if (bundleSizeInBytes > MAX_EXTRAS_SIZE_BYTES) {
+ return getMutableSingletonList(String.format(Locale.US,
+ "Extras too large: %d bytes is > the max (%d bytes)",
+ bundleSizeInBytes, MAX_EXTRAS_SIZE_BYTES));
+ }
+
+ return null;
+ }
+
+ @Nullable
+ private String validateExtrasType(Bundle extras, String key) {
+ Object o = extras.get(key);
+
+ if (o == null
+ || o instanceof Integer
+ || o instanceof Long
+ || o instanceof Double
+ || o instanceof String
+ || o instanceof Boolean) {
+ return null;
+ }
+
+ return String.format(Locale.US,
+ "Received value of type '%s' for key '%s', but only the"
+ + " following extra parameter types are supported:"
+ + " Integer, Long, Double, String, and Boolean",
+ o == null ? null : o.getClass(), key);
+ }
+
+ private List validateService(String service) {
+ if (service == null || service.isEmpty()) {
+ return getMutableSingletonList("Service can't be empty");
+ }
+
+ if (context == null) {
+ return getMutableSingletonList("Context is null, can't query PackageManager");
+ }
+
+ PackageManager pm = context.getPackageManager();
+ if (pm == null) {
+ return getMutableSingletonList("PackageManager is null, can't validate service");
+ }
+
+ final String msg = "Couldn't find a registered service with the name " + service
+ + ". Is it declared in the manifest with the right intent-filter?";
+
+ Intent executeIntent = new Intent(JobService.ACTION_EXECUTE);
+ executeIntent.setClassName(context, service);
+ List intentServices = pm.queryIntentServices(executeIntent, 0);
+ if (intentServices == null || intentServices.isEmpty()) {
+ return getMutableSingletonList(msg);
+ }
+
+ for (ResolveInfo info : intentServices) {
+ if (info.serviceInfo != null && info.serviceInfo.enabled) {
+ // found a match!
+ return null;
+ }
+ }
+
+ return getMutableSingletonList(msg);
+ }
+
+ private List validateTag(String tag) {
+ if (tag == null) {
+ return getMutableSingletonList("Tag can't be null");
+ }
+
+ if (tag.length() > MAX_TAG_LENGTH) {
+ return getMutableSingletonList("Tag must be shorter than " + MAX_TAG_LENGTH);
+ }
+
+ return null;
+ }
+
+ @NonNull
+ private static List getMutableSingletonList(String msg) {
+ ArrayList strings = new ArrayList<>();
+ strings.add(msg);
+ return strings;
+ }
+}
diff --git a/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Driver.java b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Driver.java
new file mode 100644
index 00000000..fe832721
--- /dev/null
+++ b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/Driver.java
@@ -0,0 +1,62 @@
+// Copyright 2016 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+import android.support.annotation.NonNull;
+import com.firebase.jobdispatcher.FirebaseJobDispatcher.CancelResult;
+import com.firebase.jobdispatcher.FirebaseJobDispatcher.ScheduleResult;
+
+/**
+ * Driver represents a component that understands how to schedule, validate, and execute jobs.
+ */
+public interface Driver {
+
+ /**
+ * Schedules the provided Job.
+ *
+ * @return one of the SCHEDULE_RESULT_ constants
+ */
+ @ScheduleResult
+ int schedule(@NonNull Job job);
+
+ /**
+ * Cancels the job with the provided tag and class.
+ *
+ * @return one of the CANCEL_RESULT_ constants.
+ */
+ @CancelResult
+ int cancel(@NonNull String tag);
+
+ /**
+ * Cancels all jobs registered with this Driver.
+ *
+ * @return one of the CANCEL_RESULT_ constants.
+ */
+ @CancelResult
+ int cancelAll();
+
+ /**
+ * Returns a JobValidator configured for this backend.
+ */
+ @NonNull
+ JobValidator getValidator();
+
+ /**
+ * Indicates whether the backend is available.
+ */
+ boolean isAvailable();
+}
diff --git a/jobdispatcher/src/main/java/com/firebase/jobdispatcher/ExecutionDelegator.java b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/ExecutionDelegator.java
new file mode 100644
index 00000000..1dbacb3c
--- /dev/null
+++ b/jobdispatcher/src/main/java/com/firebase/jobdispatcher/ExecutionDelegator.java
@@ -0,0 +1,160 @@
+// Copyright 2016 Google, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+////////////////////////////////////////////////////////////////////////////////
+
+package com.firebase.jobdispatcher;
+
+import static android.content.Context.BIND_AUTO_CREATE;
+
+import android.content.Context;
+import android.content.Intent;
+import android.os.Handler;
+import android.os.Looper;
+import android.os.Message;
+import android.support.annotation.NonNull;
+import android.support.annotation.VisibleForTesting;
+import android.support.v4.util.SimpleArrayMap;
+import android.util.Log;
+import com.firebase.jobdispatcher.JobService.JobResult;
+import java.lang.ref.WeakReference;
+
+/**
+ * ExecutionDelegator tracks local Binder connections to client JobServices and handles
+ * communication with those services.
+ */
+/* package */ class ExecutionDelegator {
+ @VisibleForTesting
+ static final int JOB_FINISHED = 1;
+
+ static final String TAG = "FJD.ExternalReceiver";
+
+ interface JobFinishedCallback {
+ void onJobFinished(@NonNull JobInvocation jobInvocation, @JobResult int result);
+ }
+
+ /**
+ * A mapping of {@link JobInvocation} to (local) binder connections.
+ * Synchronized by itself.
+ */
+ private final SimpleArrayMap serviceConnections =
+ new SimpleArrayMap<>();
+ private final ResponseHandler responseHandler =
+ new ResponseHandler(Looper.getMainLooper(), new WeakReference<>(this));
+ private final Context context;
+ private final JobFinishedCallback jobFinishedCallback;
+
+ ExecutionDelegator(Context context, JobFinishedCallback jobFinishedCallback) {
+ this.context = context;
+ this.jobFinishedCallback = jobFinishedCallback;
+ }
+
+ /**
+ * Executes the provided {@code jobInvocation} by kicking off the creation of a new Binder
+ * connection to the Service.
+ *
+ * @return true if the service was bound successfully.
+ */
+ boolean executeJob(JobInvocation jobInvocation) {
+ if (jobInvocation == null) {
+ return false;
+ }
+
+ JobServiceConnection conn = new JobServiceConnection(jobInvocation,
+ responseHandler.obtainMessage(JOB_FINISHED));
+
+ synchronized (serviceConnections) {
+ JobServiceConnection oldConnection = serviceConnections.put(jobInvocation, conn);
+ if (oldConnection != null) {
+ Log.e(TAG, "Received execution request for already running job");
+ }
+ return context.bindService(createBindIntent(jobInvocation), conn, BIND_AUTO_CREATE);
+ }
+ }
+
+ @NonNull
+ private Intent createBindIntent(JobParameters jobParameters) {
+ Intent execReq = new Intent(JobService.ACTION_EXECUTE);
+ execReq.setClassName(context, jobParameters.getService());
+ return execReq;
+ }
+
+ void stopJob(JobInvocation job) {
+ synchronized (serviceConnections) {
+ JobServiceConnection jobServiceConnection = serviceConnections.remove(job);
+ if (jobServiceConnection != null) {
+ jobServiceConnection.onStop();
+ safeUnbindService(jobServiceConnection);
+ }
+ }
+ }
+
+ private void safeUnbindService(JobServiceConnection connection) {
+ if (connection != null && connection.isBound()) {
+ try {
+ context.unbindService(connection);
+ } catch (IllegalArgumentException e) {
+ Log.w(TAG, "Error unbinding service: " + e.getMessage());
+ }
+ }
+ }
+
+ private void onJobFinishedMessage(JobInvocation jobInvocation, int result) {
+ synchronized (serviceConnections) {
+ JobServiceConnection connection = serviceConnections.remove(jobInvocation);
+ safeUnbindService(connection);
+ }
+
+ jobFinishedCallback.onJobFinished(jobInvocation, result);
+ }
+
+ private static class ResponseHandler extends Handler {
+
+ /**
+ * We hold a WeakReference to the ExecutionDelegator because it holds a reference to a
+ * Service Context and Handlers are often kept in memory longer than you'd expect because
+ * any pending Messages can maintain references to them.
+ */
+ private final WeakReference
FastHub changelog -
-Version 4.0.3 (Multiple Accounts, Enterprise & PR changes) -
---Thanks to - @passsy & his company - @grandcentrix - for providing me with an Enterprise account in their server to ease implementing Enterprise support in FastHub. -
-
--Thanks to - cookicons - for creating - FastHub - new icon. -
-
--Thanks to - @dedepete - for helping out with CI & configuring nightly builds for - FastHub -
-
Bugs , Enhancements & new Features (4.0.3 & 4.0.0) -
--
-
- (4.0.3 Fix) Disabled tinting in light theme -
- (4.0.3 Fix) Fixed some notification crashes on some devices -
- (4.0.3 Fix) Updated app shortcuts icons (thanks @lucasvalenteds) -
- (4.0.3 Fix) Ordering langauge locales -
- (4.0.3 Fix) Attempt to fix a crash on some devices when browsing large number of Commit files -
- (4.0.3 New) Added copy URL to commit -
- (4.0.2 New) Added a way to disable navigation bar tinitng in different themes (Settings/Customization) -
- (4.0.2 Fix) Fixed clicking on notification might crash on some devices -
- (4.0.2 Fix) Fixed app shortcut icons to follow material design guidelines -
- (4.0.2 Fix) Fixed Traditional & Simplified Chinese langauge locale -
- (4.0.2 Fix) This release also has an attempt to fix Google Play Service crash when installing - FastHub - -
- (4.0.2 Fix) This release fixes app hangs on devices that don't have Google Play Service installed. -
- (4.0.1 Fix) Pinned repos crashes -
- (4.0.1 Fix) Multiple Accounts (if enterprise account login is same as GitHub) thanks - @passsy - -
- (New) Multiple Accounts -
- (New) Enterprise support -
- (New) PR review changes & on-line-number reviews -
- (New) Support to all merge strategies (Squash & Rebase) -
- (New) Comment on Commit file changes (on Code line number) -
- (New) Revamp of Branches & Tags, now its easy to differentiate between them -
- (New) Clicking on multiple Commits now will ask you which one to open. -
- (New) Now you can share links to FastHub from external Apps -
- (New) Showing owner & original poster in comments -
- (New) Custom code color palette -
- (New) Clicking on License should open its corresponding file -
- (New) Comment links are now copy-able thanks to (@eygraber) -
- (New) Pinned repos are now smart to sort your Pinned Repos by itself. -
- (New) Access your Repos from Menu Drawer -
- (New) Access your Starred Repos from Menu Drawer -
- (New) Showing the top most 5 accessed Pinned Repos in Menu Drawer -
- (New) - FastHub - now has Nightly builds thanks (@dedepete) - -
- (New) Disabling Issues Tab if Issues disabled in Repo. -
- (New) Added Share to Users & Organizations profiles -
- (New) Czech language thanks to (@hejsekvojtech) -
- (New) Spanish language thanks to (@alete) -
- (Enhancement) Opening FastHub from other Apps should open FastHub in new document thanks to (@eygraber) -
- (Enhancement) Wiki links -
- (Enhancement) Issue & PRs grammar -
- (Enhancement) Overall app layouts enhancements. -
- (Fix) Opening Submodule. -
- (Fix) Trending Language & today's stars. -
- (Fix) Code wrapping. -
- (Fix) PRs/Issues where the assigned user was a Team. -
- (Fix) Added back support for Local DB in some places -
- (Fix) Added Pagination to Branches & Tags. -
- (Fix) Traditional & Simplified Chinese language selector. -
- (Fix) Deep markdown images relative paths. -
- (Fix) Brought back fully zoom-out in code. -
- (Fix) More deeper file links parsing -
- (Fix) First Comment edited date. -
- (Fix) All notifications refresh isn’t disappeared. -
- (Fix) Readme progressbar -
- (Fix) Some crashes from the crash report. -
- (Fix) Lots of bug fixes -
- There are more stuff are not mentioned, find them out :p -
--P.S: FastHub is still in development mode, things will eventually come, rating FastHub 1 or 5 stars in Play store to request a new - feature or to report an issue they’ll be ignored, the best place to report issues/FRs are in GitHub issue ticket, you could go to - About & click on - Report Issue - and the issue will be posted directly to - FastHub - repo. -
-
--Thanks to everyone who contributed either via reporting bugs or via code contribution
-
- Thank you very much -
\ No newline at end of file + + + + +FastHub changelog +
+Version 4.2.0 (Create, Edit & Delete files (make Commits)) +
+++Reporting Issues or Feature Requests in Google Play review section, will be ignored or might even get your account to be blocked from + FastHub. You are using an app for GitHub, which provides a proper way to report issues. +
+
+ Please report the issues in FastHub repo instead, by opening the Drawer Menu, click about and click “Report an Issue”PLEASE + USE IT. +
Bugs , Enhancements & new Features (3.2.0) +
+-
+
- (New) Make commits on repos from FastHub (this only applies for repo owners so far). + PRO + +
- (New) Long pressing files/directories will open up their Commit/Git History. +
- (New) Indicates PR review line has a comment. +
- (New) Showing number of addition, deletion & files in PR files tab. +
- (New) Untoggle MD rendering to see their actual code. +
- (New) Settings option to disable Animations in FastHub. +
- (New) Copy SHA from Commit. +
- (New) Forks, Watchers & Stargazers links handling. +
- (Enhancement) Loading larger number of comments per page. +
- (Enhancement) Hide fab while scrolling in Issues & PR tab. +
- (Fix) PR Status where it got somehow broken in previous release. +
- (Fix) A text under PR status will indicates if the PR is mergable or not. +
- (Fix) Tagging users in full screen editor. +
- (Fix) Comments text selection where sometime they aren’t selectable. +
- (Fix) PR Review footer is invisible in (4.1.0). +
- (Fix) Cursor position after inserting emoji, links & images. +
- (Fix) Teal customized accent was displayed as green. +
- (Fix) Some crashes from the crash report. +
- (Fix) Lots of bug fixes. +
- There are more stuff are not mentioned, find them out :stuck_out_tongue: +
What left in FastHub? +
++++ So far, FastHub has implemented almost all the features of GitHub, besides forProject Cards. Hopefully in the + next release FastHub will include that. The following releases will mainly be bug fixes or if a major feature is implemented. + +
+
How old is FastHub now? +
++++ FastHub is now 5 months & a week old. Since v1.0.0 it has really grow with each and every release. The only way this was + possible, was due to the community helping out either via reporting bugs, feature requests or even give hand to fix things or + implement things in the app. I’m really grateful for having such a great community. Thank you guys! + +
+
Thank you to all who have contributed either via reporting bugs or via code contribution.
+ + + \ No newline at end of file diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index d24120f8..6dacd3b7 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -191,7 +191,7 @@설명 없음
**Message(s):**
{{#jobs}}{{#messages}}
{{message}}
{{/messages}}{{/jobs}}' - on_build_success: false - on_build_failure: true - on_build_status_changed: false \ No newline at end of file diff --git a/build.gradle b/build.gradle index 3147699c..0b0e929f 100644 --- a/build.gradle +++ b/build.gradle @@ -1,8 +1,6 @@ // Top-level build file where you can add configuration options common to all sub-projects/modules. buildscript { ext { - taskRequests = getGradle().getStartParameter().getTaskRequests().toString() - isProduction = taskRequests.toLowerCase().contains("release") butterKnifeVersion = '8.5.1' state_version = '1.1.0' lombokVersion = '1.12.6' @@ -15,7 +13,7 @@ buildscript { assertjVersion = '2.5.0' espresseVersion = '2.2.2' requery = '1.3.2' - kotlin_version = '1.1.4' + kotlin_version = '1.1.4-2' commonmark = '0.9.0' } repositories { @@ -24,11 +22,11 @@ buildscript { google() } dependencies { - classpath 'com.android.tools.build:gradle:3.0.0-beta2' + classpath 'com.android.tools.build:gradle:3.0.0-beta5' classpath 'com.google.gms:google-services:3.0.0' classpath 'com.novoda:gradle-build-properties-plugin:0.3' classpath 'com.dicedmelon.gradle:jacoco-android:0.1.2' - if (isProduction) classpath 'io.fabric.tools:gradle:1.22.2' + classpath 'io.fabric.tools:gradle:1.24.1' classpath 'com.apollographql.apollo:gradle-plugin:0.4.0' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" classpath "com.github.viswaramamoorthy:gradle-util-plugins:0.1.0-RELEASE" diff --git a/debug_gradle.properties b/debug_gradle.properties index d5332fd0..1303a8bd 100644 --- a/debug_gradle.properties +++ b/debug_gradle.properties @@ -1,5 +1,5 @@ # Below API Keys are meant for debugging purpose & they aren't being used in production. -org.gradle.jvmargs=-Xmx3g -XX:MaxPermSize=2048m -XX:+HeapDumpOnOutOfMemoryError +org.gradle.jvmargs=-Xmx2536M android_store_password=kosh2010 android_key_password=kosh2010 android_key_alias=FastAccess @@ -8,5 +8,4 @@ github_secret=b2d158f949d3615078eaf570ff99eba81cfa1ff9 imgur_client_id=5fced7f255e1dc9 imgur_secret=03025033403196a4b68b48f0738e67ef136ad64f redirect_url=fasthub://login -android.enableD8=true android.sdk.channel=2 diff --git a/jobdispatcher/build.gradle b/jobdispatcher/build.gradle new file mode 100644 index 00000000..d326ddf2 --- /dev/null +++ b/jobdispatcher/build.gradle @@ -0,0 +1,79 @@ +apply plugin: "com.android.library" + +android { + compileSdkVersion 26 + buildToolsVersion "26.0.1" + + defaultConfig { + minSdkVersion 16 + targetSdkVersion 26 + versionCode 1 + versionName "0.8.0" + testInstrumentationRunner 'android.support.test.runner.AndroidJUnitRunner' + } + + defaultPublishConfig "release" + publishNonDefault true + + buildTypes { + debug { + testCoverageEnabled true + } + release { + minifyEnabled false + proguardFiles getDefaultProguardFile('proguard-android.txt') + } + } + + sourceSets { + // A set of testing helpers that are shared across test types + testLib { java.srcDir("src/main") } + test { java.srcDir("src/testLib") } // Robolectric tests + androidTest { java.srcDir("src/testLib") } // Android (e2e) tests + } +} + +dependencies { + // The main library only depends on the Android support lib + compile "com.android.support:support-v4:26.0.1" + + def junit = 'junit:junit:4.12' + def robolectric = 'org.robolectric:robolectric:3.3.2' + + // The common test library uses JUnit + testLibCompile junit + + // The unit tests are written using JUnit, Robolectric, and Mockito + testCompile junit + testCompile robolectric + testCompile 'org.mockito:mockito-core:2.2.5' + + // The Android (e2e) tests are written using JUnit and the test support lib + androidTestCompile junit + androidTestCompile 'com.android.support.test:runner:0.5' +} + +task javadocs(type: Javadoc) { + description "Generate Javadocs" + source = android.sourceSets.main.java.sourceFiles + classpath += project.files(android.getBootClasspath().join(File.pathSeparator)) + classpath += configurations.compile + failOnError false +} + +task javadocsJar(type: Jar, dependsOn: javadocs) { + description "Package Javadocs into a jar" + classifier = "javadoc" + from javadocs.destinationDir +} + +task sourcesJar(type: Jar) { + description "Package sources into a jar" + classifier = "sources" + from android.sourceSets.main.java.sourceFiles +} + +task aar(dependsOn: "assembleRelease") { + group "artifact" + description "Builds the library AARs" +} diff --git a/jobdispatcher/coverage.gradle b/jobdispatcher/coverage.gradle new file mode 100644 index 00000000..204f2dc2 --- /dev/null +++ b/jobdispatcher/coverage.gradle @@ -0,0 +1,40 @@ +apply plugin: "jacoco" + +jacoco { + // see https://github.com/jacoco/jacoco/pull/288 and the top build.gradle + toolVersion "0.7.6.201602180812" +} + +android { + testOptions { + unitTests.all { + systemProperty "robolectric.logging.enabled", true + systemProperty "robolectric.logging", "stdout" + + jacoco { + includeNoLocationClasses = true + } + } + } +} + +// ignore these when generating coverage +def ignoredPrefixes = ['R$', 'R.class', 'BuildConfig.class'] + +task coverage(type: JacocoReport, dependsOn: ["testDebugUnitTest"]) { + group = "Reports" + description = "Generate a coverage report" + + classDirectories = fileTree( + dir: "${project.buildDir}/intermediates/classes/debug/com/firebase/", + exclude: { d -> ignoredPrefixes.any { p -> d.file.name.startsWith(p) } } + ) + sourceDirectories = files(["src/main/java/com/firebase/"]) + executionData = files("${project.buildDir}/jacoco/testDebugUnitTest.exec") + + reports { + xml.enabled = true + html.enabled = true + html.destination "${buildDir}/coverage_html" + } +} diff --git a/jobdispatcher/src/androidTest/AndroidManifest.xml b/jobdispatcher/src/androidTest/AndroidManifest.xml new file mode 100644 index 00000000..c87f27fc --- /dev/null +++ b/jobdispatcher/src/androidTest/AndroidManifest.xml @@ -0,0 +1,35 @@ + + +
+ * Custom JobValidators should typically extend from this.
+ */
+public class DefaultJobValidator implements JobValidator {
+
+ /**
+ * The maximum length of a tag, in characters (i.e. String.length()). Strings longer than this
+ * will cause validation to fail.
+ */
+ public static final int MAX_TAG_LENGTH = 100;
+
+ /**
+ * The maximum size, in bytes, that the provided extras bundle can be. Corresponds to
+ * {@link Parcel#dataSize()}.
+ */
+ public final static int MAX_EXTRAS_SIZE_BYTES = 10 * 1024;
+
+ /** Private ref to the Context. Necessary to check that the manifest is configured correctly. */
+ private final Context context;
+
+ public DefaultJobValidator(Context context) {
+ this.context = context;
+ }
+
+ /** @see {@link #MAX_EXTRAS_SIZE_BYTES}. */
+ private static int measureBundleSize(Bundle extras) {
+ Parcel p = Parcel.obtain();
+ extras.writeToParcel(p, 0);
+ int sizeInBytes = p.dataSize();
+ p.recycle();
+
+ return sizeInBytes;
+ }
+
+ /** Combines two {@literal List
+ * Note that a Trigger that passes validation here is not necessarily valid in all permutations
+ * of a JobParameters. For example, an Immediate is never valid for a recurring job.
+ * @param trigger
+ */
+ @Nullable
+ @Override
+ @CallSuper
+ public List