From 668d319ef2f3b26d10d1c366a660a931c23ec707 Mon Sep 17 00:00:00 2001 From: Yakov Date: Tue, 20 Jun 2017 16:31:34 -0400 Subject: [PATCH 1/8] My first attempt to add an info dialog --- .../repos/issues/create/CreateIssueActivity.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java index 3fd7ba33..449ba3bd 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java @@ -8,10 +8,12 @@ import android.support.annotation.NonNull; import android.support.annotation.Nullable; import android.support.design.widget.TextInputLayout; import android.support.v4.app.Fragment; +import android.support.v7.app.AlertDialog; import android.view.MotionEvent; import android.view.View; import com.evernote.android.state.State; +import com.fastaccess.BuildConfig; import com.fastaccess.R; import com.fastaccess.data.dao.model.Issue; import com.fastaccess.data.dao.model.PullRequest; @@ -213,6 +215,16 @@ public class CreateIssueActivity extends BaseActivity { + dialogInterface.dismiss(); + }) + .show(); + }; if (toolbar != null) toolbar.setSubtitle(login + "/" + repoId); } From afa520886e943009a18b1a267be3848d2c8a7a4c Mon Sep 17 00:00:00 2001 From: Yakov Date: Tue, 20 Jun 2017 17:04:45 -0400 Subject: [PATCH 2/8] Coding fix --- .../ui/modules/repos/issues/create/CreateIssueActivity.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java index 449ba3bd..e5fcd208 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java @@ -215,8 +215,8 @@ public class CreateIssueActivity extends BaseActivity Date: Tue, 20 Jun 2017 18:51:27 -0400 Subject: [PATCH 3/8] ttes --- app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 69815d81..13a0a2c3 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -30,7 +30,6 @@ android { targetSdkVersion 26 versionCode 320 versionName "3.2.0" - signingConfig signingConfigs.signing buildConfigString "GITHUB_CLIENT_ID", (buildProperties.secrets['github_client_id'] | buildProperties.notThere['github_client_id']).string buildConfigString "GITHUB_SECRET", (buildProperties.secrets['github_secret'] | buildProperties.notThere['github_secret']).string buildConfigString "IMGUR_CLIENT_ID", (buildProperties.secrets['imgur_client_id'] | buildProperties.notThere['imgur_client_id']).string @@ -48,6 +47,7 @@ android { buildTypes { release { + signingConfig signingConfigs.signing minifyEnabled true shrinkResources false proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' From 1b1c56d839abd6cc06f623d9fdd031da7ed17480 Mon Sep 17 00:00:00 2001 From: Yakov Date: Tue, 20 Jun 2017 19:00:32 -0400 Subject: [PATCH 4/8] Test number 2 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8569113f..6bd75bf0 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ We have configurated snapshots of FastHub, which can be downloaded from [AppVeyo - _FastHub is actively developed. More features will come!_ ~~> **FastHub** contain Ads, which are disabled by default. You could enable them if you'd like to support the development.~~ -Adverts will not be available until the further notice. +Adverts will not be available until the further notice! # Specs / Open-source libraries: From 267a4b049db99bdbd2e0d267eb89e29a4fc55aaf Mon Sep 17 00:00:00 2001 From: Yakov Date: Wed, 21 Jun 2017 09:44:45 -0400 Subject: [PATCH 5/8] Changed things :) --- .../ui/modules/repos/issues/create/CreateIssueActivity.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java index e5fcd208..8deb0bfb 100644 --- a/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java +++ b/app/src/main/java/com/fastaccess/ui/modules/repos/issues/create/CreateIssueActivity.java @@ -220,9 +220,7 @@ public class CreateIssueActivity extends BaseActivity { - dialogInterface.dismiss(); - }) + .setPositiveButton(android.R.string.ok, null) .show(); } if (toolbar != null) toolbar.setSubtitle(login + "/" + repoId); From 80795028165e6af414e177097196099c4ba776df Mon Sep 17 00:00:00 2001 From: Yakov Date: Wed, 21 Jun 2017 09:47:09 -0400 Subject: [PATCH 6/8] Revert "ttes" This reverts commit e857e25c3173de26e391f3ac165e1a5dbed09ff8. --- app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index 13a0a2c3..69815d81 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -30,6 +30,7 @@ android { targetSdkVersion 26 versionCode 320 versionName "3.2.0" + signingConfig signingConfigs.signing buildConfigString "GITHUB_CLIENT_ID", (buildProperties.secrets['github_client_id'] | buildProperties.notThere['github_client_id']).string buildConfigString "GITHUB_SECRET", (buildProperties.secrets['github_secret'] | buildProperties.notThere['github_secret']).string buildConfigString "IMGUR_CLIENT_ID", (buildProperties.secrets['imgur_client_id'] | buildProperties.notThere['imgur_client_id']).string @@ -47,7 +48,6 @@ android { buildTypes { release { - signingConfig signingConfigs.signing minifyEnabled true shrinkResources false proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro' From 82de4a4e6f61ac8395ee343dafe4bfb29443542a Mon Sep 17 00:00:00 2001 From: Yakov Date: Wed, 21 Jun 2017 09:48:50 -0400 Subject: [PATCH 7/8] Changed things :) --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6bd75bf0..2d8dac79 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ We have configurated snapshots of FastHub, which can be downloaded from [AppVeyo - _FastHub is actively developed. More features will come!_ ~~> **FastHub** contain Ads, which are disabled by default. You could enable them if you'd like to support the development.~~ -Adverts will not be available until the further notice! +Ads will not be available until the further notice! # Specs / Open-source libraries: From 2e93d8a35d4f28513d01eb9c06178b8a00d4f268 Mon Sep 17 00:00:00 2001 From: Kosh Sergani Date: Wed, 21 Jun 2017 21:58:38 +0800 Subject: [PATCH 8/8] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d8dac79..98ceaa19 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ We have configurated snapshots of FastHub, which can be downloaded from [AppVeyo - _FastHub is actively developed. More features will come!_ ~~> **FastHub** contain Ads, which are disabled by default. You could enable them if you'd like to support the development.~~ -Ads will not be available until the further notice! +_Ads currently not available._ # Specs / Open-source libraries: