archive-gh-me/Chart.js
1
0
Fork 0
mirror of https://github.com/chartjs/Chart.js.git synced 2025-12-08 20:36:08 +00:00
Code Issues Projects Releases Wiki Activity

Update TypeScript ESLint configuration (#8288)

Browse Source 
Using TypeScript-specific ESLint rules fixes some spurious ESLint warnings.
This commit is contained in:
Josh Kelley 2021-01-08 16:01:20 -05:00 committed by GitHub
parent e63beb8c6d
commit fa375ff448
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
types/.eslintrc.yml
View File

@ -7,11 +7,16 @@ extends:
- chartjs
- plugin:@typescript-eslint/recommended
# These rules were set to warning to make the linting pass initially,
# without making any major changes to types.
rules:
no-use-before-define: "warn"
no-shadow: "warn"
# Replace stock eslint rules with typescript-eslint equivalents for proper
# TypeScript support.
no-use-before-define: "off"
'@typescript-eslint/no-use-before-define': "error"
no-shadow: "off"
'@typescript-eslint/no-shadow': "error"
# These rules were set to warning to make the linting pass initially,
# without making any major changes to types.
object-curly-spacing: ["warn", "always"]
'@typescript-eslint/no-empty-interface': "warn"
'@typescript-eslint/ban-types': "warn"

2
types/index.esm.d.ts vendored
View File

@ -965,7 +965,7 @@ export interface Plugin<O = {}> extends ExtendedPlugin {
* @param {Chart} chart - The chart instance.
* @param {object} args - The call arguments.
* @param {ChartEvent} args.event - The event object.
* @param {boolean} replay - True if this event is replayed from `Chart.update`
* @param {boolean} args.replay - True if this event is replayed from `Chart.update`
* @param {object} options - The plugin options.
*/
beforeEvent?(chart: Chart, args: { event: ChartEvent, replay: boolean }, options: O): boolean | void;